Title: [228368] trunk/Source/WebCore
- Revision
- 228368
- Author
- [email protected]
- Date
- 2018-02-11 12:09:57 -0800 (Sun, 11 Feb 2018)
Log Message
[GTK] Scrolling sometimes jumps around
https://bugs.webkit.org/show_bug.cgi?id=178519
Patch by Gustavo Noronha Silva <[email protected]> on 2018-02-11
Reviewed by Michael Catanzaro.
* platform/gtk/ScrollAnimatorGtk.cpp:
(WebCore::ScrollAnimatorGtk::computeVelocity): use -1 as the multiplier for the accumulated deltas,
since all we need is to make them negative. Multiplying by -1000 leads to very high velocities being
returned, causing the viewport to scroll to the end of the page.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (228367 => 228368)
--- trunk/Source/WebCore/ChangeLog 2018-02-11 01:53:35 UTC (rev 228367)
+++ trunk/Source/WebCore/ChangeLog 2018-02-11 20:09:57 UTC (rev 228368)
@@ -1,3 +1,15 @@
+2018-02-11 Gustavo Noronha Silva <[email protected]>
+
+ [GTK] Scrolling sometimes jumps around
+ https://bugs.webkit.org/show_bug.cgi?id=178519
+
+ Reviewed by Michael Catanzaro.
+
+ * platform/gtk/ScrollAnimatorGtk.cpp:
+ (WebCore::ScrollAnimatorGtk::computeVelocity): use -1 as the multiplier for the accumulated deltas,
+ since all we need is to make them negative. Multiplying by -1000 leads to very high velocities being
+ returned, causing the viewport to scroll to the end of the page.
+
2018-02-10 Wenson Hsieh <[email protected]>
Remove an unused static variable in DeprecatedGlobalSettings.h
Modified: trunk/Source/WebCore/platform/gtk/ScrollAnimatorGtk.cpp (228367 => 228368)
--- trunk/Source/WebCore/platform/gtk/ScrollAnimatorGtk.cpp 2018-02-11 01:53:35 UTC (rev 228367)
+++ trunk/Source/WebCore/platform/gtk/ScrollAnimatorGtk.cpp 2018-02-11 20:09:57 UTC (rev 228368)
@@ -122,7 +122,7 @@
m_scrollHistory.clear();
- return FloatPoint(accumDelta.x() * -1000 / (last - first).value(), accumDelta.y() * -1000 / (last - first).value());
+ return FloatPoint(accumDelta.x() * -1 / (last - first).value(), accumDelta.y() * -1 / (last - first).value());
}
bool ScrollAnimatorGtk::handleWheelEvent(const PlatformWheelEvent& event)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
