Title: [228501] trunk/Tools
Revision
228501
Author
ctur...@igalia.com
Date
2018-02-14 18:52:50 -0800 (Wed, 14 Feb 2018)

Log Message

Get Garden-O-Matic running again.
https://bugs.webkit.org/show_bug.cgi?id=179089

Reviewed by Carlos Alberto Lopez Perez.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Trac.js:
(parseCommitData): Author field is not always spelled 'author' these days.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
No longer have a 32-bit builder.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/perf.js:
(ui.perf.View.base.init): createElement has a required parameter these days.
* Scripts/webkitpy/tool/commands/gardenomatic.py:
(GardenOMatic): Override use_globs so that platform lookup in config.js works.

Modified Paths

Diff

Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Trac.js (228500 => 228501)


--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Trac.js	2018-02-15 02:08:41 UTC (rev 228500)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Trac.js	2018-02-15 02:52:50 UTC (rev 228501)
@@ -90,7 +90,8 @@
 {
     var commits = Array.prototype.map.call(responseXML.getElementsByTagName('item'), function(item) {
         var title = item.getElementsByTagName('title')[0].textContent;
-        var author = item.getElementsByTagName('author')[0].textContent;
+        var author = item.getElementsByTagName('author')[0] || item.getElementsByTagName('dc:creator')[0];
+        author = author.textContent;
         var time = item.getElementsByTagName('pubDate')[0].textContent;
 
         // FIXME: This isn't a very high-fidelity reproduction of the commit message,

Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js (228500 => 228501)


--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js	2018-02-15 02:08:41 UTC (rev 228500)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js	2018-02-15 02:52:50 UTC (rev 228501)
@@ -66,7 +66,6 @@
         layoutTestResultsURL: 'https://build.webkit.org/results',
         waterfallURL: 'https://build.webkit.org/waterfall',
         builders: {
-            'GTK Linux 32-bit Release' : {version: '32-bit release'},
             'GTK Linux 64-bit Release (Tests)' : {version: '64-bit release'},
             'GTK Linux 64-bit Debug (Tests)' : {version: '64-bit debug', debug: true},
         },

Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/perf.js (228500 => 228501)


--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/perf.js	2018-02-15 02:08:41 UTC (rev 228500)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/perf.js	2018-02-15 02:52:50 UTC (rev 228501)
@@ -52,7 +52,7 @@
         builders.perfBuilders(this.loadGraphs.bind(this));
 
         var stream = new ui.notifications.Stream();
-        var notifications = document.createElement()
+        var notifications = document.createElement('div');
         this._notification = ui.notifications.Info("Loading list of perf dashboards...");
         stream.appendChild(this._notification);
         this.appendChild(stream);

Modified: trunk/Tools/ChangeLog (228500 => 228501)


--- trunk/Tools/ChangeLog	2018-02-15 02:08:41 UTC (rev 228500)
+++ trunk/Tools/ChangeLog	2018-02-15 02:52:50 UTC (rev 228501)
@@ -1,3 +1,19 @@
+2018-02-14  Charlie Turner  <ctur...@igalia.com>
+
+        Get Garden-O-Matic running again.
+        https://bugs.webkit.org/show_bug.cgi?id=179089
+
+        Reviewed by Carlos Alberto Lopez Perez.
+
+        * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Trac.js:
+        (parseCommitData): Author field is not always spelled 'author' these days.
+        * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
+        No longer have a 32-bit builder.
+        * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/perf.js:
+        (ui.perf.View.base.init): createElement has a required parameter these days.
+        * Scripts/webkitpy/tool/commands/gardenomatic.py:
+        (GardenOMatic): Override use_globs so that platform lookup in config.js works.
+
 2018-02-14  Don Olmstead  <don.olmst...@sony.com>
 
         Remove unused ForwardingHeaders directories from Tools

Modified: trunk/Tools/Scripts/webkitpy/tool/commands/gardenomatic.py (228500 => 228501)


--- trunk/Tools/Scripts/webkitpy/tool/commands/gardenomatic.py	2018-02-15 02:08:41 UTC (rev 228500)
+++ trunk/Tools/Scripts/webkitpy/tool/commands/gardenomatic.py	2018-02-15 02:52:50 UTC (rev 228501)
@@ -25,6 +25,7 @@
 from webkitpy.port import builders
 from webkitpy.tool.commands.rebaseline import AbstractRebaseliningCommand
 from webkitpy.tool.servers.gardeningserver import GardeningHTTPServer
+from webkitpy.port import factory
 
 
 class GardenOMatic(AbstractRebaseliningCommand):
@@ -31,6 +32,10 @@
     name = "garden-o-matic"
     help_text = "Command for gardening the WebKit tree."
 
+    # REVIEW: Reset the option here because globbing isn't useful for us, but apparently
+    # it's useful for other rebaselining commands because use_globs=True is set in parent.
+    platform_options = factory.platform_options()
+
     def __init__(self):
         super(GardenOMatic, self).__init__(options=(self.platform_options + [
             self.move_overwritten_baselines_option,
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to