Title: [228608] trunk
Revision
228608
Author
[email protected]
Date
2018-02-18 23:46:54 -0800 (Sun, 18 Feb 2018)

Log Message

patch

Modified Paths


Diff

Modified: trunk/ChangeLog (228607 => 228608)


--- trunk/ChangeLog	2018-02-19 02:46:34 UTC (rev 228607)
+++ trunk/ChangeLog	2018-02-19 07:46:54 UTC (rev 228608)
@@ -1,3 +1,13 @@
+2018-02-18  Philippe Normand  <[email protected]>
+
+        [GTK][WPE] Fullscreen video is broken
+        https://bugs.webkit.org/show_bug.cgi?id=182740
+
+        Reviewed by Michael Catanzaro.
+
+        * Source/cmake/WebKitFeatures.cmake: Enable the
+        VIDEO_USES_ELEMENT_FULLSCREEN feature on CMake ports.
+
 2018-02-16  Dean Jackson  <[email protected]>
 
         Use OPENGL macros to be more clear about which OpenGL/ES WebGL uses on Cocoa

Modified: trunk/LayoutTests/ChangeLog (228607 => 228608)


--- trunk/LayoutTests/ChangeLog	2018-02-19 02:46:34 UTC (rev 228607)
+++ trunk/LayoutTests/ChangeLog	2018-02-19 07:46:54 UTC (rev 228608)
@@ -1,3 +1,12 @@
+2018-02-18  Philippe Normand  <[email protected]>
+
+        [GTK][WPE] Fullscreen video is broken
+        https://bugs.webkit.org/show_bug.cgi?id=182740
+
+        Reviewed by Michael Catanzaro.
+
+        * platform/gtk/TestExpectations: Unflag now-passing fullscreen tests.
+
 2018-02-18  Zalan Bujtas  <[email protected]>
 
         [RenderTreeBuilder] REGRESSION(r228238) Detach renderer before destroying its subtree.

Modified: trunk/LayoutTests/platform/gtk/TestExpectations (228607 => 228608)


--- trunk/LayoutTests/platform/gtk/TestExpectations	2018-02-19 02:46:34 UTC (rev 228607)
+++ trunk/LayoutTests/platform/gtk/TestExpectations	2018-02-19 07:46:54 UTC (rev 228608)
@@ -2267,8 +2267,6 @@
 
 webkit.org/b/182108 http/tests/media/hls/hls-webvtt-tracks.html [ Timeout ]
 
-webkit.org/b/182109 media/video-fullscreen-reload-crash.html [ Timeout ]
-
 webkit.org/b/182317 http/tests/resourceLoadStatistics/grandfathering.html [ Pass Failure ]
 
 #////////////////////////////////////////////////////////////////////////////////////////
@@ -3287,13 +3285,6 @@
 
 webkit.org/b/179605 editing/execCommand/underline-selection-containing-image.html [ Failure ]
 
-webkit.org/b/179721 media/video-fullscreen-restriction-removed.html [ Failure ]
-webkit.org/b/179721 fullscreen/full-screen-iframe-legacy.html [ Timeout ]
-webkit.org/b/179721 media/media-fullscreen-inline.html [ Timeout ]
-webkit.org/b/179721 media/media-fullscreen-not-in-document.html [ Timeout ]
-webkit.org/b/179721 media/media-fullscreen-return-to-inline.html [ Timeout Crash ]
-webkit.org/b/179721 media/video-fullscreeen-only-playback.html [ Timeout ]
-
 webkit.org/b/179722 compositing/accelerated-layers-after-back.html [ Failure ]
 
 webkit.org/b/179113 fast/inline/padding-ellipsis-right.html [ ImageOnlyFailure ]

Modified: trunk/Source/cmake/WebKitFeatures.cmake (228607 => 228608)


--- trunk/Source/cmake/WebKitFeatures.cmake	2018-02-19 02:46:34 UTC (rev 228607)
+++ trunk/Source/cmake/WebKitFeatures.cmake	2018-02-19 07:46:54 UTC (rev 228608)
@@ -172,6 +172,7 @@
     WEBKIT_OPTION_DEFINE(ENABLE_USER_MESSAGE_HANDLERS "Toggle user script message handler support" PRIVATE ON)
     WEBKIT_OPTION_DEFINE(ENABLE_VIDEO "Toggle Video support" PRIVATE ON)
     WEBKIT_OPTION_DEFINE(ENABLE_VIDEO_TRACK "Toggle Track support for HTML5 video" PRIVATE ON)
+    WEBKIT_OPTION_DEFINE(ENABLE_VIDEO_USES_ELEMENT_FULLSCREEN "Toggle video element fullscreen support" PRIVATE ON)
     WEBKIT_OPTION_DEFINE(ENABLE_WEBASSEMBLY "Toggle WebAssembly support" PRIVATE ${ENABLE_FTL_DEFAULT})
     WEBKIT_OPTION_DEFINE(ENABLE_WEBDRIVER "Whether to enable the WebDriver service process" PRIVATE OFF)
     WEBKIT_OPTION_DEFINE(ENABLE_WEBGL "Toggle WebGL support" PRIVATE ON)
@@ -196,6 +197,7 @@
     WEBKIT_OPTION_DEPEND(ENABLE_MEDIA_SOURCE ENABLE_VIDEO)
     WEBKIT_OPTION_DEPEND(ENABLE_MEDIA_STREAM ENABLE_VIDEO)
     WEBKIT_OPTION_DEPEND(ENABLE_VIDEO_TRACK ENABLE_VIDEO)
+    WEBKIT_OPTION_DEPEND(ENABLE_VIDEO_USES_ELEMENT_FULLSCREEN ENABLE_VIDEO)
     WEBKIT_OPTION_DEPEND(ENABLE_TOUCH_SLIDER ENABLE_TOUCH_EVENTS)
     WEBKIT_OPTION_DEPEND(ENABLE_SUBTLE_CRYPTO ENABLE_WEB_CRYPTO)
 endmacro()
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to