Title: [228690] releases/WebKitGTK/webkit-2.20/Source/WebCore
Revision
228690
Author
carlo...@webkit.org
Date
2018-02-19 08:16:10 -0800 (Mon, 19 Feb 2018)

Log Message

Merge r228368 - [GTK] Scrolling sometimes jumps around
https://bugs.webkit.org/show_bug.cgi?id=178519

Patch by Gustavo Noronha Silva <gustavo.noro...@collabora.co.uk> on 2018-02-11
Reviewed by Michael Catanzaro.

* platform/gtk/ScrollAnimatorGtk.cpp:
(WebCore::ScrollAnimatorGtk::computeVelocity): use -1 as the multiplier for the accumulated deltas,
since all we need is to make them negative. Multiplying by -1000 leads to very high velocities being
returned, causing the viewport to scroll to the end of the page.

Modified Paths

Diff

Modified: releases/WebKitGTK/webkit-2.20/Source/WebCore/ChangeLog (228689 => 228690)


--- releases/WebKitGTK/webkit-2.20/Source/WebCore/ChangeLog	2018-02-19 16:16:07 UTC (rev 228689)
+++ releases/WebKitGTK/webkit-2.20/Source/WebCore/ChangeLog	2018-02-19 16:16:10 UTC (rev 228690)
@@ -1,3 +1,15 @@
+2018-02-11  Gustavo Noronha Silva  <gustavo.noro...@collabora.co.uk>
+
+        [GTK] Scrolling sometimes jumps around
+        https://bugs.webkit.org/show_bug.cgi?id=178519
+
+        Reviewed by Michael Catanzaro.
+
+        * platform/gtk/ScrollAnimatorGtk.cpp:
+        (WebCore::ScrollAnimatorGtk::computeVelocity): use -1 as the multiplier for the accumulated deltas,
+        since all we need is to make them negative. Multiplying by -1000 leads to very high velocities being
+        returned, causing the viewport to scroll to the end of the page.
+
 2018-02-10  Zalan Bujtas  <za...@apple.com>
 
         [RenderTreeBuilder] Move RenderBlock::takeChild mutation to a RenderTreeBuilder

Modified: releases/WebKitGTK/webkit-2.20/Source/WebCore/platform/gtk/ScrollAnimatorGtk.cpp (228689 => 228690)


--- releases/WebKitGTK/webkit-2.20/Source/WebCore/platform/gtk/ScrollAnimatorGtk.cpp	2018-02-19 16:16:07 UTC (rev 228689)
+++ releases/WebKitGTK/webkit-2.20/Source/WebCore/platform/gtk/ScrollAnimatorGtk.cpp	2018-02-19 16:16:10 UTC (rev 228690)
@@ -122,7 +122,7 @@
 
     m_scrollHistory.clear();
 
-    return FloatPoint(accumDelta.x() * -1000 / (last - first).value(), accumDelta.y() * -1000 / (last - first).value());
+    return FloatPoint(accumDelta.x() * -1 / (last - first).value(), accumDelta.y() * -1 / (last - first).value());
 }
 
 bool ScrollAnimatorGtk::handleWheelEvent(const PlatformWheelEvent& event)
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to