Title: [228817] trunk/LayoutTests
- Revision
- 228817
- Author
- [email protected]
- Date
- 2018-02-20 06:11:05 -0800 (Tue, 20 Feb 2018)
Log Message
[css3-text] Skip tests that need ENABLE_CSS3_TEXT
https://bugs.webkit.org/show_bug.cgi?id=182963
Unreviewed gardening.
These tests were marked in the different TestExpectations fails of each port,
when actually none of them were testing this code as ENABLE_CSS3_TEXT is disabled by default
(even in development builds).
The patch just moves the flagged tests from the port specific TestExpectations files
to the generic TestExpectations file skipping them.
It also removes editing/pasteboard/insert-text-decoration.html from the skipping list
as it should be passing for Mac an iOs too.
* TestExpectations:
* platform/gtk/TestExpectations:
* platform/ios/TestExpectations:
* platform/mac/TestExpectations:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (228816 => 228817)
--- trunk/LayoutTests/ChangeLog 2018-02-20 13:49:04 UTC (rev 228816)
+++ trunk/LayoutTests/ChangeLog 2018-02-20 14:11:05 UTC (rev 228817)
@@ -1,3 +1,25 @@
+2018-02-20 Manuel Rego Casasnovas <[email protected]>
+
+ [css3-text] Skip tests that need ENABLE_CSS3_TEXT
+ https://bugs.webkit.org/show_bug.cgi?id=182963
+
+ Unreviewed gardening.
+
+ These tests were marked in the different TestExpectations fails of each port,
+ when actually none of them were testing this code as ENABLE_CSS3_TEXT is disabled by default
+ (even in development builds).
+
+ The patch just moves the flagged tests from the port specific TestExpectations files
+ to the generic TestExpectations file skipping them.
+
+ It also removes editing/pasteboard/insert-text-decoration.html from the skipping list
+ as it should be passing for Mac an iOs too.
+
+ * TestExpectations:
+ * platform/gtk/TestExpectations:
+ * platform/ios/TestExpectations:
+ * platform/mac/TestExpectations:
+
2018-02-19 Fujii Hironori <[email protected]>
null m_lastNodeInserted dereference at ReplaceSelectionCommand::InsertedNodes::lastLeafInserted
Modified: trunk/LayoutTests/TestExpectations (228816 => 228817)
--- trunk/LayoutTests/TestExpectations 2018-02-20 13:49:04 UTC (rev 228816)
+++ trunk/LayoutTests/TestExpectations 2018-02-20 14:11:05 UTC (rev 228817)
@@ -1590,6 +1590,12 @@
imported/w3c/web-platform-tests/secure-contexts/basic-dedicated-worker.https.html [ Skip ]
imported/w3c/web-platform-tests/secure-contexts/basic-popup-and-iframe-tests.https.html [ Skip ]
+# CSS3 Text support is not yet enabled (needs ENABLE_CSS3_TEXT).
+webkit.org/b/76173 fast/css3-text/css3-text-align-last [ Skip ]
+webkit.org/b/99945 fast/css3-text/css3-text-justify [ Skip ]
+webkit.org/b/112755 fast/css3-text/css3-text-indent/text-indent-each-line-hanging.html [ Skip ]
+webkit.org/b/112755 fast/css3-text/css3-text-indent/getComputedStyle [ Skip ]
+
### END OF -disabled tests
########################################
Modified: trunk/LayoutTests/platform/gtk/TestExpectations (228816 => 228817)
--- trunk/LayoutTests/platform/gtk/TestExpectations 2018-02-20 13:49:04 UTC (rev 228816)
+++ trunk/LayoutTests/platform/gtk/TestExpectations 2018-02-20 14:11:05 UTC (rev 228817)
@@ -1063,10 +1063,6 @@
webkit.org/b/158836 imported/w3c/web-platform-tests/encrypted-media [ Skip ]
-# CSS3 Text each-line and hanging indent not supported
-webkit.org/b/112755 fast/css3-text/css3-text-indent/getComputedStyle/getComputedStyle-text-indent.html [ Failure ]
-webkit.org/b/112755 fast/css3-text/css3-text-indent/getComputedStyle/getComputedStyle-text-indent-inherited.html [ Failure ]
-
# CSS image-orientation is not yet enabled.
webkit.org/b/89052 fast/css/image-orientation [ Skip ]
@@ -1205,7 +1201,7 @@
webkit.org/b/177633 http/tests/security/clipboard/copy-paste-url-across-origin-sanitizes-url.html [ Failure ]
webkit.org/b/177633 http/tests/security/clipboard/copy-paste-html-across-origin-strips-mso-list.html [ Failure ]
-# We should consider enabling ENABLE_LINK_PREFETCH and ENABLE_CSS3_TEXT
+# We should consider enabling ENABLE_LINK_PREFETCH
webkit.org/b/179989 http/tests/misc/prefetch-purpose.html [ Skip ]
webkit.org/b/179989 http/tests/misc/link-rel-prefetch-and-subresource.html [ Skip ]
webkit.org/b/179989 fast/dom/HTMLLinkElement/subresource.html [ Skip ]
@@ -1214,10 +1210,6 @@
webkit.org/b/179989 fast/dom/HTMLLinkElement/prefetch.html [ Skip ]
webkit.org/b/179989 fast/dom/HTMLLinkElement/link-and-subresource-test-nonexistent.html [ Skip ]
webkit.org/b/179989 fast/dom/HTMLLinkElement/link-and-subresource-test.html [ Skip ]
-webkit.org/b/179989 fast/css3-text/css3-text-justify/getComputedStyle/getComputedStyle-text-justify-inherited.html [ Failure ]
-webkit.org/b/179989 fast/css3-text/css3-text-justify/getComputedStyle/getComputedStyle-text-justify.html [ Failure ]
-webkit.org/b/179989 fast/css3-text/css3-text-align-last/getComputedStyle/getComputedStyle-text-align-last-inherited.html [ Failure ]
-webkit.org/b/179989 fast/css3-text/css3-text-align-last/getComputedStyle/getComputedStyle-text-align-last.html [ Failure ]
webkit.org/b/180062 fast/text/user-installed-fonts [ Skip ]
@@ -3077,13 +3069,8 @@
webkit.org/b/163977 fast/css/will-change/will-change-creates-stacking-context-inline.html [ ImageOnlyFailure ]
webkit.org/b/163979 fast/css/will-change/will-change-creates-stacking-context.html [ ImageOnlyFailure ]
-webkit.org/b/163980 fast/css3-text/css3-text-align-last/text-align-last-with-text-align-justify.html [ ImageOnlyFailure ]
-webkit.org/b/163980 fast/css3-text/css3-text-justify/text-justify-none.html [ ImageOnlyFailure ]
-
webkit.org/b/163981 fast/css3-text/css3-text-decoration/text-underline-position/underline-visual-overflow-with-subpixel-position.html [ Failure ]
-webkit.org/b/163982 fast/css3-text/css3-text-indent/text-indent-each-line-hanging.html [ ImageOnlyFailure ]
-
webkit.org/b/163984 fast/dom/Window/child-window-focus.html [ Failure ]
webkit.org/b/167999 imported/w3c/web-platform-tests/fetch/api/redirect/redirect-count-worker.html [ Failure ]
Modified: trunk/LayoutTests/platform/ios/TestExpectations (228816 => 228817)
--- trunk/LayoutTests/platform/ios/TestExpectations 2018-02-20 13:49:04 UTC (rev 228816)
+++ trunk/LayoutTests/platform/ios/TestExpectations 2018-02-20 14:11:05 UTC (rev 228817)
@@ -222,11 +222,6 @@
# CSS Device Adaptation is not enabled.
webkit.org/b/95959 css3/device-adapt [ Skip ]
-# Some CSS3 Text tests are not enabled on iOS
-webkit.org/b/76173 fast/css3-text/css3-text-align-last
-webkit.org/b/99945 fast/css3-text/css3-text-justify
-webkit.org/b/112755 fast/css3-text/css3-text-indent
-
# Unsupported on certain OS versions
webkit.org/b/152491 fast/text/woff2.html [ Skip ]
@@ -3182,12 +3177,6 @@
webkit.org/b/142087 fast/css3-text/css3-text-decoration/no-gap-between-two-rounded-textboxes.html [ ImageOnlyFailure ]
webkit.org/b/142087 fast/css3-text/css3-text-decoration/text-decoration-skip/text-decoration-skip-ink-inherit.html [ ImageOnlyFailure ]
-# CSS3 Text support is not yet enabled (needs ENABLE_CSS3_TEXT).
-webkit.org/b/112755 fast/css3-text/css3-text-indent/text-indent-each-line-hanging.html [ ImageOnlyFailure ]
-webkit.org/b/112755 fast/css3-text/css3-text-indent/getComputedStyle/getComputedStyle-text-indent.html [ Failure ]
-webkit.org/b/112755 fast/css3-text/css3-text-indent/getComputedStyle/getComputedStyle-text-indent-inherited.html [ Failure ]
-webkit.org/b/58491 editing/pasteboard/insert-text-decoration.html [ Skip ]
-
webkit.org/b/177322 [ Debug ] imported/w3c/web-platform-tests/html/semantics/document-metadata/the-meta-element/pragma-directives/attr-meta-http-equiv-refresh/parsing.html [ Pass Failure ]
webkit.org/b/178029 http/tests/preload/viewport/meta-viewport-link-headers.php [ Pass Failure ]
Modified: trunk/LayoutTests/platform/mac/TestExpectations (228816 => 228817)
--- trunk/LayoutTests/platform/mac/TestExpectations 2018-02-20 13:49:04 UTC (rev 228816)
+++ trunk/LayoutTests/platform/mac/TestExpectations 2018-02-20 14:11:05 UTC (rev 228817)
@@ -462,14 +462,6 @@
# CSS image-orientation is not yet enabled.
webkit.org/b/89052 fast/css/image-orientation
-# CSS3 Text support is not yet enabled (needs ENABLE_CSS3_TEXT).
-webkit.org/b/76173 fast/css3-text/css3-text-align-last
-webkit.org/b/99945 fast/css3-text/css3-text-justify [ Skip ]
-webkit.org/b/112755 fast/css3-text/css3-text-indent/text-indent-each-line-hanging.html [ ImageOnlyFailure ]
-webkit.org/b/112755 fast/css3-text/css3-text-indent/getComputedStyle/getComputedStyle-text-indent.html [ Failure ]
-webkit.org/b/112755 fast/css3-text/css3-text-indent/getComputedStyle/getComputedStyle-text-indent-inherited.html [ Failure ]
-webkit.org/b/58491 editing/pasteboard/insert-text-decoration.html [ Skip ]
-
# MHTML is not yet enabled
mhtml [ Skip ]
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
