Title: [228822] trunk
- Revision
- 228822
- Author
- [email protected]
- Date
- 2018-02-20 09:52:34 -0800 (Tue, 20 Feb 2018)
Log Message
Handle all writing-modes in downcast
https://bugs.webkit.org/show_bug.cgi?id=182949
<rdar://problem/37710687>
Reviewed by Myles Maxfield.
Source/WebCore:
It appears we forgot to handle the deprecated "lr"
writing-mode value.
Test: fast/writing-mode/svg-writing-modes.html
* css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::operator WritingMode const):
LayoutTests:
Test all the deprecated SVG writing modes.
* fast/writing-mode/svg-writing-modes-expected.html: Added.
* fast/writing-mode/svg-writing-modes.html: Added.
Modified Paths
Added Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (228821 => 228822)
--- trunk/LayoutTests/ChangeLog 2018-02-20 17:03:07 UTC (rev 228821)
+++ trunk/LayoutTests/ChangeLog 2018-02-20 17:52:34 UTC (rev 228822)
@@ -1,3 +1,16 @@
+2018-02-19 Dean Jackson <[email protected]>
+
+ Handle all writing-modes in downcast
+ https://bugs.webkit.org/show_bug.cgi?id=182949
+ <rdar://problem/37710687>
+
+ Reviewed by Myles Maxfield.
+
+ Test all the deprecated SVG writing modes.
+
+ * fast/writing-mode/svg-writing-modes-expected.html: Added.
+ * fast/writing-mode/svg-writing-modes.html: Added.
+
2018-02-20 Manuel Rego Casasnovas <[email protected]>
[css3-text] Skip tests that need ENABLE_CSS3_TEXT
Added: trunk/LayoutTests/fast/writing-mode/svg-writing-modes-expected.html (0 => 228822)
--- trunk/LayoutTests/fast/writing-mode/svg-writing-modes-expected.html (rev 0)
+++ trunk/LayoutTests/fast/writing-mode/svg-writing-modes-expected.html 2018-02-20 17:52:34 UTC (rev 228822)
@@ -0,0 +1,6 @@
+<div writing-mode="horizontal-tb">A B C</div>
+<div writing-mode="horizontal-tb">A B C</div>
+<div writing-mode="vertical-rl">A B C</div>
+<div writing-mode="horizontal-tb">A B C</div>
+<div writing-mode="horizontal-tb">A B C</div>
+<div writing-mode="vertical-lr">A B C</div>
Property changes on: trunk/LayoutTests/fast/writing-mode/svg-writing-modes-expected.html
___________________________________________________________________
Added: svn:eol-style
+native
\ No newline at end of property
Added: svn:keywords
+Date Revision
\ No newline at end of property
Added: svn:mime-type
+text/html
\ No newline at end of property
Added: trunk/LayoutTests/fast/writing-mode/svg-writing-modes.html (0 => 228822)
--- trunk/LayoutTests/fast/writing-mode/svg-writing-modes.html (rev 0)
+++ trunk/LayoutTests/fast/writing-mode/svg-writing-modes.html 2018-02-20 17:52:34 UTC (rev 228822)
@@ -0,0 +1,6 @@
+<div writing-mode="lr-tb">A B C</div>
+<div writing-mode="rl-tb">A B C</div>
+<div writing-mode="tb-rl">A B C</div>
+<div writing-mode="lr">A B C</div>
+<div writing-mode="rl">A B C</div>
+<div writing-mode="tb">A B C</div>
Property changes on: trunk/LayoutTests/fast/writing-mode/svg-writing-modes.html
___________________________________________________________________
Added: svn:eol-style
+native
\ No newline at end of property
Added: svn:keywords
+Date Revision
\ No newline at end of property
Added: svn:mime-type
+text/html
\ No newline at end of property
Modified: trunk/Source/WebCore/ChangeLog (228821 => 228822)
--- trunk/Source/WebCore/ChangeLog 2018-02-20 17:03:07 UTC (rev 228821)
+++ trunk/Source/WebCore/ChangeLog 2018-02-20 17:52:34 UTC (rev 228822)
@@ -1,3 +1,19 @@
+2018-02-19 Dean Jackson <[email protected]>
+
+ Handle all writing-modes in downcast
+ https://bugs.webkit.org/show_bug.cgi?id=182949
+ <rdar://problem/37710687>
+
+ Reviewed by Myles Maxfield.
+
+ It appears we forgot to handle the deprecated "lr"
+ writing-mode value.
+
+ Test: fast/writing-mode/svg-writing-modes.html
+
+ * css/CSSPrimitiveValueMappings.h:
+ (WebCore::CSSPrimitiveValue::operator WritingMode const):
+
2018-02-20 Zan Dobersek <[email protected]>
[Cairo] Drop target GraphicsContext usage in Cairo operations
Modified: trunk/Source/WebCore/css/CSSPrimitiveValueMappings.h (228821 => 228822)
--- trunk/Source/WebCore/css/CSSPrimitiveValueMappings.h 2018-02-20 17:03:07 UTC (rev 228821)
+++ trunk/Source/WebCore/css/CSSPrimitiveValueMappings.h 2018-02-20 17:52:34 UTC (rev 228822)
@@ -3201,6 +3201,7 @@
switch (m_value.valueID) {
case CSSValueHorizontalTb:
+ case CSSValueLr:
case CSSValueLrTb:
case CSSValueRl:
case CSSValueRlTb:
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
