Title: [228830] trunk/LayoutTests
Revision
228830
Author
[email protected]
Date
2018-02-20 13:45:27 -0800 (Tue, 20 Feb 2018)

Log Message

Skip tests that need ENABLE_LINK_PREFETCH
https://bugs.webkit.org/show_bug.cgi?id=182981

Unreviewed gardening.

These tests were marked in the different TestExpectations fails of each port,
when actually none of them were testing this code as ENABLE_LINK_PREFETCH is disabled by default
(even in development builds).

The patch just moves the flagged tests from the port specific TestExpectations files
to the generic TestExpectations file skipping them.


* TestExpectations:
* platform/gtk/TestExpectations:
* platform/ios/TestExpectations:
* platform/mac/TestExpectations:
* platform/win/TestExpectations:

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (228829 => 228830)


--- trunk/LayoutTests/ChangeLog	2018-02-20 20:12:09 UTC (rev 228829)
+++ trunk/LayoutTests/ChangeLog	2018-02-20 21:45:27 UTC (rev 228830)
@@ -1,3 +1,23 @@
+2018-02-20  Manuel Rego Casasnovas  <[email protected]>
+
+        Skip tests that need ENABLE_LINK_PREFETCH
+        https://bugs.webkit.org/show_bug.cgi?id=182981
+
+        Unreviewed gardening.
+
+        These tests were marked in the different TestExpectations fails of each port,
+        when actually none of them were testing this code as ENABLE_LINK_PREFETCH is disabled by default
+        (even in development builds).
+
+        The patch just moves the flagged tests from the port specific TestExpectations files
+        to the generic TestExpectations file skipping them.
+
+        * TestExpectations:
+        * platform/gtk/TestExpectations:
+        * platform/ios/TestExpectations:
+        * platform/mac/TestExpectations:
+        * platform/win/TestExpectations:
+
 2018-02-20  John Wilander  <[email protected]>
 
         Make WebResourceLoadStatisticsStore::processStatisticsAndDataRecords() call WebProcessProxy::notifyPageStatisticsAndDataRecordsProcessed() in a proper callback

Modified: trunk/LayoutTests/TestExpectations (228829 => 228830)


--- trunk/LayoutTests/TestExpectations	2018-02-20 20:12:09 UTC (rev 228829)
+++ trunk/LayoutTests/TestExpectations	2018-02-20 21:45:27 UTC (rev 228830)
@@ -1596,6 +1596,18 @@
 webkit.org/b/112755 fast/css3-text/css3-text-indent/text-indent-each-line-hanging.html [ Skip ]
 webkit.org/b/112755 fast/css3-text/css3-text-indent/getComputedStyle [ Skip ]
 
+# Link prefetch is disabled by default (needs ENABLE_LINK_PREFETCH)
+webkit.org/b/3652 fast/dom/HTMLLinkElement/link-and-subresource-test.html [ Skip ]
+webkit.org/b/3652 fast/dom/HTMLLinkElement/link-and-subresource-test-nonexistent.html [ Skip ]
+webkit.org/b/3652 fast/dom/HTMLLinkElement/prefetch.html [ Skip ]
+webkit.org/b/3652 fast/dom/HTMLLinkElement/prefetch-beforeload.html [ Skip ]
+webkit.org/b/3652 fast/dom/HTMLLinkElement/prefetch-onerror.html [ Skip ]
+webkit.org/b/3652 fast/dom/HTMLLinkElement/prefetch-onload.html [ Skip ]
+webkit.org/b/3652 fast/dom/HTMLLinkElement/prefetch-too-many-clients.html [ Skip ]
+webkit.org/b/3652 fast/dom/HTMLLinkElement/subresource.html [ Skip ]
+webkit.org/b/3652 http/tests/misc/link-rel-prefetch-and-subresource.html [ Skip ]
+webkit.org/b/3652 http/tests/misc/prefetch-purpose.html [ Skip ]
+
 ### END OF -disabled tests
 ########################################
 

Modified: trunk/LayoutTests/platform/gtk/TestExpectations (228829 => 228830)


--- trunk/LayoutTests/platform/gtk/TestExpectations	2018-02-20 20:12:09 UTC (rev 228829)
+++ trunk/LayoutTests/platform/gtk/TestExpectations	2018-02-20 21:45:27 UTC (rev 228830)
@@ -1201,16 +1201,6 @@
 webkit.org/b/177633 http/tests/security/clipboard/copy-paste-url-across-origin-sanitizes-url.html [ Failure ]
 webkit.org/b/177633 http/tests/security/clipboard/copy-paste-html-across-origin-strips-mso-list.html [ Failure ]
 
-# We should consider enabling ENABLE_LINK_PREFETCH
-webkit.org/b/179989 http/tests/misc/prefetch-purpose.html [ Skip ]
-webkit.org/b/179989 http/tests/misc/link-rel-prefetch-and-subresource.html [ Skip ]
-webkit.org/b/179989 fast/dom/HTMLLinkElement/subresource.html [ Skip ]
-webkit.org/b/179989 fast/dom/HTMLLinkElement/prefetch-onload.html [ Skip ]
-webkit.org/b/179989 fast/dom/HTMLLinkElement/prefetch-onerror.html [ Skip ]
-webkit.org/b/179989 fast/dom/HTMLLinkElement/prefetch.html [ Skip ]
-webkit.org/b/179989 fast/dom/HTMLLinkElement/link-and-subresource-test-nonexistent.html [ Skip ]
-webkit.org/b/179989 fast/dom/HTMLLinkElement/link-and-subresource-test.html [ Skip ]
-
 webkit.org/b/180062 fast/text/user-installed-fonts [ Skip ]
 
 #////////////////////////////////////////////////////////////////////////////////////////

Modified: trunk/LayoutTests/platform/ios/TestExpectations (228829 => 228830)


--- trunk/LayoutTests/platform/ios/TestExpectations	2018-02-20 20:12:09 UTC (rev 228829)
+++ trunk/LayoutTests/platform/ios/TestExpectations	2018-02-20 21:45:27 UTC (rev 228830)
@@ -1148,8 +1148,6 @@
 http/tests/security/XFrameOptions/x-frame-options-deny-delete-frame-in-load-event.html
 http/tests/local/blob/send-hybrid-blob.html
 http/tests/local/formdata/upload-events.html
-http/tests/misc/link-rel-prefetch-and-subresource.html
-http/tests/misc/prefetch-purpose.html
 http/tests/navigation/scrollstate-after-http-equiv-refresh-fragment-identifier-2.html
 http/tests/navigation/scrollstate-after-http-equiv-refresh-fragment-identifier.html
 http/tests/navigation/scrollstate-after-http-equiv-refresh.html
@@ -2079,12 +2077,6 @@
 fast/dom/DeviceOrientation/no-synchronous-events.html
 fast/dom/DeviceOrientation/null-values.html
 fast/dom/DeviceOrientation/updates.html
-fast/dom/HTMLLinkElement/link-and-subresource-test-nonexistent.html
-fast/dom/HTMLLinkElement/link-and-subresource-test.html
-fast/dom/HTMLLinkElement/prefetch-onerror.html
-fast/dom/HTMLLinkElement/prefetch-onload.html
-fast/dom/HTMLLinkElement/prefetch.link
-fast/dom/HTMLLinkElement/subresource.html
 fast/dom/MutationObserver/inline-event-listener.html
 fast/dom/Window/open-window-min-size.html
 fast/dom/rtl-scroll-to-leftmost-and-resize.html

Modified: trunk/LayoutTests/platform/mac/TestExpectations (228829 => 228830)


--- trunk/LayoutTests/platform/mac/TestExpectations	2018-02-20 20:12:09 UTC (rev 228829)
+++ trunk/LayoutTests/platform/mac/TestExpectations	2018-02-20 21:45:27 UTC (rev 228830)
@@ -123,18 +123,6 @@
 fast/dom/DeviceOrientation
 fast/dom/Window/window-properties-device-orientation.html
 
-# Link prefetch is disabled by default
-fast/dom/HTMLLinkElement/link-and-subresource-test.html
-fast/dom/HTMLLinkElement/link-and-subresource-test-nonexistent.html
-fast/dom/HTMLLinkElement/prefetch.html
-fast/dom/HTMLLinkElement/prefetch-beforeload.html
-fast/dom/HTMLLinkElement/prefetch-onerror.html
-fast/dom/HTMLLinkElement/prefetch-onload.html
-fast/dom/HTMLLinkElement/prefetch-too-many-clients.html
-fast/dom/HTMLLinkElement/subresource.html
-http/tests/misc/link-rel-prefetch-and-subresource.html
-http/tests/misc/prefetch-purpose.html
-
 # Filenames aren't filtered out from edit drags yet, see https://bugs.webkit.org/show_bug.cgi?id=38826
 editing/pasteboard/file-drag-to-editable.html [ Skip ]
 

Modified: trunk/LayoutTests/platform/win/TestExpectations (228829 => 228830)


--- trunk/LayoutTests/platform/win/TestExpectations	2018-02-20 20:12:09 UTC (rev 228829)
+++ trunk/LayoutTests/platform/win/TestExpectations	2018-02-20 21:45:27 UTC (rev 228830)
@@ -275,18 +275,6 @@
 fast/dom/DeviceOrientation/ [ Skip ]
 fast/dom/Window/window-properties-device-orientation.html [ Skip ]
 
-# Link prefetch is disabled by default
-fast/dom/HTMLLinkElement/link-and-subresource-test.html [ Skip ]
-fast/dom/HTMLLinkElement/link-and-subresource-test-nonexistent.html [ Skip ]
-fast/dom/HTMLLinkElement/prefetch.html [ Skip ]
-fast/dom/HTMLLinkElement/prefetch-beforeload.html [ Skip ]
-fast/dom/HTMLLinkElement/prefetch-onerror.html [ Skip ]
-fast/dom/HTMLLinkElement/prefetch-onload.html [ Skip ]
-fast/dom/HTMLLinkElement/prefetch-too-many-clients.html [ Skip ]
-fast/dom/HTMLLinkElement/subresource.html [ Skip ]
-http/tests/misc/link-rel-prefetch-and-subresource.html [ Skip ]
-http/tests/misc/prefetch-purpose.html [ Skip ]
-
 # TODO Hyphenation is not implemented yet.
 webkit.org/b/140234 fast/text/hyphenate-character.html [ Failure ]
 webkit.org/b/140234 fast/text/hyphens.html [ Failure ]
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to