Title: [228834] branches/safari-605-branch/Source/WebCore
- Revision
- 228834
- Author
- [email protected]
- Date
- 2018-02-20 14:29:50 -0800 (Tue, 20 Feb 2018)
Log Message
Cherry-pick r228586. rdar://problem/37697673
Modified Paths
Diff
Modified: branches/safari-605-branch/Source/WebCore/ChangeLog (228833 => 228834)
--- branches/safari-605-branch/Source/WebCore/ChangeLog 2018-02-20 22:29:48 UTC (rev 228833)
+++ branches/safari-605-branch/Source/WebCore/ChangeLog 2018-02-20 22:29:50 UTC (rev 228834)
@@ -1,5 +1,28 @@
2018-02-20 Jason Marcell <[email protected]>
+ Cherry-pick r228586. rdar://problem/37697673
+
+ 2018-02-16 Chris Dumez <[email protected]>
+
+ http/tests/security/http-0.9/xhr-blocked.html is flaky
+ https://bugs.webkit.org/show_bug.cgi?id=182857
+ <rdar://problem/37616958>
+
+ Reviewed by Antti Koivisto.
+
+ WebCoreResourceHandleAsOperationQueueDelegate does not own the messageQueue and
+ the detachHandle function was failing to nullout m_messageQueue when the resourceHandle
+ gets destroyed. This means that callFunctionOnMainThread would sometimes try to append
+ to a dead messageQueue.
+
+ No new tests, already covered by:
+ http/tests/security/http-0.9/xhr-blocked.html is flaky
+
+ * platform/network/mac/WebCoreResourceHandleAsOperationQueueDelegate.mm:
+ (-[WebCoreResourceHandleAsOperationQueueDelegate detachHandle]):
+
+2018-02-20 Jason Marcell <[email protected]>
+
Cherry-pick r228585. rdar://problem/37697677
2018-02-16 Antti Koivisto <[email protected]>
Modified: branches/safari-605-branch/Source/WebCore/platform/network/mac/WebCoreResourceHandleAsOperationQueueDelegate.mm (228833 => 228834)
--- branches/safari-605-branch/Source/WebCore/platform/network/mac/WebCoreResourceHandleAsOperationQueueDelegate.mm 2018-02-20 22:29:48 UTC (rev 228833)
+++ branches/safari-605-branch/Source/WebCore/platform/network/mac/WebCoreResourceHandleAsOperationQueueDelegate.mm 2018-02-20 22:29:50 UTC (rev 228834)
@@ -101,6 +101,7 @@
m_handle = nullptr;
+ m_messageQueue = nullptr;
m_requestResult = nullptr;
m_cachedResponseResult = nullptr;
m_boolResult = NO;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
