Title: [228838] branches/safari-605-branch/Source/WebCore
- Revision
- 228838
- Author
- [email protected]
- Date
- 2018-02-20 14:30:06 -0800 (Tue, 20 Feb 2018)
Log Message
Cherry-pick r228708. rdar://problem/37714034
Modified Paths
Diff
Modified: branches/safari-605-branch/Source/WebCore/ChangeLog (228837 => 228838)
--- branches/safari-605-branch/Source/WebCore/ChangeLog 2018-02-20 22:30:03 UTC (rev 228837)
+++ branches/safari-605-branch/Source/WebCore/ChangeLog 2018-02-20 22:30:06 UTC (rev 228838)
@@ -1,5 +1,28 @@
2018-02-20 Jason Marcell <[email protected]>
+ Cherry-pick r228708. rdar://problem/37714034
+
+ 2018-02-19 Chris Dumez <[email protected]>
+
+ CrashTracer: com.apple.WebKit.WebContent at WebCore: WebCore::TimerBase::~TimerBase
+ https://bugs.webkit.org/show_bug.cgi?id=182931
+ <rdar://problem/37602962>
+
+ Reviewed by Antti Koivisto.
+
+ Make sure PlatformMediaResource is ThreadSafeRefCounted since it is being
+ used from several threads in WebCoreNSURLSession. Also make sure it is
+ always destroyed on the main thread since it ends up destroying a
+ CachedRawResource object.
+
+ No new tests, no known reproduction case.
+
+ * platform/graphics/PlatformMediaResourceLoader.h:
+ * platform/network/cocoa/WebCoreNSURLSession.mm:
+ (-[WebCoreNSURLSessionDataTask dealloc]):
+
+2018-02-20 Jason Marcell <[email protected]>
+
Cherry-pick r228594. rdar://problem/37697671
2018-02-16 Daniel Bates <[email protected]>
Modified: branches/safari-605-branch/Source/WebCore/platform/graphics/PlatformMediaResourceLoader.h (228837 => 228838)
--- branches/safari-605-branch/Source/WebCore/platform/graphics/PlatformMediaResourceLoader.h 2018-02-20 22:30:03 UTC (rev 228837)
+++ branches/safari-605-branch/Source/WebCore/platform/graphics/PlatformMediaResourceLoader.h 2018-02-20 22:30:06 UTC (rev 228838)
@@ -70,7 +70,7 @@
PlatformMediaResourceLoader() = default;
};
-class PlatformMediaResource : public RefCounted<PlatformMediaResource> {
+class PlatformMediaResource : public ThreadSafeRefCounted<PlatformMediaResource> {
WTF_MAKE_NONCOPYABLE(PlatformMediaResource); WTF_MAKE_FAST_ALLOCATED;
public:
PlatformMediaResource() = default;
Modified: branches/safari-605-branch/Source/WebCore/platform/network/cocoa/WebCoreNSURLSession.mm (228837 => 228838)
--- branches/safari-605-branch/Source/WebCore/platform/network/cocoa/WebCoreNSURLSession.mm 2018-02-20 22:30:03 UTC (rev 228837)
+++ branches/safari-605-branch/Source/WebCore/platform/network/cocoa/WebCoreNSURLSession.mm 2018-02-20 22:30:06 UTC (rev 228838)
@@ -539,6 +539,7 @@
[_currentRequest release];
[_error release];
[_taskDescription release];
+ callOnMainThread([resource = WTFMove(_resource)] { });
[super dealloc];
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
