Title: [228890] trunk/Tools
- Revision
- 228890
- Author
- [email protected]
- Date
- 2018-02-21 11:55:40 -0800 (Wed, 21 Feb 2018)
Log Message
[GTK] Unsafe g_setenv use in MiniBrowser main
https://bugs.webkit.org/show_bug.cgi?id=182978
Reviewed by Carlos Garcia Campos.
setenv (and g_setenv) will randomly crash if called too late.
* MiniBrowser/gtk/main.c:
(main):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (228889 => 228890)
--- trunk/Tools/ChangeLog 2018-02-21 19:50:23 UTC (rev 228889)
+++ trunk/Tools/ChangeLog 2018-02-21 19:55:40 UTC (rev 228890)
@@ -1,3 +1,15 @@
+2018-02-21 Michael Catanzaro <[email protected]>
+
+ [GTK] Unsafe g_setenv use in MiniBrowser main
+ https://bugs.webkit.org/show_bug.cgi?id=182978
+
+ Reviewed by Carlos Garcia Campos.
+
+ setenv (and g_setenv) will randomly crash if called too late.
+
+ * MiniBrowser/gtk/main.c:
+ (main):
+
2018-02-21 Aakash Jain <[email protected]>
webkitpy NetworkTransaction should retry on URLError
@@ -166,6 +178,7 @@
* MiniBrowser/gtk/main.c:
(main): Add the group containing the Gstreamer options that the console displays.
+
2018-02-19 Fujii Hironori <[email protected]>
[WTR][GTK] crash log backtrace doesn't show symbol names for DatabaseProcess and NetworkProcess
Modified: trunk/Tools/MiniBrowser/gtk/main.c (228889 => 228890)
--- trunk/Tools/MiniBrowser/gtk/main.c 2018-02-21 19:50:23 UTC (rev 228889)
+++ trunk/Tools/MiniBrowser/gtk/main.c 2018-02-21 19:55:40 UTC (rev 228890)
@@ -477,11 +477,12 @@
int main(int argc, char *argv[])
{
- gtk_init(&argc, &argv);
#if ENABLE_DEVELOPER_MODE
g_setenv("WEBKIT_INJECTED_BUNDLE_PATH", WEBKIT_INJECTED_BUNDLE_PATH, FALSE);
#endif
+ gtk_init(&argc, &argv);
+
GOptionContext *context = g_option_context_new(NULL);
g_option_context_add_main_entries(context, commandLineOptions, 0);
g_option_context_add_group(context, gtk_get_option_group(TRUE));
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
