Title: [228925] trunk/Source/WebKit
Revision
228925
Author
commit-qu...@webkit.org
Date
2018-02-22 10:51:54 -0800 (Thu, 22 Feb 2018)

Log Message

Add release logging for CacheStorage::Engine disk related functions
https://bugs.webkit.org/show_bug.cgi?id=183042

Patch by Youenn Fablet <you...@apple.com> on 2018-02-22
Reviewed by Chris Dumez.

* NetworkProcess/cache/CacheStorageEngine.cpp:
(WebKit::CacheStorage::Engine::writeFile):
(WebKit::CacheStorage::Engine::readFile):

Modified Paths

Diff

Modified: trunk/Source/WebKit/ChangeLog (228924 => 228925)


--- trunk/Source/WebKit/ChangeLog	2018-02-22 18:48:34 UTC (rev 228924)
+++ trunk/Source/WebKit/ChangeLog	2018-02-22 18:51:54 UTC (rev 228925)
@@ -1,3 +1,14 @@
+2018-02-22  Youenn Fablet  <you...@apple.com>
+
+        Add release logging for CacheStorage::Engine disk related functions
+        https://bugs.webkit.org/show_bug.cgi?id=183042
+
+        Reviewed by Chris Dumez.
+
+        * NetworkProcess/cache/CacheStorageEngine.cpp:
+        (WebKit::CacheStorage::Engine::writeFile):
+        (WebKit::CacheStorage::Engine::readFile):
+
 2018-02-22  Matt Lewis  <jlew...@apple.com>
 
         Unreviewed, rolling out r228902.

Modified: trunk/Source/WebKit/NetworkProcess/cache/CacheStorageEngine.cpp (228924 => 228925)


--- trunk/Source/WebKit/NetworkProcess/cache/CacheStorageEngine.cpp	2018-02-22 18:48:34 UTC (rev 228924)
+++ trunk/Source/WebKit/NetworkProcess/cache/CacheStorageEngine.cpp	2018-02-22 18:51:54 UTC (rev 228925)
@@ -26,6 +26,7 @@
 #include "config.h"
 #include "CacheStorageEngine.h"
 
+#include "Logging.h"
 #include "NetworkCacheFileSystem.h"
 #include "NetworkCacheIOChannel.h"
 #include "NetworkProcess.h"
@@ -281,6 +282,8 @@
         channel->write(0, data, nullptr, [callback = WTFMove(callback)](int error) mutable {
             ASSERT(RunLoop::isMain());
             if (error) {
+                RELEASE_LOG_ERROR(CacheStorage, "CacheStorage::Engine::writeFile failed with error %d", error);
+
                 callback(Error::WriteDisk);
                 return;
             }
@@ -306,6 +309,8 @@
         }
 
         channel->read(0, std::numeric_limits<size_t>::max(), nullptr, [callback = WTFMove(callback)](const Data& data, int error) mutable {
+            RELEASE_LOG_ERROR_IF(error, CacheStorage, "CacheStorage::Engine::readFile failed with error %d", error);
+
             // FIXME: We should do the decoding in the background thread.
             ASSERT(RunLoop::isMain());
             callback(data, error);
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to