Title: [228944] trunk/Source/WebCore
- Revision
- 228944
- Author
- ph...@webkit.org
- Date
- 2018-02-23 01:57:37 -0800 (Fri, 23 Feb 2018)
Log Message
[GStreamer] media/video-src-blob-using-open-panel.html crashes in Debug
https://bugs.webkit.org/show_bug.cgi?id=183005
Reviewed by Xabier Rodriguez-Calvar.
Test: media/video-src-blob-using-open-panel.html
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::convertToInternalProtocol): Also convert blob URIs
because they're handled by our httpsrc element.
* platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
(webKitWebSrcGetProtocols): Prefix blob URIs too, for consistency purpose.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (228943 => 228944)
--- trunk/Source/WebCore/ChangeLog 2018-02-23 06:41:50 UTC (rev 228943)
+++ trunk/Source/WebCore/ChangeLog 2018-02-23 09:57:37 UTC (rev 228944)
@@ -1,3 +1,18 @@
+2018-02-23 Philippe Normand <pnorm...@igalia.com>
+
+ [GStreamer] media/video-src-blob-using-open-panel.html crashes in Debug
+ https://bugs.webkit.org/show_bug.cgi?id=183005
+
+ Reviewed by Xabier Rodriguez-Calvar.
+
+ Test: media/video-src-blob-using-open-panel.html
+
+ * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
+ (WebCore::convertToInternalProtocol): Also convert blob URIs
+ because they're handled by our httpsrc element.
+ * platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
+ (webKitWebSrcGetProtocols): Prefix blob URIs too, for consistency purpose.
+
2018-02-22 Yusuke Suzuki <utatane....@gmail.com>
Remove currentTime() / currentTimeMS()
Modified: trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp (228943 => 228944)
--- trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp 2018-02-23 06:41:50 UTC (rev 228943)
+++ trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp 2018-02-23 09:57:37 UTC (rev 228944)
@@ -216,7 +216,7 @@
static void convertToInternalProtocol(URL& url)
{
- if (url.protocolIsInHTTPFamily())
+ if (url.protocolIsInHTTPFamily() || url.protocolIsBlob())
url.setProtocol("webkit+" + url.protocol());
}
Modified: trunk/Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp (228943 => 228944)
--- trunk/Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp 2018-02-23 06:41:50 UTC (rev 228943)
+++ trunk/Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp 2018-02-23 09:57:37 UTC (rev 228944)
@@ -618,7 +618,7 @@
const gchar* const* webKitWebSrcGetProtocols(GType)
{
- static const char* protocols[] = {"webkit+http", "webkit+https", "blob", nullptr };
+ static const char* protocols[] = {"webkit+http", "webkit+https", "webkit+blob", nullptr };
return protocols;
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
