Title: [228985] trunk
Revision
228985
Author
[email protected]
Date
2018-02-26 00:01:12 -0800 (Mon, 26 Feb 2018)

Log Message

[CMake][OpenVR] Linkage errors happen because only OpenVR is compiled with -stdlib=libc++ if Clang is used
https://bugs.webkit.org/show_bug.cgi?id=183116

Patch by Fujii Hironori <[email protected]> on 2018-02-26
Reviewed by Žan Doberšek.

OpenVR has a option USE_LIBCXX to enable/disable that behavior. Let's disable it.

* Source/CMakeLists.txt: Added a option command for USE_LIBCXX to set OFF as default.

Modified Paths

Diff

Modified: trunk/ChangeLog (228984 => 228985)


--- trunk/ChangeLog	2018-02-26 02:50:31 UTC (rev 228984)
+++ trunk/ChangeLog	2018-02-26 08:01:12 UTC (rev 228985)
@@ -1,3 +1,14 @@
+2018-02-26  Fujii Hironori  <[email protected]>
+
+        [CMake][OpenVR] Linkage errors happen because only OpenVR is compiled with -stdlib=libc++ if Clang is used
+        https://bugs.webkit.org/show_bug.cgi?id=183116
+
+        Reviewed by Žan Doberšek.
+
+        OpenVR has a option USE_LIBCXX to enable/disable that behavior. Let's disable it.
+
+        * Source/CMakeLists.txt: Added a option command for USE_LIBCXX to set OFF as default.
+
 2018-02-21  Don Olmstead  <[email protected]>
 
         [CMake] Expose HAVE macros globally

Modified: trunk/Source/CMakeLists.txt (228984 => 228985)


--- trunk/Source/CMakeLists.txt	2018-02-26 02:50:31 UTC (rev 228984)
+++ trunk/Source/CMakeLists.txt	2018-02-26 08:01:12 UTC (rev 228985)
@@ -18,6 +18,9 @@
 endif ()
 
 if (USE_OPENVR)
+    # OpenVR is compiled with -stdlib=libc++ as default if Clang is used.
+    # Disable USE_LIBCXX not to use -stdlib=libc++.
+    option(USE_LIBCXX "Uses libc++ instead of libstdc++" OFF)
     add_subdirectory(ThirdParty/openvr)
 endif ()
 
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to