Title: [228997] releases/WebKitGTK/webkit-2.20
Revision
228997
Author
[email protected]
Date
2018-02-26 02:45:28 -0800 (Mon, 26 Feb 2018)

Log Message

Merge r228822 - Handle all writing-modes in downcast
https://bugs.webkit.org/show_bug.cgi?id=182949
<rdar://problem/37710687>

Reviewed by Myles Maxfield.

Source/WebCore:

It appears we forgot to handle the deprecated "lr"
writing-mode value.

Test: fast/writing-mode/svg-writing-modes.html

* css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::operator WritingMode const):

LayoutTests:

Test all the deprecated SVG writing modes.

* fast/writing-mode/svg-writing-modes-expected.html: Added.
* fast/writing-mode/svg-writing-modes.html: Added.

Modified Paths

Added Paths

Diff

Modified: releases/WebKitGTK/webkit-2.20/LayoutTests/ChangeLog (228996 => 228997)


--- releases/WebKitGTK/webkit-2.20/LayoutTests/ChangeLog	2018-02-26 10:05:45 UTC (rev 228996)
+++ releases/WebKitGTK/webkit-2.20/LayoutTests/ChangeLog	2018-02-26 10:45:28 UTC (rev 228997)
@@ -1,3 +1,16 @@
+2018-02-19  Dean Jackson  <[email protected]>
+
+        Handle all writing-modes in downcast
+        https://bugs.webkit.org/show_bug.cgi?id=182949
+        <rdar://problem/37710687>
+
+        Reviewed by Myles Maxfield.
+
+        Test all the deprecated SVG writing modes.
+
+        * fast/writing-mode/svg-writing-modes-expected.html: Added.
+        * fast/writing-mode/svg-writing-modes.html: Added.
+
 2018-02-19  Fujii Hironori  <[email protected]>
 
         null m_lastNodeInserted dereference at ReplaceSelectionCommand::InsertedNodes::lastLeafInserted

Added: releases/WebKitGTK/webkit-2.20/LayoutTests/fast/writing-mode/svg-writing-modes-expected.html (0 => 228997)


--- releases/WebKitGTK/webkit-2.20/LayoutTests/fast/writing-mode/svg-writing-modes-expected.html	                        (rev 0)
+++ releases/WebKitGTK/webkit-2.20/LayoutTests/fast/writing-mode/svg-writing-modes-expected.html	2018-02-26 10:45:28 UTC (rev 228997)
@@ -0,0 +1,6 @@
+<div writing-mode="horizontal-tb">A B C</div>
+<div writing-mode="horizontal-tb">A B C</div>
+<div writing-mode="vertical-rl">A B C</div>
+<div writing-mode="horizontal-tb">A B C</div>
+<div writing-mode="horizontal-tb">A B C</div>
+<div writing-mode="vertical-lr">A B C</div>

Added: releases/WebKitGTK/webkit-2.20/LayoutTests/fast/writing-mode/svg-writing-modes.html (0 => 228997)


--- releases/WebKitGTK/webkit-2.20/LayoutTests/fast/writing-mode/svg-writing-modes.html	                        (rev 0)
+++ releases/WebKitGTK/webkit-2.20/LayoutTests/fast/writing-mode/svg-writing-modes.html	2018-02-26 10:45:28 UTC (rev 228997)
@@ -0,0 +1,6 @@
+<div writing-mode="lr-tb">A B C</div>
+<div writing-mode="rl-tb">A B C</div>
+<div writing-mode="tb-rl">A B C</div>
+<div writing-mode="lr">A B C</div>
+<div writing-mode="rl">A B C</div>
+<div writing-mode="tb">A B C</div>

Modified: releases/WebKitGTK/webkit-2.20/Source/WebCore/ChangeLog (228996 => 228997)


--- releases/WebKitGTK/webkit-2.20/Source/WebCore/ChangeLog	2018-02-26 10:05:45 UTC (rev 228996)
+++ releases/WebKitGTK/webkit-2.20/Source/WebCore/ChangeLog	2018-02-26 10:45:28 UTC (rev 228997)
@@ -1,3 +1,19 @@
+2018-02-19  Dean Jackson  <[email protected]>
+
+        Handle all writing-modes in downcast
+        https://bugs.webkit.org/show_bug.cgi?id=182949
+        <rdar://problem/37710687>
+
+        Reviewed by Myles Maxfield.
+
+        It appears we forgot to handle the deprecated "lr"
+        writing-mode value.
+
+        Test: fast/writing-mode/svg-writing-modes.html
+
+        * css/CSSPrimitiveValueMappings.h:
+        (WebCore::CSSPrimitiveValue::operator WritingMode const):
+
 2018-02-20  Miguel Gomez  <[email protected]>
 
         [GTK] whatsapp web blurry in some parts, sharp on others

Modified: releases/WebKitGTK/webkit-2.20/Source/WebCore/css/CSSPrimitiveValueMappings.h (228996 => 228997)


--- releases/WebKitGTK/webkit-2.20/Source/WebCore/css/CSSPrimitiveValueMappings.h	2018-02-26 10:05:45 UTC (rev 228996)
+++ releases/WebKitGTK/webkit-2.20/Source/WebCore/css/CSSPrimitiveValueMappings.h	2018-02-26 10:45:28 UTC (rev 228997)
@@ -3201,6 +3201,7 @@
 
     switch (m_value.valueID) {
     case CSSValueHorizontalTb:
+    case CSSValueLr:
     case CSSValueLrTb:
     case CSSValueRl:
     case CSSValueRlTb:
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to