Title: [229010] releases/WebKitGTK/webkit-2.20/Tools
- Revision
- 229010
- Author
- [email protected]
- Date
- 2018-02-26 05:22:11 -0800 (Mon, 26 Feb 2018)
Log Message
Merge r228879 - [ATK] Remove attributeSet variable from AccessibilityUIElement::attributedStringForRange().
https://bugs.webkit.org/show_bug.cgi?id=183000
Reviewed by Joanmarie Diggs.
It is never initialized, but is passed to atk_attribute_set_free.
This caused a crash in accessibility/content-editable-as-textarea.html on the debug bots.
* WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
(WTR::AccessibilityUIElement::attributedStringForRange):
Modified Paths
Diff
Modified: releases/WebKitGTK/webkit-2.20/Tools/ChangeLog (229009 => 229010)
--- releases/WebKitGTK/webkit-2.20/Tools/ChangeLog 2018-02-26 13:22:04 UTC (rev 229009)
+++ releases/WebKitGTK/webkit-2.20/Tools/ChangeLog 2018-02-26 13:22:11 UTC (rev 229010)
@@ -1,3 +1,16 @@
+2018-02-21 Ms2ger <[email protected]>
+
+ [ATK] Remove attributeSet variable from AccessibilityUIElement::attributedStringForRange().
+ https://bugs.webkit.org/show_bug.cgi?id=183000
+
+ Reviewed by Joanmarie Diggs.
+
+ It is never initialized, but is passed to atk_attribute_set_free.
+ This caused a crash in accessibility/content-editable-as-textarea.html on the debug bots.
+
+ * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
+ (WTR::AccessibilityUIElement::attributedStringForRange):
+
2018-02-19 Fujii Hironori <[email protected]>
[WTR][GTK] crash log backtrace doesn't show symbol names for DatabaseProcess and NetworkProcess
Modified: releases/WebKitGTK/webkit-2.20/Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp (229009 => 229010)
--- releases/WebKitGTK/webkit-2.20/Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp 2018-02-26 13:22:04 UTC (rev 229009)
+++ releases/WebKitGTK/webkit-2.20/Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp 2018-02-26 13:22:11 UTC (rev 229010)
@@ -1777,7 +1777,6 @@
builder.append(attributeSetToString(getAttributeSet(m_element.get(), TextAttributeType), "\n\t\t"));
// The attribute run provides attributes specific to the range of text at the specified offset.
- AtkAttributeSet* attributeSet;
AtkText* text = ATK_TEXT(m_element.get());
gint start = 0, end = 0;
for (unsigned i = location; i < location + length; i = end) {
@@ -1787,8 +1786,6 @@
builder.append(attributeSetToString(attributeSet, "\n\t\t"));
}
- atk_attribute_set_free(attributeSet);
-
return JSStringCreateWithUTF8CString(builder.toString().utf8().data());
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
