Title: [229023] releases/WebKitGTK/webkit-2.20/Tools
- Revision
- 229023
- Author
- [email protected]
- Date
- 2018-02-26 08:05:49 -0800 (Mon, 26 Feb 2018)
Log Message
[GTK] Unsafe g_setenv use in MiniBrowser main
https://bugs.webkit.org/show_bug.cgi?id=182978
Reviewed by Carlos Garcia Campos.
setenv (and g_setenv) will randomly crash if called too late.
* MiniBrowser/gtk/main.c:
(main):
Modified Paths
Diff
Modified: releases/WebKitGTK/webkit-2.20/Tools/ChangeLog (229022 => 229023)
--- releases/WebKitGTK/webkit-2.20/Tools/ChangeLog 2018-02-26 14:34:41 UTC (rev 229022)
+++ releases/WebKitGTK/webkit-2.20/Tools/ChangeLog 2018-02-26 16:05:49 UTC (rev 229023)
@@ -1,3 +1,15 @@
+2018-02-21 Michael Catanzaro <[email protected]>
+
+ [GTK] Unsafe g_setenv use in MiniBrowser main
+ https://bugs.webkit.org/show_bug.cgi?id=182978
+
+ Reviewed by Carlos Garcia Campos.
+
+ setenv (and g_setenv) will randomly crash if called too late.
+
+ * MiniBrowser/gtk/main.c:
+ (main):
+
2018-02-21 Ms2ger <[email protected]>
[WTR][WPE] Correct the process names in TestController.
@@ -166,6 +178,7 @@
(-[TestAsyncNavigationDelegate webView:didFinishNavigation:]):
(-[TestAsyncNavigationDelegate webView:didFailNavigation:withError:]):
(-[TestAsyncNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
+
(-[TestAsyncNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
(-[TestAsyncNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
(TestWebKitAPI::TEST):
Modified: releases/WebKitGTK/webkit-2.20/Tools/MiniBrowser/gtk/main.c (229022 => 229023)
--- releases/WebKitGTK/webkit-2.20/Tools/MiniBrowser/gtk/main.c 2018-02-26 14:34:41 UTC (rev 229022)
+++ releases/WebKitGTK/webkit-2.20/Tools/MiniBrowser/gtk/main.c 2018-02-26 16:05:49 UTC (rev 229023)
@@ -476,11 +476,12 @@
int main(int argc, char *argv[])
{
- gtk_init(&argc, &argv);
#if ENABLE_DEVELOPER_MODE
g_setenv("WEBKIT_INJECTED_BUNDLE_PATH", WEBKIT_INJECTED_BUNDLE_PATH, FALSE);
#endif
+ gtk_init(&argc, &argv);
+
GOptionContext *context = g_option_context_new(NULL);
g_option_context_add_main_entries(context, commandLineOptions, 0);
g_option_context_add_group(context, gtk_get_option_group(TRUE));
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
