Title: [229064] trunk/Tools
- Revision
- 229064
- Author
- [email protected]
- Date
- 2018-02-27 09:54:13 -0800 (Tue, 27 Feb 2018)
Log Message
webkitpy Bugzilla transactions should retry on URLError
https://bugs.webkit.org/show_bug.cgi?id=183156
Reviewed by Alexey Proskuryakov.
* Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
(Bugzilla): Use NetworkTransaction.
(Bugzilla._fetch_bug_page_by_url):
(Bugzilla.bug_id_for_attachment_id):
(Bugzilla.get_bug_id_for_attachment_id):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (229063 => 229064)
--- trunk/Tools/ChangeLog 2018-02-27 17:16:31 UTC (rev 229063)
+++ trunk/Tools/ChangeLog 2018-02-27 17:54:13 UTC (rev 229064)
@@ -1,3 +1,16 @@
+2018-02-27 Aakash Jain <[email protected]>
+
+ webkitpy Bugzilla transactions should retry on URLError
+ https://bugs.webkit.org/show_bug.cgi?id=183156
+
+ Reviewed by Alexey Proskuryakov.
+
+ * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
+ (Bugzilla): Use NetworkTransaction.
+ (Bugzilla._fetch_bug_page_by_url):
+ (Bugzilla.bug_id_for_attachment_id):
+ (Bugzilla.get_bug_id_for_attachment_id):
+
2018-02-27 Wenson Hsieh <[email protected]>
[Extra zoom mode] Implement additional SPI for adjusting viewport shrink-to-fit behavior
Modified: trunk/Tools/Scripts/webkitpy/common/net/bugzilla/bugzilla.py (229063 => 229064)
--- trunk/Tools/Scripts/webkitpy/common/net/bugzilla/bugzilla.py 2018-02-27 17:16:31 UTC (rev 229063)
+++ trunk/Tools/Scripts/webkitpy/common/net/bugzilla/bugzilla.py 2018-02-27 17:54:13 UTC (rev 229064)
@@ -46,6 +46,7 @@
from webkitpy.common.config import committers
import webkitpy.common.config.urls as config_urls
from webkitpy.common.net.credentials import Credentials
+from webkitpy.common.net.networktransaction import NetworkTransaction
from webkitpy.common.system.user import User
from webkitpy.thirdparty.BeautifulSoup import BeautifulSoup, BeautifulStoneSoup, SoupStrainer
@@ -468,6 +469,9 @@
def _fetch_bug_page(self, bug_id):
bug_url = self.bug_url_for_bug_id(bug_id, xml=True)
_log.info("Fetching: %s" % bug_url)
+ return NetworkTransaction().run(lambda: self._fetch_bug_page_by_url(bug_url))
+
+ def _fetch_bug_page_by_url(self, bug_url):
return self.browser.open(bug_url)
def fetch_bug_dictionary(self, bug_id):
@@ -501,6 +505,9 @@
return int(match.group('bug_id'))
def bug_id_for_attachment_id(self, attachment_id):
+ return NetworkTransaction().run(lambda: self.get_bug_id_for_attachment_id(attachment_id))
+
+ def get_bug_id_for_attachment_id(self, attachment_id):
self.authenticate()
attachment_url = self.attachment_url_for_id(attachment_id, 'edit')
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
