Title: [229115] trunk/Source/WebKit
Revision
229115
Author
wilan...@apple.com
Date
2018-02-28 16:54:45 -0800 (Wed, 28 Feb 2018)

Log Message

Remove assertion from ResourceLoadStatisticsClassifier::calculateResourcePrevalence() which causes crashes when domains are explicitly set as prevalent without the associated statistics
https://bugs.webkit.org/show_bug.cgi?id=183233

Unreviewed removal of an assertion that's causing layout test crashes.

* Platform/classifier/ResourceLoadStatisticsClassifier.cpp:
(WebKit::ResourceLoadStatisticsClassifier::calculateResourcePrevalence):
    Removed ASSERT(currentPrevalence == Low).

Modified Paths

Diff

Modified: trunk/Source/WebKit/ChangeLog (229114 => 229115)


--- trunk/Source/WebKit/ChangeLog	2018-03-01 00:37:09 UTC (rev 229114)
+++ trunk/Source/WebKit/ChangeLog	2018-03-01 00:54:45 UTC (rev 229115)
@@ -1,5 +1,16 @@
 2018-02-28  John Wilander  <wilan...@apple.com>
 
+        Remove assertion from ResourceLoadStatisticsClassifier::calculateResourcePrevalence() which causes crashes when domains are explicitly set as prevalent without the associated statistics
+        https://bugs.webkit.org/show_bug.cgi?id=183233
+
+        Unreviewed removal of an assertion that's causing layout test crashes.
+
+        * Platform/classifier/ResourceLoadStatisticsClassifier.cpp:
+        (WebKit::ResourceLoadStatisticsClassifier::calculateResourcePrevalence):
+            Removed ASSERT(currentPrevalence == Low).
+
+2018-02-28  John Wilander  <wilan...@apple.com>
+
         Add a second tier of prevalence to facilitate telemetry on very prevalent domains
         https://bugs.webkit.org/show_bug.cgi?id=183218
         <rdar://problem/37992388>

Modified: trunk/Source/WebKit/Platform/classifier/ResourceLoadStatisticsClassifier.cpp (229114 => 229115)


--- trunk/Source/WebKit/Platform/classifier/ResourceLoadStatisticsClassifier.cpp	2018-03-01 00:37:09 UTC (rev 229114)
+++ trunk/Source/WebKit/Platform/classifier/ResourceLoadStatisticsClassifier.cpp	2018-03-01 00:54:45 UTC (rev 229115)
@@ -52,7 +52,6 @@
         && !subresourceUniqueRedirectsToCount
         && !subframeUnderTopFrameOriginsCount
         && !topFrameUniqueRedirectsToCount) {
-        ASSERT(currentPrevalence == Low);
         return Low;
     }
 
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to