Title: [229125] trunk/Source/_javascript_Core
Revision
229125
Author
commit-qu...@webkit.org
Date
2018-02-28 23:35:30 -0800 (Wed, 28 Feb 2018)

Log Message

[ARM] Fix compile error in debug builds by invoking unpoisoned().

Patch by Dominik Infuehr <dinfu...@igalia.com> on 2018-02-28
Reviewed by Mark Lam.

* assembler/MacroAssemblerCodeRef.h:
(JSC::MacroAssemblerCodePtr::MacroAssemblerCodePtr): Fix compile error.
(JSC::MacroAssemblerCodePtr::createFromExecutableAddress()): Ditto.
(JSC::MacroAssemblerCodePtr::dataLocation()): Ditto.
* yarr/YarrInterpreter.cpp:
(JSC::Yarr::ByteCompiler::dumpDisjunction): use %zu for printf'ing size_t.

Modified Paths

Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (229124 => 229125)


--- trunk/Source/_javascript_Core/ChangeLog	2018-03-01 06:47:43 UTC (rev 229124)
+++ trunk/Source/_javascript_Core/ChangeLog	2018-03-01 07:35:30 UTC (rev 229125)
@@ -1,3 +1,16 @@
+2018-02-28  Dominik Infuehr  <dinfu...@igalia.com>
+
+        [ARM] Fix compile error in debug builds by invoking unpoisoned().
+
+        Reviewed by Mark Lam.
+
+        * assembler/MacroAssemblerCodeRef.h:
+        (JSC::MacroAssemblerCodePtr::MacroAssemblerCodePtr): Fix compile error.
+        (JSC::MacroAssemblerCodePtr::createFromExecutableAddress()): Ditto.
+        (JSC::MacroAssemblerCodePtr::dataLocation()): Ditto.
+        * yarr/YarrInterpreter.cpp:
+        (JSC::Yarr::ByteCompiler::dumpDisjunction): use %zu for printf'ing size_t.
+
 2018-02-28  JF Bastien  <jfbast...@apple.com>
 
         GC should sweep code block before deleting

Modified: trunk/Source/_javascript_Core/assembler/MacroAssemblerCodeRef.h (229124 => 229125)


--- trunk/Source/_javascript_Core/assembler/MacroAssemblerCodeRef.h	2018-03-01 06:47:43 UTC (rev 229124)
+++ trunk/Source/_javascript_Core/assembler/MacroAssemblerCodeRef.h	2018-03-01 07:35:30 UTC (rev 229125)
@@ -290,7 +290,7 @@
     {
         m_value.assertIsPoisoned();
         ASSERT(value);
-        ASSERT_VALID_CODE_POINTER(m_value);
+        ASSERT_VALID_CODE_POINTER(m_value.unpoisoned());
     }
     
     static MacroAssemblerCodePtr createFromExecutableAddress(void* value)
@@ -310,7 +310,7 @@
     {
         ASSERT(ra.value());
         m_value.assertIsPoisoned();
-        ASSERT_VALID_CODE_POINTER(m_value);
+        ASSERT_VALID_CODE_POINTER(m_value.unpoisoned());
     }
 
     PoisonedMasmPtr poisonedPtr() const { return m_value; }
@@ -327,7 +327,7 @@
     T dataLocation() const
     {
         m_value.assertIsPoisoned();
-        ASSERT_VALID_CODE_POINTER(m_value);
+        ASSERT_VALID_CODE_POINTER(m_value.unpoisoned());
         return bitwise_cast<T>(m_value ? m_value.unpoisoned<char*>() - 1 : nullptr);
     }
 #else

Modified: trunk/Source/_javascript_Core/yarr/YarrInterpreter.cpp (229124 => 229125)


--- trunk/Source/_javascript_Core/yarr/YarrInterpreter.cpp	2018-03-01 06:47:43 UTC (rev 229124)
+++ trunk/Source/_javascript_Core/yarr/YarrInterpreter.cpp	2018-03-01 07:35:30 UTC (rev 229125)
@@ -2125,7 +2125,7 @@
         auto outputTermIndexAndNest = [&](size_t index, unsigned termNesting) {
             for (unsigned nestingDepth = 0; nestingDepth < termIndexNest; nestingDepth++)
                 out.print("  ");
-            out.printf("%4lu", index);
+            out.printf("%4zu", index);
             for (unsigned nestingDepth = 0; nestingDepth < termNesting; nestingDepth++)
                 out.print("  ");
         };
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to