Title: [229176] trunk/Source/WebCore
Revision
229176
Author
commit-qu...@webkit.org
Date
2018-03-02 09:39:50 -0800 (Fri, 02 Mar 2018)

Log Message

Some RealtimeMediaSource methods do not need to be marked as virtual
https://bugs.webkit.org/show_bug.cgi?id=183272

Patch by Youenn Fablet <you...@apple.com> on 2018-03-02
Reviewed by Eric Carlson.

No change of behavior.

* platform/mediastream/RealtimeMediaSource.h:

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (229175 => 229176)


--- trunk/Source/WebCore/ChangeLog	2018-03-02 17:37:26 UTC (rev 229175)
+++ trunk/Source/WebCore/ChangeLog	2018-03-02 17:39:50 UTC (rev 229176)
@@ -1,3 +1,14 @@
+2018-03-02  Youenn Fablet  <you...@apple.com>
+
+        Some RealtimeMediaSource methods do not need to be marked as virtual
+        https://bugs.webkit.org/show_bug.cgi?id=183272
+
+        Reviewed by Eric Carlson.
+
+        No change of behavior.
+
+        * platform/mediastream/RealtimeMediaSource.h:
+
 2018-03-01  Yusuke Suzuki  <utatane....@gmail.com>
 
         Remove monotonicallyIncreasingTime

Modified: trunk/Source/WebCore/platform/mediastream/RealtimeMediaSource.h (229175 => 229176)


--- trunk/Source/WebCore/platform/mediastream/RealtimeMediaSource.h	2018-03-02 17:37:26 UTC (rev 229175)
+++ trunk/Source/WebCore/platform/mediastream/RealtimeMediaSource.h	2018-03-02 17:39:50 UTC (rev 229176)
@@ -205,8 +205,8 @@
     virtual void applyConstraints(const MediaConstraints&, SuccessHandler&&, FailureHandler&&);
     std::optional<std::pair<String, String>> applyConstraints(const MediaConstraints&);
 
-    virtual bool supportsConstraints(const MediaConstraints&, String&);
-    virtual bool supportsConstraint(const MediaConstraint&) const;
+    bool supportsConstraints(const MediaConstraints&, String&);
+    bool supportsConstraint(const MediaConstraint&) const;
 
     virtual void settingsDidChange();
 
@@ -231,11 +231,12 @@
 
     enum class SelectType { ForApplyConstraints, ForSupportsConstraints };
     bool selectSettings(const MediaConstraints&, FlattenedConstraint&, String&, SelectType);
-    virtual double fitnessDistance(const MediaConstraint&);
-    virtual bool supportsSizeAndFrameRate(std::optional<IntConstraint> width, std::optional<IntConstraint> height, std::optional<DoubleConstraint>, String&, double& fitnessDistance);
+    double fitnessDistance(const MediaConstraint&);
+    void applyConstraint(const MediaConstraint&);
+    void applyConstraints(const FlattenedConstraint&);
+    bool supportsSizeAndFrameRate(std::optional<IntConstraint> width, std::optional<IntConstraint> height, std::optional<DoubleConstraint>, String&, double& fitnessDistance);
+
     virtual bool supportsSizeAndFrameRate(std::optional<int> width, std::optional<int> height, std::optional<double>);
-    virtual void applyConstraint(const MediaConstraint&);
-    virtual void applyConstraints(const FlattenedConstraint&);
     virtual void applySizeAndFrameRate(std::optional<int> width, std::optional<int> height, std::optional<double>);
 
     void notifyMutedObservers() const;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to