Title: [229178] trunk/Source/WebKit
Revision
229178
Author
commit-qu...@webkit.org
Date
2018-03-02 09:48:06 -0800 (Fri, 02 Mar 2018)

Log Message

WebProcessProxy should handle its completion handler at destruction time
https://bugs.webkit.org/show_bug.cgi?id=183224

Patch by Youenn Fablet <you...@apple.com> on 2018-03-02
Reviewed by Brady Eidson.

* UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::~WebProcessProxy):
* UIProcess/WebProcessProxy.h:

Modified Paths

Diff

Modified: trunk/Source/WebKit/ChangeLog (229177 => 229178)


--- trunk/Source/WebKit/ChangeLog	2018-03-02 17:41:07 UTC (rev 229177)
+++ trunk/Source/WebKit/ChangeLog	2018-03-02 17:48:06 UTC (rev 229178)
@@ -1,3 +1,14 @@
+2018-03-02  Youenn Fablet  <you...@apple.com>
+
+        WebProcessProxy should handle its completion handler at destruction time
+        https://bugs.webkit.org/show_bug.cgi?id=183224
+
+        Reviewed by Brady Eidson.
+
+        * UIProcess/WebProcessProxy.cpp:
+        (WebKit::WebProcessProxy::~WebProcessProxy):
+        * UIProcess/WebProcessProxy.h:
+
 2018-03-02  Brent Fulgham  <bfulg...@apple.com>
 
         Update WebContent process sandbox IOKit properties

Modified: trunk/Source/WebKit/UIProcess/WebProcessProxy.cpp (229177 => 229178)


--- trunk/Source/WebKit/UIProcess/WebProcessProxy.cpp	2018-03-02 17:41:07 UTC (rev 229177)
+++ trunk/Source/WebKit/UIProcess/WebProcessProxy.cpp	2018-03-02 17:48:06 UTC (rev 229178)
@@ -146,6 +146,9 @@
 
     while (m_numberOfTimesSuddenTerminationWasDisabled-- > 0)
         WebCore::enableSuddenTermination();
+
+    for (auto& callback : m_localPortActivityCompletionHandlers.values())
+        callback(MessagePortChannelProvider::HasActivity::No);
 }
 
 void WebProcessProxy::getLaunchOptions(ProcessLauncher::LaunchOptions& launchOptions)

Modified: trunk/Source/WebKit/UIProcess/WebProcessProxy.h (229177 => 229178)


--- trunk/Source/WebKit/UIProcess/WebProcessProxy.h	2018-03-02 17:41:07 UTC (rev 229177)
+++ trunk/Source/WebKit/UIProcess/WebProcessProxy.h	2018-03-02 17:48:06 UTC (rev 229178)
@@ -327,7 +327,7 @@
 #endif
 
     HashSet<WebCore::MessagePortIdentifier> m_processEntangledPorts;
-    HashMap<uint64_t, CompletionHandler<void()>> m_messageBatchDeliveryCompletionHandlers;
+    HashMap<uint64_t, Function<void()>> m_messageBatchDeliveryCompletionHandlers;
     HashMap<uint64_t, CompletionHandler<void(WebCore::MessagePortChannelProvider::HasActivity)>> m_localPortActivityCompletionHandlers;
 };
 
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to