Title: [229379] trunk/Tools
Revision
229379
Author
jbed...@apple.com
Date
2018-03-07 16:07:26 -0800 (Wed, 07 Mar 2018)

Log Message

webkitpy: --dedicated-simulators does not boot the correct number of simulators
https://bugs.webkit.org/show_bug.cgi?id=183409
<rdar://problem/38224631>

Reviewed by Aakash Jain.

* Scripts/webkitpy/port/ios_simulator.py:
(IOSSimulatorPort.default_child_processes): When not using dedicated simulators,
we should use the number of booted simulators as our default child processes.

Modified Paths

Diff

Modified: trunk/Tools/ChangeLog (229378 => 229379)


--- trunk/Tools/ChangeLog	2018-03-07 23:22:15 UTC (rev 229378)
+++ trunk/Tools/ChangeLog	2018-03-08 00:07:26 UTC (rev 229379)
@@ -1,3 +1,15 @@
+2018-03-07  Jonathan Bedard  <jbed...@apple.com>
+
+        webkitpy: --dedicated-simulators does not boot the correct number of simulators
+        https://bugs.webkit.org/show_bug.cgi?id=183409
+        <rdar://problem/38224631>
+
+        Reviewed by Aakash Jain.
+
+        * Scripts/webkitpy/port/ios_simulator.py:
+        (IOSSimulatorPort.default_child_processes): When not using dedicated simulators,
+        we should use the number of booted simulators as our default child processes.
+
 2018-03-07  Alejandro G. Castro  <a...@igalia.com>
 
         Make NetworkRTCResolver port agnostic

Modified: trunk/Tools/Scripts/webkitpy/port/ios_simulator.py (229378 => 229379)


--- trunk/Tools/Scripts/webkitpy/port/ios_simulator.py	2018-03-07 23:22:15 UTC (rev 229378)
+++ trunk/Tools/Scripts/webkitpy/port/ios_simulator.py	2018-03-08 00:07:26 UTC (rev 229379)
@@ -73,7 +73,7 @@
             return device.platform_device.device_type in DeviceType(software_variant='iOS',
                                                                     software_version=self.ios_version())
 
-        if self.get_option('dedicated_simulators', False):
+        if not self.get_option('dedicated_simulators', False):
             num_booted_sims = len(SimulatedDeviceManager.device_by_filter(booted_ios_devices_filter, host=self.host))
             if num_booted_sims:
                 return num_booted_sims
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to