Title: [229396] trunk/Source/WebKit
Revision
229396
Author
carlo...@webkit.org
Date
2018-03-07 22:37:41 -0800 (Wed, 07 Mar 2018)

Log Message

REGRESSION(r218089): [GTK] webkit_web_view_get_inspector() needs to be called, otherwise inspector does not close
https://bugs.webkit.org/show_bug.cgi?id=181126

Reviewed by Carlos Alberto Lopez Perez.

Fix the condition to decide whether to detach the inspector view ourselves.

* UIProcess/gtk/WebInspectorProxyGtk.cpp:
(WebKit::WebInspectorProxy::platformDetach): Remove the inspector view from its parent if we don't have a client
or the client didn't detach it.

Modified Paths

Diff

Modified: trunk/Source/WebKit/ChangeLog (229395 => 229396)


--- trunk/Source/WebKit/ChangeLog	2018-03-08 06:34:36 UTC (rev 229395)
+++ trunk/Source/WebKit/ChangeLog	2018-03-08 06:37:41 UTC (rev 229396)
@@ -1,5 +1,18 @@
 2018-03-07  Carlos Garcia Campos  <cgar...@igalia.com>
 
+        REGRESSION(r218089): [GTK] webkit_web_view_get_inspector() needs to be called, otherwise inspector does not close
+        https://bugs.webkit.org/show_bug.cgi?id=181126
+
+        Reviewed by Carlos Alberto Lopez Perez.
+
+        Fix the condition to decide whether to detach the inspector view ourselves.
+
+        * UIProcess/gtk/WebInspectorProxyGtk.cpp:
+        (WebKit::WebInspectorProxy::platformDetach): Remove the inspector view from its parent if we don't have a client
+        or the client didn't detach it.
+
+2018-03-07  Carlos Garcia Campos  <cgar...@igalia.com>
+
         [GTK][WPE] Leak checker is not working in WebKitGLib web process tests
         https://bugs.webkit.org/show_bug.cgi?id=183404
 

Modified: trunk/Source/WebKit/UIProcess/gtk/WebInspectorProxyGtk.cpp (229395 => 229396)


--- trunk/Source/WebKit/UIProcess/gtk/WebInspectorProxyGtk.cpp	2018-03-08 06:34:36 UTC (rev 229395)
+++ trunk/Source/WebKit/UIProcess/gtk/WebInspectorProxyGtk.cpp	2018-03-08 06:37:41 UTC (rev 229396)
@@ -396,7 +396,7 @@
         return;
 
     GRefPtr<GtkWidget> inspectorView = m_inspectorView;
-    if (m_client && !m_client->detach(*this)) {
+    if (!m_client || !m_client->detach(*this)) {
         // Detach is called when m_isAttached is true, but it could called before
         // the inspector is opened if the inspector is shown/closed quickly. So,
         // we might not have a parent yet.
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to