Title: [229399] trunk/Source/WebKit
Revision
229399
Author
wenson_hs...@apple.com
Date
2018-03-08 00:16:10 -0800 (Thu, 08 Mar 2018)

Log Message

[Extra zoom mode] Specify password mode as needed when inputting text
https://bugs.webkit.org/show_bug.cgi?id=183428
<rdar://problem/37609386>

Reviewed by Tim Horton.

If the focused element is a password field, or the input delegate has forced secure text entry, set a flag on
the text input view controller to opt in to password text input mode.

* UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView presentTextInputViewController:]):

Modified Paths

Diff

Modified: trunk/Source/WebKit/ChangeLog (229398 => 229399)


--- trunk/Source/WebKit/ChangeLog	2018-03-08 07:14:42 UTC (rev 229398)
+++ trunk/Source/WebKit/ChangeLog	2018-03-08 08:16:10 UTC (rev 229399)
@@ -1,3 +1,17 @@
+2018-03-08  Wenson Hsieh  <wenson_hs...@apple.com>
+
+        [Extra zoom mode] Specify password mode as needed when inputting text
+        https://bugs.webkit.org/show_bug.cgi?id=183428
+        <rdar://problem/37609386>
+
+        Reviewed by Tim Horton.
+
+        If the focused element is a password field, or the input delegate has forced secure text entry, set a flag on
+        the text input view controller to opt in to password text input mode.
+
+        * UIProcess/ios/WKContentViewInteraction.mm:
+        (-[WKContentView presentTextInputViewController:]):
+
 2018-03-07  Tim Horton  <timothy_hor...@apple.com>
 
         Sort and separate FeatureDefines.xcconfig

Modified: trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm (229398 => 229399)


--- trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm	2018-03-08 07:14:42 UTC (rev 229398)
+++ trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm	2018-03-08 08:16:10 UTC (rev 229399)
@@ -4274,6 +4274,7 @@
 
     _textInputViewController = adoptNS([[WKTextInputViewController alloc] initWithText:_assistedNodeInformation.value textSuggestions:@[ ]]);
     [_textInputViewController setDelegate:self];
+    [_textInputViewController setUsesPasswordEntryMode:_assistedNodeInformation.elementType == InputType::Password || [_formInputSession forceSecureTextEntry]];
     [_focusedFormControlViewController presentViewController:_textInputViewController.get() animated:animated completion:nil];
 
     [_textInputViewController setSuggestions:[_focusedFormControlViewController suggestions]];
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to