Title: [100856] trunk
- Revision
- 100856
- Author
- [email protected]
- Date
- 2011-11-19 07:34:58 -0800 (Sat, 19 Nov 2011)
Log Message
REGRESSION(r98542): Chromium: CSS text is rendered on page
https://bugs.webkit.org/show_bug.cgi?id=71703
Patch by David Barr <[email protected]> on 2011-11-19
Reviewed by Antti Koivisto.
Source/WebCore:
Matched UA declarations uncacheable when using simpleDefaultStyleSheet.
Test: fast/css/style-tag-display-none.html
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::matchUARules):
LayoutTests:
* fast/css/style-tag-display-none-expected.txt: Added.
* fast/css/style-tag-display-none.html: Added.
Modified Paths
Added Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (100855 => 100856)
--- trunk/LayoutTests/ChangeLog 2011-11-19 12:52:54 UTC (rev 100855)
+++ trunk/LayoutTests/ChangeLog 2011-11-19 15:34:58 UTC (rev 100856)
@@ -1,3 +1,13 @@
+2011-11-19 David Barr <[email protected]>
+
+ REGRESSION(r98542): Chromium: CSS text is rendered on page
+ https://bugs.webkit.org/show_bug.cgi?id=71703
+
+ Reviewed by Antti Koivisto.
+
+ * fast/css/style-tag-display-none-expected.txt: Added.
+ * fast/css/style-tag-display-none.html: Added.
+
2011-11-18 Mihnea Ovidenie <[email protected]>
Pixel results missing for fast/regions/render-region-custom-style-mark.html
Added: trunk/LayoutTests/fast/css/style-tag-display-none-expected.txt (0 => 100856)
--- trunk/LayoutTests/fast/css/style-tag-display-none-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/css/style-tag-display-none-expected.txt 2011-11-19 15:34:58 UTC (rev 100856)
@@ -0,0 +1,8 @@
+layer at (0,0) size 800x600
+ RenderView at (0,0) size 800x600
+layer at (0,0) size 800x8
+ RenderBlock {HTML} at (0,0) size 800x8
+ RenderBody {BODY} at (8,8) size 784x0
+ RenderInline {A} at (0,0) size 0x0 [color=#551A8B]
+ RenderText {#text} at (0,0) size 0x0
+ RenderText {#text} at (0,0) size 0x0
Added: trunk/LayoutTests/fast/css/style-tag-display-none.html (0 => 100856)
--- trunk/LayoutTests/fast/css/style-tag-display-none.html (rev 0)
+++ trunk/LayoutTests/fast/css/style-tag-display-none.html 2011-11-19 15:34:58 UTC (rev 100856)
@@ -0,0 +1,17 @@
+<!DOCTYPE HTML>
+<html>
+ <head>
+ <style>
+ .header {
+ overflow: auto;
+ clear: both;
+ }
+ </style>
+ </head>
+<body>
+ <a href=""
+ <script>
+ document.documentElement.setAttribute("dir", "ltr");
+ </script>
+</body>
+</html>
Modified: trunk/Source/WebCore/ChangeLog (100855 => 100856)
--- trunk/Source/WebCore/ChangeLog 2011-11-19 12:52:54 UTC (rev 100855)
+++ trunk/Source/WebCore/ChangeLog 2011-11-19 15:34:58 UTC (rev 100856)
@@ -1,3 +1,17 @@
+2011-11-19 David Barr <[email protected]>
+
+ REGRESSION(r98542): Chromium: CSS text is rendered on page
+ https://bugs.webkit.org/show_bug.cgi?id=71703
+
+ Reviewed by Antti Koivisto.
+
+ Matched UA declarations uncacheable when using simpleDefaultStyleSheet.
+
+ Test: fast/css/style-tag-display-none.html
+
+ * css/CSSStyleSelector.cpp:
+ (WebCore::CSSStyleSelector::matchUARules):
+
2011-11-19 Jay Civelli <[email protected]>
When loading a MHTML document, make sure we set the base URL before
Modified: trunk/Source/WebCore/css/CSSStyleSelector.cpp (100855 => 100856)
--- trunk/Source/WebCore/css/CSSStyleSelector.cpp 2011-11-19 12:52:54 UTC (rev 100855)
+++ trunk/Source/WebCore/css/CSSStyleSelector.cpp 2011-11-19 15:34:58 UTC (rev 100856)
@@ -1135,6 +1135,8 @@
MatchingUARulesScope scope;
// First we match rules from the user agent sheet.
+ if (simpleDefaultStyleSheet)
+ result.isCacheable = false;
RuleSet* userAgentStyleSheet = m_medium->mediaTypeMatchSpecific("print")
? defaultPrintStyle : defaultStyle;
matchRules(userAgentStyleSheet, result.firstUARule, result.lastUARule, false);
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes