Diff
Modified: trunk/LayoutTests/ChangeLog (229530 => 229531)
--- trunk/LayoutTests/ChangeLog 2018-03-12 12:56:14 UTC (rev 229530)
+++ trunk/LayoutTests/ChangeLog 2018-03-12 13:48:01 UTC (rev 229531)
@@ -1,3 +1,22 @@
+2018-03-12 Javier Fernandez <jfernan...@igalia.com>
+
+ Remove GridLayout runtime flag
+ https://bugs.webkit.org/show_bug.cgi?id=183484
+
+ Reviewed by Myles C. Maxfield.
+
+ Since the GridLayout runtime flag is removed and the feature
+ enabled by default, we don't need the tests verifying the
+ codepaths run when the feature is disabled.
+
+ * css3/flexbox/flexbox-lines-must-be-stretched-by-default.html:
+ * css3/flexbox/new-alignment-values-invalid-if-grid-not-enabled-expected.txt: Removed.
+ * css3/flexbox/new-alignment-values-invalid-if-grid-not-enabled.html: Removed.
+ * fast/css-grid-layout/grid-disable-expected.txt: Removed.
+ * fast/css-grid-layout/grid-disable.html: Removed.
+ * fast/css/ensure-flexbox-compatibility-with-initial-values-expected.txt: Removed.
+ * fast/css/ensure-flexbox-compatibility-with-initial-values.html: Removed.
+
2018-03-12 Antoine Quint <grao...@apple.com>
[Web Animations] Implement CSS Animations and CSS Transitions as Web Animations
Modified: trunk/LayoutTests/css3/flexbox/flexbox-lines-must-be-stretched-by-default-expected.txt (229530 => 229531)
--- trunk/LayoutTests/css3/flexbox/flexbox-lines-must-be-stretched-by-default-expected.txt 2018-03-12 12:56:14 UTC (rev 229530)
+++ trunk/LayoutTests/css3/flexbox/flexbox-lines-must-be-stretched-by-default-expected.txt 2018-03-12 13:48:01 UTC (rev 229531)
@@ -1,8 +1,6 @@
-
'Test for BUG=647694 - align-content "stretch" is not applied by default when grid is disabled.'
-PASS .gridDisabled 1
-PASS .gridEnabled 1
+PASS .flex-container 1
Modified: trunk/LayoutTests/css3/flexbox/flexbox-lines-must-be-stretched-by-default.html (229530 => 229531)
--- trunk/LayoutTests/css3/flexbox/flexbox-lines-must-be-stretched-by-default.html 2018-03-12 12:56:14 UTC (rev 229530)
+++ trunk/LayoutTests/css3/flexbox/flexbox-lines-must-be-stretched-by-default.html 2018-03-12 13:48:01 UTC (rev 229531)
@@ -23,16 +23,10 @@
<script src=""
<body>
<script>
-function runTest(gridEnabled)
+function runTest()
{
- if (window.internals)
- internals.settings.setCSSGridLayoutEnabled(gridEnabled);
-
var flexContainer = document.createElement("div");
- if (gridEnabled)
- flexContainer.className += "gridEnabled flex-container";
- else
- flexContainer.className += "gridDisabled flex-container";
+ flexContainer.className += "flex-container";
document.body.appendChild(flexContainer);
var flexItem1 = document.createElement("div");
@@ -52,14 +46,10 @@
flexContainer.style.alignContent = "initial";
- if (gridEnabled)
- checkLayout('.gridEnabled');
- else
- checkLayout('.gridDisabled');
+ checkLayout('.flex-container');
}
-runTest(false);
-runTest(true);
+runTest();
</script>
<p>'Test for BUG=647694 - align-content "stretch" is not applied by default when grid is disabled.'</p>
<div id="log"></div>
Deleted: trunk/LayoutTests/css3/flexbox/new-alignment-values-invalid-if-grid-not-enabled-expected.txt (229530 => 229531)
--- trunk/LayoutTests/css3/flexbox/new-alignment-values-invalid-if-grid-not-enabled-expected.txt 2018-03-12 12:56:14 UTC (rev 229530)
+++ trunk/LayoutTests/css3/flexbox/new-alignment-values-invalid-if-grid-not-enabled-expected.txt 2018-03-12 13:48:01 UTC (rev 229531)
@@ -1,8 +0,0 @@
-Test to verify that the new alignment values are parsed as invalid if Grid Layout is disabled and in any case they do not cause a crash because assertions in flexbox layout code.
-
-
-PASS New Self-Alignment values should be invalid when grid layout is DISABLED.
-PASS New Default-Alignment values should be invalid when grid layout is DISABLED.
-PASS Even when grid layout is ENABLED, new Self-Alignment values should not violate assertions in FlexibleBox layout logic..
-PASS Even when grid layout is ENABLED, new Default-Alignment values should not violate assertions in FlexibleBox layout logic..
-
Deleted: trunk/LayoutTests/css3/flexbox/new-alignment-values-invalid-if-grid-not-enabled.html (229530 => 229531)
--- trunk/LayoutTests/css3/flexbox/new-alignment-values-invalid-if-grid-not-enabled.html 2018-03-12 12:56:14 UTC (rev 229530)
+++ trunk/LayoutTests/css3/flexbox/new-alignment-values-invalid-if-grid-not-enabled.html 2018-03-12 13:48:01 UTC (rev 229531)
@@ -1,89 +0,0 @@
-<!DOCTYPE html>
-<script src=""
-<script src=""
-<script src=""
-<html>
- <body>
- <p>Test to verify that the new alignment values are parsed as invalid if Grid Layout is disabled and in any case they do not cause a crash because assertions in flexbox layout code.</p>
- <div id="log"></div>
-
- <div id="flexContainer" style="display: flex">
- <div id="flexItem"></div>
- </div>
-<script>
-
-var container = document.getElementById("flexContainer");
-var item = document.getElementById("flexItem");
-
-function checkAlignSelfValue(value, computedValue, gridEnabled)
-{
- item.style.webkitAlignSelf = value;
- if (gridEnabled)
- checkValues(item, "alignSelf", "align-self", value, computedValue);
- else
- checkValues(item, "alignSelf", "align-self", "flex-start", "flex-start");
-}
-
-function checkAlignItemsValue(value, computedValue, gridEnabled)
-{
- container.style.webkitAlignItems = value;
- if (gridEnabled) {
- checkValues(container, "alignItems", "align-items", value, computedValue);
- checkValues(item, "alignSelf", "align-self", "auto", "auto");
- } else {
- checkValues(container, "alignItems", "align-items", "flex-end", "flex-end");
- checkValues(item, "alignSelf", "align-self", "auto", "auto");
- }
-}
-
-function checkSelfAlignmentValues(gridEnabled)
-{
- if (window.internals)
- internals.settings.setCSSGridLayoutEnabled(gridEnabled)
-
- item.style.webkitAlignSelf = "flex-start";
-
- checkAlignSelfValue("unsafe start", "unsafe start", gridEnabled)
- checkAlignSelfValue("start", "start", gridEnabled)
- checkAlignSelfValue("end", "end", gridEnabled)
- checkAlignSelfValue("safe flex-start", "safe flex-start", gridEnabled)
- checkAlignSelfValue("self-start", "self-start", gridEnabled)
- checkAlignSelfValue("self-end", "self-end", gridEnabled)
-}
-
-function checkDefaultAlignmentValues(gridEnabled)
-{
- if (window.internals)
- internals.settings.setCSSGridLayoutEnabled(gridEnabled)
-
- container.style.webkitAlignItems = "flex-end";
- item.style.webkitAlignSelf = "auto";
-
- checkAlignItemsValue("unsafe start", "unsafe start", gridEnabled)
- checkAlignItemsValue("start", "start", gridEnabled)
- checkAlignItemsValue("end", "end", gridEnabled)
- checkAlignItemsValue("safe flex-start", "safe flex-start", gridEnabled)
- checkAlignItemsValue("self-start", "self-start", gridEnabled)
- checkAlignItemsValue("self-end", "self-end", gridEnabled)
-}
-
-test(function() {
- checkSelfAlignmentValues(false);
-}, "New Self-Alignment values should be invalid when grid layout is DISABLED.");
-
-test(function() {
- checkDefaultAlignmentValues(false);
-}, "New Default-Alignment values should be invalid when grid layout is DISABLED.");
-
-test(function() {
- checkSelfAlignmentValues(true);
-}, "Even when grid layout is ENABLED, new Self-Alignment values should not violate assertions in FlexibleBox layout logic..");
-
-test(function() {
- checkDefaultAlignmentValues(true);
-}, "Even when grid layout is ENABLED, new Default-Alignment values should not violate assertions in FlexibleBox layout logic..");
-
-</script>
-
-</body>
-</html>
Deleted: trunk/LayoutTests/fast/css/ensure-flexbox-compatibility-with-initial-values-expected.txt (229530 => 229531)
--- trunk/LayoutTests/fast/css/ensure-flexbox-compatibility-with-initial-values-expected.txt 2018-03-12 12:56:14 UTC (rev 229530)
+++ trunk/LayoutTests/fast/css/ensure-flexbox-compatibility-with-initial-values-expected.txt 2018-03-12 13:48:01 UTC (rev 229531)
@@ -1,45 +0,0 @@
-Test to verify initial values of alignment properties are backward-comaptible with flexbox implementation.
-
-On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
-
-
-
-Verifying initial values are supported when grid is ENABLED.
-PASS CSS.supports('align-items', 'normal') is true
-PASS CSS.supports('align-self', 'auto') is true
-PASS CSS.supports('align-content', 'normal') is true
-PASS CSS.supports('justify-content', 'normal') is true
-PASS CSS.supports('align-items', 'normal') is true
-PASS CSS.supports('align-self', 'auto') is true
-PASS CSS.supports('align-content', 'normal') is true
-PASS CSS.supports('justify-content', 'normal') is true
-PASS CSS.supports('align-items', 'normal') is true
-PASS CSS.supports('align-self', 'auto') is true
-PASS CSS.supports('align-content', 'normal') is true
-PASS CSS.supports('justify-content', 'normal') is true
-PASS CSS.supports('align-items', 'normal') is true
-PASS CSS.supports('align-self', 'auto') is true
-PASS CSS.supports('align-content', 'normal') is true
-PASS CSS.supports('justify-content', 'normal') is true
-
-Verifying initial values are supported when grid is DISABLED.
-PASS CSS.supports('align-items', 'stretch') is true
-PASS CSS.supports('align-self', 'auto') is true
-PASS CSS.supports('align-content', 'stretch') is true
-PASS CSS.supports('justify-content', 'flex-start') is true
-PASS CSS.supports('align-items', 'stretch') is true
-PASS CSS.supports('align-self', 'auto') is true
-PASS CSS.supports('align-content', 'stretch') is true
-PASS CSS.supports('justify-content', 'flex-start') is true
-PASS CSS.supports('align-items', 'stretch') is true
-PASS CSS.supports('align-self', 'auto') is true
-PASS CSS.supports('align-content', 'stretch') is true
-PASS CSS.supports('justify-content', 'flex-start') is true
-PASS CSS.supports('align-items', 'stretch') is true
-PASS CSS.supports('align-self', 'auto') is true
-PASS CSS.supports('align-content', 'stretch') is true
-PASS CSS.supports('justify-content', 'flex-start') is true
-PASS successfullyParsed is true
-
-TEST COMPLETE
-
Deleted: trunk/LayoutTests/fast/css/ensure-flexbox-compatibility-with-initial-values.html (229530 => 229531)
--- trunk/LayoutTests/fast/css/ensure-flexbox-compatibility-with-initial-values.html 2018-03-12 12:56:14 UTC (rev 229530)
+++ trunk/LayoutTests/fast/css/ensure-flexbox-compatibility-with-initial-values.html 2018-03-12 13:48:01 UTC (rev 229531)
@@ -1,66 +0,0 @@
-<!DOCTYPE html>
-<script src=""
-<script src=""
-<body>
-<script>
-description('Test to verify initial values of alignment properties are backward-comaptible with flexbox implementation.');
-
-function setInitialValues(element)
-{
- element.style.alignItems = "initial";
- element.style.alignContent = "initial";
- element.style.justifyContent = "initial";
-}
-
-function checkSupportedInitialValues(element)
-{
- checkSupportedValues(element.id, "align-items");
- checkSupportedValues(element.id, "align-self");
- checkSupportedValues(element.id, "align-content");
- checkSupportedValues(element.id, "justify-content");
-}
-
-function checkInitialValues(gridEnabled)
-{
- if (window.internals)
- window.internals.settings.setCSSGridLayoutEnabled(gridEnabled);
-
- var root = document.createElement("div");
- document.body.appendChild(root);
-
- var container = document.createElement("div");
- container.id = "container";
- root.appendChild(container);
- var item = document.createElement("div");
- item.id = "item";
- container.appendChild(item);
-
- var flexContainer = document.createElement("div");
- flexContainer.id = "flexContainer";
- flexContainer.style.display = "flex";
- root.appendChild(flexContainer);
- var flexItem = document.createElement("div");
- flexItem.id = "flexItem";
- flexContainer.appendChild(flexItem);
-
- setInitialValues(root);
- setInitialValues(container);
- setInitialValues(item);
- setInitialValues(flexContainer);
- setInitialValues(flexItem);
-
- checkSupportedInitialValues(container);
- checkSupportedInitialValues(item);
- checkSupportedInitialValues(flexContainer);
- checkSupportedInitialValues(flexItem);
-
- document.body.removeChild(root);
-}
-
-debug('<br>Verifying initial values are supported when grid is ENABLED.');
-checkInitialValues(true);
-
-debug('<br>Verifying initial values are supported when grid is DISABLED.');
-checkInitialValues(false);
-</script>
-</body>
Deleted: trunk/LayoutTests/fast/css-grid-layout/grid-disable-expected.txt (229530 => 229531)
--- trunk/LayoutTests/fast/css-grid-layout/grid-disable-expected.txt 2018-03-12 12:56:14 UTC (rev 229530)
+++ trunk/LayoutTests/fast/css-grid-layout/grid-disable-expected.txt 2018-03-12 13:48:01 UTC (rev 229531)
@@ -1,11 +0,0 @@
-Verifies that CSS Grid Layout does not work if runtime feature is disabled.
-
-On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
-
-
-PASS document.getElementById('grid').style.display is ''
-PASS document.getElementById('inlinegrid').style.display is ''
-PASS successfullyParsed is true
-
-TEST COMPLETE
-
Deleted: trunk/LayoutTests/fast/css-grid-layout/grid-disable.html (229530 => 229531)
--- trunk/LayoutTests/fast/css-grid-layout/grid-disable.html 2018-03-12 12:56:14 UTC (rev 229530)
+++ trunk/LayoutTests/fast/css-grid-layout/grid-disable.html 2018-03-12 13:48:01 UTC (rev 229531)
@@ -1,17 +0,0 @@
-<!DOCTYPE html>
-<script>
-if (window.internals)
- window.internals.settings.setCSSGridLayoutEnabled(false);
-</script>
-
-<div id="grid" style="display: grid"></div>
-<div id="inlinegrid" style="display: inline-grid"></div>
-
-<script src=""
-<script>
-description("Verifies that CSS Grid Layout does not work if runtime feature is disabled.");
-
-shouldBe("document.getElementById('grid').style.display", "''");
-shouldBe("document.getElementById('inlinegrid').style.display", "''");
-</script>
-<script src=""
Modified: trunk/Source/WebCore/ChangeLog (229530 => 229531)
--- trunk/Source/WebCore/ChangeLog 2018-03-12 12:56:14 UTC (rev 229530)
+++ trunk/Source/WebCore/ChangeLog 2018-03-12 13:48:01 UTC (rev 229531)
@@ -1,3 +1,45 @@
+2018-03-12 Javier Fernandez <jfernan...@igalia.com>
+
+ Remove GridLayout runtime flag
+ https://bugs.webkit.org/show_bug.cgi?id=183484
+
+ Reviewed by Myles C. Maxfield.
+
+ The Grid Layout feature has been enabled by default for almost a
+ year, so I think it's time to remove the runtime flag and the
+ codepath run when the feature is disabled.
+
+ No new tests, because there are no changes in functionality.
+
+ * css/CSSComputedStyleDeclaration.cpp:
+ (WebCore::valueForContentPositionAndDistributionWithOverflowAlignment):
+ (WebCore::ComputedStyleExtractor::valueForPropertyinStyle):
+ * css/StyleBuilderConverter.h:
+ (WebCore::StyleBuilderConverter::convertContentAlignmentData):
+ * css/parser/CSSParser.cpp:
+ (WebCore::CSSParserContext::CSSParserContext):
+ (WebCore::operator==):
+ * css/parser/CSSParserFastPaths.cpp:
+ (WebCore::CSSParserFastPaths::isValidKeywordPropertyAndValue):
+ (WebCore::CSSParserFastPaths::isKeywordPropertyID):
+ * css/parser/CSSParserMode.h:
+ (WebCore::CSSParserContextHash::hash):
+ * css/parser/CSSPropertyParser.cpp:
+ (WebCore::CSSPropertyParser::parseSingleValue):
+ * dom/Document.cpp:
+ * dom/Document.h:
+ * page/RuntimeEnabledFeatures.h:
+ * rendering/RenderFlexibleBox.cpp:
+ (WebCore::alignmentOffset):
+ * rendering/style/RenderStyle.cpp:
+ * rendering/style/RenderStyle.h:
+ (WebCore::RenderStyle::initialDefaultAlignment):
+ * testing/InternalSettings.cpp:
+ (WebCore::InternalSettings::Backup::Backup):
+ (WebCore::InternalSettings::Backup::restoreTo):
+ * testing/InternalSettings.h:
+ * testing/InternalSettings.idl:
+
2018-03-12 Antoine Quint <grao...@apple.com>
[Web Animations] Implement CSS Animations and CSS Transitions as Web Animations
Modified: trunk/Source/WebCore/css/CSSComputedStyleDeclaration.cpp (229530 => 229531)
--- trunk/Source/WebCore/css/CSSComputedStyleDeclaration.cpp 2018-03-12 12:56:14 UTC (rev 229530)
+++ trunk/Source/WebCore/css/CSSComputedStyleDeclaration.cpp 2018-03-12 13:48:01 UTC (rev 229531)
@@ -2533,7 +2533,7 @@
return result;
}
-static Ref<CSSValueList> valueForContentPositionAndDistributionWithOverflowAlignment(const StyleContentAlignmentData& data, CSSValueID normalBehaviorValueID)
+static Ref<CSSValueList> valueForContentPositionAndDistributionWithOverflowAlignment(const StyleContentAlignmentData& data)
{
auto& cssValuePool = CSSValuePool::singleton();
auto result = CSSValueList::createSpaceSeparated();
@@ -2541,15 +2541,12 @@
if (data.distribution() != ContentDistributionDefault)
result->append(cssValuePool.createValue(data.distribution()));
- bool gridEnabled = false;
- gridEnabled = RuntimeEnabledFeatures::sharedFeatures().isCSSGridLayoutEnabled();
-
// Handle content-position values (either as fallback or actual value)
switch (data.position()) {
case ContentPositionNormal:
// Handle 'normal' value, not valid as content-distribution fallback.
if (data.distribution() == ContentDistributionDefault)
- result->append(cssValuePool.createIdentifierValue(gridEnabled ? CSSValueNormal : normalBehaviorValueID));
+ result->append(cssValuePool.createIdentifierValue(CSSValueNormal));
break;
case ContentPositionLastBaseline:
result->append(cssValuePool.createIdentifierValue(CSSValueLast));
@@ -2984,7 +2981,7 @@
case CSSPropertyEmptyCells:
return cssValuePool.createValue(style.emptyCells());
case CSSPropertyAlignContent:
- return valueForContentPositionAndDistributionWithOverflowAlignment(style.alignContent(), CSSValueStretch);
+ return valueForContentPositionAndDistributionWithOverflowAlignment(style.alignContent());
case CSSPropertyAlignItems:
return valueForItemPositionWithOverflowAlignment(style.alignItems());
case CSSPropertyAlignSelf:
@@ -3004,7 +3001,7 @@
case CSSPropertyFlexWrap:
return cssValuePool.createValue(style.flexWrap());
case CSSPropertyJustifyContent:
- return valueForContentPositionAndDistributionWithOverflowAlignment(style.justifyContent(), CSSValueFlexStart);
+ return valueForContentPositionAndDistributionWithOverflowAlignment(style.justifyContent());
case CSSPropertyJustifyItems:
return valueForItemPositionWithOverflowAlignment(style.justifyItems());
case CSSPropertyJustifySelf:
Modified: trunk/Source/WebCore/css/StyleBuilderConverter.h (229530 => 229531)
--- trunk/Source/WebCore/css/StyleBuilderConverter.h 2018-03-12 12:56:14 UTC (rev 229530)
+++ trunk/Source/WebCore/css/StyleBuilderConverter.h 2018-03-12 13:48:01 UTC (rev 229531)
@@ -1373,35 +1373,15 @@
inline StyleContentAlignmentData StyleBuilderConverter::convertContentAlignmentData(StyleResolver&, const CSSValue& value)
{
StyleContentAlignmentData alignmentData = RenderStyle::initialContentAlignment();
- if (RuntimeEnabledFeatures::sharedFeatures().isCSSGridLayoutEnabled()) {
- if (!is<CSSContentDistributionValue>(value))
- return alignmentData;
- auto& contentValue = downcast<CSSContentDistributionValue>(value);
- if (contentValue.distribution()->valueID() != CSSValueInvalid)
- alignmentData.setDistribution(contentValue.distribution().get());
- if (contentValue.position()->valueID() != CSSValueInvalid)
- alignmentData.setPosition(contentValue.position().get());
- if (contentValue.overflow()->valueID() != CSSValueInvalid)
- alignmentData.setOverflow(contentValue.overflow().get());
+ if (!is<CSSContentDistributionValue>(value))
return alignmentData;
- }
- if (!is<CSSPrimitiveValue>(value))
- return alignmentData;
- auto& primitiveValue = downcast<CSSPrimitiveValue>(value);
- switch (primitiveValue.valueID()) {
- case CSSValueStretch:
- case CSSValueSpaceBetween:
- case CSSValueSpaceAround:
- alignmentData.setDistribution(primitiveValue);
- break;
- case CSSValueFlexStart:
- case CSSValueFlexEnd:
- case CSSValueCenter:
- alignmentData.setPosition(primitiveValue);
- break;
- default:
- ASSERT_NOT_REACHED();
- }
+ auto& contentValue = downcast<CSSContentDistributionValue>(value);
+ if (contentValue.distribution()->valueID() != CSSValueInvalid)
+ alignmentData.setDistribution(contentValue.distribution().get());
+ if (contentValue.position()->valueID() != CSSValueInvalid)
+ alignmentData.setPosition(contentValue.position().get());
+ if (contentValue.overflow()->valueID() != CSSValueInvalid)
+ alignmentData.setOverflow(contentValue.overflow().get());
return alignmentData;
}
Modified: trunk/Source/WebCore/css/parser/CSSParser.cpp (229530 => 229531)
--- trunk/Source/WebCore/css/parser/CSSParser.cpp 2018-03-12 12:56:14 UTC (rev 229530)
+++ trunk/Source/WebCore/css/parser/CSSParser.cpp 2018-03-12 13:48:01 UTC (rev 229531)
@@ -62,7 +62,6 @@
CSSParserContext::CSSParserContext(CSSParserMode mode, const URL& baseURL)
: baseURL(baseURL)
, mode(mode)
- , cssGridLayoutEnabled(RuntimeEnabledFeatures::sharedFeatures().isCSSGridLayoutEnabled())
{
#if PLATFORM(IOS)
// FIXME: Force the site specific quirk below to work on iOS. Investigating other site specific quirks
@@ -77,7 +76,6 @@
, charset(charset)
, mode(document.inQuirksMode() ? HTMLQuirksMode : HTMLStandardMode)
, isHTMLDocument(document.isHTMLDocument())
- , cssGridLayoutEnabled(document.isCSSGridLayoutEnabled())
, hasDocumentSecurityOrigin(sheetBaseURL.isNull() || document.securityOrigin().canRequest(baseURL))
{
@@ -107,7 +105,6 @@
&& a.charset == b.charset
&& a.mode == b.mode
&& a.isHTMLDocument == b.isHTMLDocument
- && a.cssGridLayoutEnabled == b.cssGridLayoutEnabled
&& a.needsSiteSpecificQuirks == b.needsSiteSpecificQuirks
&& a.enforcesCSSMIMETypeInNoQuirksMode == b.enforcesCSSMIMETypeInNoQuirksMode
&& a.useLegacyBackgroundSizeShorthandBehavior == b.useLegacyBackgroundSizeShorthandBehavior
Modified: trunk/Source/WebCore/css/parser/CSSParserFastPaths.cpp (229530 => 229531)
--- trunk/Source/WebCore/css/parser/CSSParserFastPaths.cpp 2018-03-12 12:56:14 UTC (rev 229530)
+++ trunk/Source/WebCore/css/parser/CSSParserFastPaths.cpp 2018-03-12 13:48:01 UTC (rev 229531)
@@ -568,8 +568,7 @@
// table-column-group | table-column | table-cell | table-caption | -webkit-box | -webkit-inline-box | none
// flex | inline-flex | -webkit-flex | -webkit-inline-flex | grid | inline-grid
return (valueID >= CSSValueInline && valueID <= CSSValueContents) || valueID == CSSValueNone
- || (RuntimeEnabledFeatures::sharedFeatures().isCSSGridLayoutEnabled() && (valueID == CSSValueGrid || valueID == CSSValueInlineGrid))
- ;
+ || valueID == CSSValueGrid || valueID == CSSValueInlineGrid;
case CSSPropertyDominantBaseline:
// auto | use-script | no-change | reset-size | ideographic |
// alphabetic | hanging | mathematical | central | middle |
@@ -707,15 +706,6 @@
return valueID == CSSValueHorizontal || valueID == CSSValueVertical || valueID == CSSValueAuto;
case CSSPropertyWebkitColumnProgression:
return valueID == CSSValueNormal || valueID == CSSValueReverse;
- case CSSPropertyAlignContent:
- // FIXME: Per CSS alignment, this property should accept an optional <overflow-position>. We should share this parsing code with 'justify-self'.
- return valueID == CSSValueFlexStart || valueID == CSSValueFlexEnd || valueID == CSSValueCenter || valueID == CSSValueSpaceBetween || valueID == CSSValueSpaceAround || valueID == CSSValueStretch;
- case CSSPropertyAlignItems:
- // FIXME: Per CSS alignment, this property should accept the same arguments as 'justify-self' so we should share its parsing code.
- return valueID == CSSValueFlexStart || valueID == CSSValueFlexEnd || valueID == CSSValueCenter || valueID == CSSValueBaseline || valueID == CSSValueStretch;
- case CSSPropertyAlignSelf:
- // FIXME: Per CSS alignment, this property should accept the same arguments as 'justify-self' so we should share its parsing code.
- return valueID == CSSValueAuto || valueID == CSSValueFlexStart || valueID == CSSValueFlexEnd || valueID == CSSValueCenter || valueID == CSSValueBaseline || valueID == CSSValueStretch;
case CSSPropertyFlexDirection:
return valueID == CSSValueRow || valueID == CSSValueRowReverse || valueID == CSSValueColumn || valueID == CSSValueColumnReverse;
case CSSPropertyFlexWrap:
@@ -722,9 +712,6 @@
return valueID == CSSValueNowrap || valueID == CSSValueWrap || valueID == CSSValueWrapReverse;
case CSSPropertyWebkitHyphens:
return valueID == CSSValueAuto || valueID == CSSValueNone || valueID == CSSValueManual;
- case CSSPropertyJustifyContent:
- // FIXME: Per CSS alignment, this property should accept an optional <overflow-position>. We should share this parsing code with 'justify-self'.
- return valueID == CSSValueFlexStart || valueID == CSSValueFlexEnd || valueID == CSSValueCenter || valueID == CSSValueSpaceBetween || valueID == CSSValueSpaceAround;
case CSSPropertyWebkitFontKerning:
return valueID == CSSValueAuto || valueID == CSSValueNormal || valueID == CSSValueNone;
case CSSPropertyWebkitFontSmoothing:
@@ -976,11 +963,6 @@
case CSSPropertyFontOpticalSizing:
#endif
return true;
- case CSSPropertyJustifyContent:
- case CSSPropertyAlignContent:
- case CSSPropertyAlignItems:
- case CSSPropertyAlignSelf:
- return !RuntimeEnabledFeatures::sharedFeatures().isCSSGridLayoutEnabled();
default:
return false;
}
Modified: trunk/Source/WebCore/css/parser/CSSParserMode.h (229530 => 229531)
--- trunk/Source/WebCore/css/parser/CSSParserMode.h 2018-03-12 12:56:14 UTC (rev 229530)
+++ trunk/Source/WebCore/css/parser/CSSParserMode.h 2018-03-12 13:48:01 UTC (rev 229531)
@@ -96,7 +96,6 @@
String charset;
CSSParserMode mode { HTMLStandardMode };
bool isHTMLDocument { false };
- bool cssGridLayoutEnabled { false };
#if ENABLE(TEXT_AUTOSIZING)
bool textAutosizingEnabled { false };
#endif
@@ -137,19 +136,18 @@
hash ^= StringHash::hash(key.charset);
unsigned bits = key.isHTMLDocument << 0
& key.isHTMLDocument << 1
- & key.cssGridLayoutEnabled << 2
#if ENABLE(TEXT_AUTOSIZING)
- & key.textAutosizingEnabled << 3
+ & key.textAutosizingEnabled << 2
#endif
- & key.needsSiteSpecificQuirks << 4
- & key.enforcesCSSMIMETypeInNoQuirksMode << 5
- & key.useLegacyBackgroundSizeShorthandBehavior << 6
- & key.springTimingFunctionEnabled << 7
- & key.conicGradientsEnabled << 8
- & key.deferredCSSParserEnabled << 9
- & key.hasDocumentSecurityOrigin << 10
- & key.mode << 11
- & key.allowNewLinesClamp << 12;
+ & key.needsSiteSpecificQuirks << 3
+ & key.enforcesCSSMIMETypeInNoQuirksMode << 4
+ & key.useLegacyBackgroundSizeShorthandBehavior << 5
+ & key.springTimingFunctionEnabled << 6
+ & key.conicGradientsEnabled << 7
+ & key.deferredCSSParserEnabled << 8
+ & key.hasDocumentSecurityOrigin << 9
+ & key.mode << 10
+ & key.allowNewLinesClamp << 11;
hash ^= WTF::intHash(bits);
return hash;
}
Modified: trunk/Source/WebCore/css/parser/CSSPropertyParser.cpp (229530 => 229531)
--- trunk/Source/WebCore/css/parser/CSSPropertyParser.cpp 2018-03-12 12:56:14 UTC (rev 229530)
+++ trunk/Source/WebCore/css/parser/CSSPropertyParser.cpp 2018-03-12 13:48:01 UTC (rev 229531)
@@ -4288,43 +4288,27 @@
case CSSPropertyWebkitMaskRepeatY:
return nullptr;
case CSSPropertyAlignItems:
- if (!m_context.cssGridLayoutEnabled)
- return nullptr;
return consumeAlignItems(m_range);
case CSSPropertyJustifySelf:
return consumeSelfPositionOverflowPosition(m_range, isSelfPositionOrLeftOrRightKeyword);
case CSSPropertyAlignSelf:
- if (!m_context.cssGridLayoutEnabled)
- return nullptr;
return consumeSelfPositionOverflowPosition(m_range, isSelfPositionKeyword);
case CSSPropertyJustifyItems:
- if (!m_context.cssGridLayoutEnabled)
- return nullptr;
return consumeJustifyItems(m_range);
case CSSPropertyGridColumnEnd:
case CSSPropertyGridColumnStart:
case CSSPropertyGridRowEnd:
case CSSPropertyGridRowStart:
- if (!m_context.cssGridLayoutEnabled)
- return nullptr;
return consumeGridLine(m_range);
case CSSPropertyGridAutoColumns:
case CSSPropertyGridAutoRows:
- if (!m_context.cssGridLayoutEnabled)
- return nullptr;
return consumeGridTrackList(m_range, m_context.mode, GridAuto);
case CSSPropertyGridTemplateColumns:
case CSSPropertyGridTemplateRows:
- if (!m_context.cssGridLayoutEnabled)
- return nullptr;
return consumeGridTemplatesRowsOrColumns(m_range, m_context.mode);
case CSSPropertyGridTemplateAreas:
- if (!m_context.cssGridLayoutEnabled)
- return nullptr;
return consumeGridTemplateAreas(m_range);
case CSSPropertyGridAutoFlow:
- if (!m_context.cssGridLayoutEnabled)
- return nullptr;
return consumeGridAutoFlow(m_range);
case CSSPropertyWebkitLineGrid:
return consumeLineGrid(m_range);
Modified: trunk/Source/WebCore/dom/Document.cpp (229530 => 229531)
--- trunk/Source/WebCore/dom/Document.cpp 2018-03-12 12:56:14 UTC (rev 229530)
+++ trunk/Source/WebCore/dom/Document.cpp 2018-03-12 13:48:01 UTC (rev 229531)
@@ -1176,11 +1176,6 @@
return CustomElementNameValidationStatus::Valid;
}
-bool Document::isCSSGridLayoutEnabled() const
-{
- return RuntimeEnabledFeatures::sharedFeatures().isCSSGridLayoutEnabled();
-}
-
ExceptionOr<Ref<Element>> Document::createElementNS(const AtomicString& namespaceURI, const String& qualifiedName)
{
auto parseResult = parseQualifiedName(namespaceURI, qualifiedName);
Modified: trunk/Source/WebCore/dom/Document.h (229530 => 229531)
--- trunk/Source/WebCore/dom/Document.h 2018-03-12 12:56:14 UTC (rev 229530)
+++ trunk/Source/WebCore/dom/Document.h 2018-03-12 13:48:01 UTC (rev 229531)
@@ -424,8 +424,6 @@
static CustomElementNameValidationStatus validateCustomElementName(const AtomicString&);
- bool isCSSGridLayoutEnabled() const;
-
WEBCORE_EXPORT RefPtr<Range> caretRangeFromPoint(int x, int y);
RefPtr<Range> caretRangeFromPoint(const LayoutPoint& clientPoint);
Modified: trunk/Source/WebCore/page/RuntimeEnabledFeatures.h (229530 => 229531)
--- trunk/Source/WebCore/page/RuntimeEnabledFeatures.h 2018-03-12 12:56:14 UTC (rev 229530)
+++ trunk/Source/WebCore/page/RuntimeEnabledFeatures.h 2018-03-12 13:48:01 UTC (rev 229531)
@@ -202,9 +202,6 @@
bool downloadAttributeEnabled() const { return m_isDownloadAttributeEnabled; }
#endif
- void setCSSGridLayoutEnabled(bool isEnabled) { m_cssGridLayoutEnabled = isEnabled; }
- bool isCSSGridLayoutEnabled() const { return m_cssGridLayoutEnabled; }
-
#if ENABLE(INTERSECTION_OBSERVER)
void setIntersectionObserverEnabled(bool isEnabled) { m_intersectionObserverEnabled = isEnabled; }
bool intersectionObserverEnabled() const { return m_intersectionObserverEnabled; }
@@ -353,8 +350,6 @@
bool m_isDownloadAttributeEnabled { false };
#endif
- bool m_cssGridLayoutEnabled { true };
-
#if ENABLE(ENCRYPTED_MEDIA)
bool m_encryptedMediaAPIEnabled { false };
#endif
Modified: trunk/Source/WebCore/rendering/RenderFlexibleBox.cpp (229530 => 229531)
--- trunk/Source/WebCore/rendering/RenderFlexibleBox.cpp 2018-03-12 12:56:14 UTC (rev 229530)
+++ trunk/Source/WebCore/rendering/RenderFlexibleBox.cpp 2018-03-12 13:48:01 UTC (rev 229531)
@@ -1369,10 +1369,8 @@
case ItemPositionEnd:
case ItemPositionLeft:
case ItemPositionRight:
- // FIXME: Implement these. The extended grammar
- // is not enabled by default so we shouldn't hit this codepath.
- // The new grammar is only used when Grid Layout feature is enabled.
- ASSERT(RuntimeEnabledFeatures::sharedFeatures().isCSSGridLayoutEnabled());
+ // FIXME: Implement the extended grammar, enabled when the Grid Layout
+ // feature was enabled by default.
break;
}
return 0;
Modified: trunk/Source/WebCore/rendering/style/RenderStyle.cpp (229530 => 229531)
--- trunk/Source/WebCore/rendering/style/RenderStyle.cpp 2018-03-12 12:56:14 UTC (rev 229530)
+++ trunk/Source/WebCore/rendering/style/RenderStyle.cpp 2018-03-12 13:48:01 UTC (rev 229531)
@@ -235,11 +235,6 @@
return RenderStyle { *this, WTFMove(newStyle) };
}
-bool RenderStyle::isCSSGridLayoutEnabled()
-{
- return RuntimeEnabledFeatures::sharedFeatures().isCSSGridLayoutEnabled();
-}
-
static StyleSelfAlignmentData resolvedSelfAlignment(const StyleSelfAlignmentData& value, ItemPosition normalValueBehavior)
{
if (value.position() == ItemPositionLegacy || value.position() == ItemPositionNormal || value.position() == ItemPositionAuto)
Modified: trunk/Source/WebCore/rendering/style/RenderStyle.h (229530 => 229531)
--- trunk/Source/WebCore/rendering/style/RenderStyle.h 2018-03-12 12:56:14 UTC (rev 229530)
+++ trunk/Source/WebCore/rendering/style/RenderStyle.h 2018-03-12 13:48:01 UTC (rev 229531)
@@ -1495,7 +1495,7 @@
static int initialOrder() { return 0; }
static StyleSelfAlignmentData initialJustifyItems() { return StyleSelfAlignmentData(ItemPositionLegacy, OverflowAlignmentDefault); }
static StyleSelfAlignmentData initialSelfAlignment() { return StyleSelfAlignmentData(ItemPositionAuto, OverflowAlignmentDefault); }
- static StyleSelfAlignmentData initialDefaultAlignment() { return StyleSelfAlignmentData(isCSSGridLayoutEnabled() ? ItemPositionNormal : ItemPositionStretch, OverflowAlignmentDefault); }
+ static StyleSelfAlignmentData initialDefaultAlignment() { return StyleSelfAlignmentData(ItemPositionNormal, OverflowAlignmentDefault); }
static StyleContentAlignmentData initialContentAlignment() { return StyleContentAlignmentData(ContentPositionNormal, ContentDistributionDefault, OverflowAlignmentDefault); }
static EFlexDirection initialFlexDirection() { return FlowRow; }
static EFlexWrap initialFlexWrap() { return FlexNoWrap; }
@@ -1579,8 +1579,6 @@
static TextSizeAdjustment initialTextSizeAdjust() { return TextSizeAdjustment(); }
#endif
- static bool isCSSGridLayoutEnabled();
-
static WillChangeData* initialWillChange() { return nullptr; }
#if ENABLE(TOUCH_EVENTS)
Modified: trunk/Source/WebCore/testing/InternalSettings.cpp (229530 => 229531)
--- trunk/Source/WebCore/testing/InternalSettings.cpp 2018-03-12 12:56:14 UTC (rev 229530)
+++ trunk/Source/WebCore/testing/InternalSettings.cpp 2018-03-12 13:48:01 UTC (rev 229531)
@@ -104,7 +104,6 @@
#if ENABLE(INDEXED_DATABASE_IN_WORKERS)
, m_indexedDBWorkersEnabled(RuntimeEnabledFeatures::sharedFeatures().indexedDBWorkersEnabled())
#endif
- , m_cssGridLayoutEnabled(RuntimeEnabledFeatures::sharedFeatures().isCSSGridLayoutEnabled())
#if ENABLE(WEBGL2)
, m_webGL2Enabled(RuntimeEnabledFeatures::sharedFeatures().webGL2Enabled())
#endif
@@ -205,7 +204,6 @@
#if ENABLE(INDEXED_DATABASE_IN_WORKERS)
RuntimeEnabledFeatures::sharedFeatures().setIndexedDBWorkersEnabled(m_indexedDBWorkersEnabled);
#endif
- RuntimeEnabledFeatures::sharedFeatures().setCSSGridLayoutEnabled(m_cssGridLayoutEnabled);
#if ENABLE(WEBGL2)
RuntimeEnabledFeatures::sharedFeatures().setWebGL2Enabled(m_webGL2Enabled);
#endif
@@ -740,11 +738,6 @@
#endif
}
-void InternalSettings::setCSSGridLayoutEnabled(bool enabled)
-{
- RuntimeEnabledFeatures::sharedFeatures().setCSSGridLayoutEnabled(enabled);
-}
-
void InternalSettings::setWebGL2Enabled(bool enabled)
{
#if ENABLE(WEBGL2)
Modified: trunk/Source/WebCore/testing/InternalSettings.h (229530 => 229531)
--- trunk/Source/WebCore/testing/InternalSettings.h 2018-03-12 12:56:14 UTC (rev 229530)
+++ trunk/Source/WebCore/testing/InternalSettings.h 2018-03-12 13:48:01 UTC (rev 229531)
@@ -119,7 +119,6 @@
// RuntimeEnabledFeatures.
static void setIndexedDBWorkersEnabled(bool);
- static void setCSSGridLayoutEnabled(bool);
static void setWebGL2Enabled(bool);
static void setWebGPUEnabled(bool);
static void setWebVREnabled(bool);
@@ -200,7 +199,6 @@
// Runtime enabled settings.
bool m_indexedDBWorkersEnabled;
- bool m_cssGridLayoutEnabled;
bool m_webGL2Enabled;
bool m_webGPUEnabled;
bool m_webVREnabled;
Modified: trunk/Source/WebCore/testing/InternalSettings.idl (229530 => 229531)
--- trunk/Source/WebCore/testing/InternalSettings.idl 2018-03-12 12:56:14 UTC (rev 229530)
+++ trunk/Source/WebCore/testing/InternalSettings.idl 2018-03-12 13:48:01 UTC (rev 229531)
@@ -88,7 +88,6 @@
// RuntimeEnabledFeatures.
void setIndexedDBWorkersEnabled(boolean enabled);
- void setCSSGridLayoutEnabled(boolean enabled);
void setWebGL2Enabled(boolean enabled);
void setWebGPUEnabled(boolean enabled);
void setWebVREnabled(boolean enabled);
Modified: trunk/Source/WebKit/ChangeLog (229530 => 229531)
--- trunk/Source/WebKit/ChangeLog 2018-03-12 12:56:14 UTC (rev 229530)
+++ trunk/Source/WebKit/ChangeLog 2018-03-12 13:48:01 UTC (rev 229531)
@@ -1,3 +1,18 @@
+2018-03-12 Javier Fernandez <jfernan...@igalia.com>
+
+ Remove GridLayout runtime flag
+ https://bugs.webkit.org/show_bug.cgi?id=183484
+
+ Reviewed by Myles C. Maxfield.
+
+ The Grid Layout feature has been enabled by default for almost a
+ year, so I think it's time to remove the runtime flag and the
+ codepath run when the feature is disabled.
+
+ * Shared/WebPreferences.yaml:
+ * WebProcess/InjectedBundle/InjectedBundle.cpp:
+ (WebKit::InjectedBundle::overrideBoolPreferenceForTestRunner):
+
2018-03-11 Wenson Hsieh <wenson_hs...@apple.com>
Fix the internal iOS build after r229512
Modified: trunk/Source/WebKit/Shared/WebPreferences.yaml (229530 => 229531)
--- trunk/Source/WebKit/Shared/WebPreferences.yaml 2018-03-12 12:56:14 UTC (rev 229530)
+++ trunk/Source/WebKit/Shared/WebPreferences.yaml 2018-03-12 13:48:01 UTC (rev 229531)
@@ -686,14 +686,6 @@
type: bool
defaultValue: false
-CSSGridLayoutEnabled:
- type: bool
- defaultValue: true
- humanReadableName: "CSS Grid"
- humanReadableDescription: "CSS Grid Layout Module support"
- binding: RuntimeEnabledFeatures
- webcoreBinding: RuntimeEnabledFeatures
-
GamepadsEnabled:
type: bool
defaultValue: true
Modified: trunk/Source/WebKit/WebProcess/InjectedBundle/InjectedBundle.cpp (229530 => 229531)
--- trunk/Source/WebKit/WebProcess/InjectedBundle/InjectedBundle.cpp 2018-03-12 12:56:14 UTC (rev 229530)
+++ trunk/Source/WebKit/WebProcess/InjectedBundle/InjectedBundle.cpp 2018-03-12 13:48:01 UTC (rev 229531)
@@ -204,9 +204,6 @@
RuntimeEnabledFeatures::sharedFeatures().setWritableStreamAPIEnabled(enabled);
#endif
- if (preference == "WebKitCSSGridLayoutEnabled")
- RuntimeEnabledFeatures::sharedFeatures().setCSSGridLayoutEnabled(enabled);
-
if (preference == "WebKitInteractiveFormValidationEnabled")
RuntimeEnabledFeatures::sharedFeatures().setInteractiveFormValidationEnabled(enabled);
Modified: trunk/Source/WebKitLegacy/mac/ChangeLog (229530 => 229531)
--- trunk/Source/WebKitLegacy/mac/ChangeLog 2018-03-12 12:56:14 UTC (rev 229530)
+++ trunk/Source/WebKitLegacy/mac/ChangeLog 2018-03-12 13:48:01 UTC (rev 229531)
@@ -1,3 +1,20 @@
+2018-03-12 Javier Fernandez <jfernan...@igalia.com>
+
+ Remove GridLayout runtime flag
+ https://bugs.webkit.org/show_bug.cgi?id=183484
+
+ Reviewed by Myles C. Maxfield.
+
+ The Grid Layout feature has been enabled by default for almost a
+ year, so I think it's time to remove the runtime flag and the
+
+ * WebView/WebPreferenceKeysPrivate.h:
+ * WebView/WebPreferences.mm:
+ (+[WebPreferences initialize]):
+ * WebView/WebPreferencesPrivate.h:
+ * WebView/WebView.mm:
+ (-[WebView _preferencesChanged:]):
+
2018-03-12 Antoine Quint <grao...@apple.com>
[Web Animations] Implement CSS Animations and CSS Transitions as Web Animations
Modified: trunk/Source/WebKitLegacy/mac/WebView/WebPreferenceKeysPrivate.h (229530 => 229531)
--- trunk/Source/WebKitLegacy/mac/WebView/WebPreferenceKeysPrivate.h 2018-03-12 12:56:14 UTC (rev 229530)
+++ trunk/Source/WebKitLegacy/mac/WebView/WebPreferenceKeysPrivate.h 2018-03-12 13:48:01 UTC (rev 229531)
@@ -178,7 +178,6 @@
#define WebKitReadableByteStreamAPIEnabledPreferenceKey @"WebKitReadableByteStreamAPIEnabled"
#define WebKitDownloadAttributeEnabledPreferenceKey @"WebKitDownloadAttributeEnabled"
#define WebKitDirectoryUploadEnabledPreferenceKey @"WebKitDirectoryUploadEnabled"
-#define WebKitCSSGridLayoutEnabledPreferenceKey @"WebKitCSSGridLayoutEnabled"
#define WebKitVisualViewportEnabledPreferenceKey @"WebKitVisualViewportEnabled"
#define WebKitVisualViewportAPIEnabledPreferenceKey @"WebKitVisualViewportAPIEnabled"
#define WebKitModernMediaControlsEnabledPreferenceKey @"WebKitModernMediaControlsEnabled"
Modified: trunk/Source/WebKitLegacy/mac/WebView/WebPreferences.mm (229530 => 229531)
--- trunk/Source/WebKitLegacy/mac/WebView/WebPreferences.mm 2018-03-12 12:56:14 UTC (rev 229530)
+++ trunk/Source/WebKitLegacy/mac/WebView/WebPreferences.mm 2018-03-12 13:48:01 UTC (rev 229531)
@@ -641,7 +641,6 @@
[NSNumber numberWithBool:NO], WebKitDownloadAttributeEnabledPreferenceKey,
#endif
[NSNumber numberWithBool:NO], WebKitDirectoryUploadEnabledPreferenceKey,
- [NSNumber numberWithBool:YES], WebKitCSSGridLayoutEnabledPreferenceKey,
[NSNumber numberWithBool:NO], WebKitWebAnimationsEnabledPreferenceKey,
#if PLATFORM(IOS)
@@ -3058,16 +3057,6 @@
return [self _boolValueForKey:WebKitDirectoryUploadEnabledPreferenceKey];
}
-- (BOOL)isCSSGridLayoutEnabled
-{
- return [self _boolValueForKey:WebKitCSSGridLayoutEnabledPreferenceKey];
-}
-
-- (void)setCSSGridLayoutEnabled:(BOOL)flag
-{
- [self _setBoolValue:flag forKey:WebKitCSSGridLayoutEnabledPreferenceKey];
-}
-
- (BOOL)visualViewportEnabled
{
return [self _boolValueForKey:WebKitVisualViewportEnabledPreferenceKey];
Modified: trunk/Source/WebKitLegacy/mac/WebView/WebPreferencesPrivate.h (229530 => 229531)
--- trunk/Source/WebKitLegacy/mac/WebView/WebPreferencesPrivate.h 2018-03-12 12:56:14 UTC (rev 229530)
+++ trunk/Source/WebKitLegacy/mac/WebView/WebPreferencesPrivate.h 2018-03-12 13:48:01 UTC (rev 229531)
@@ -558,9 +558,6 @@
- (void)setDirectoryUploadEnabled:(BOOL)flag;
- (BOOL)directoryUploadEnabled;
-- (void)setCSSGridLayoutEnabled:(BOOL)flag;
-- (BOOL)isCSSGridLayoutEnabled;
-
- (void)setWebAnimationsEnabled:(BOOL)flag;
- (BOOL)webAnimationsEnabled;
Modified: trunk/Source/WebKitLegacy/mac/WebView/WebView.mm (229530 => 229531)
--- trunk/Source/WebKitLegacy/mac/WebView/WebView.mm 2018-03-12 12:56:14 UTC (rev 229530)
+++ trunk/Source/WebKitLegacy/mac/WebView/WebView.mm 2018-03-12 13:48:01 UTC (rev 229531)
@@ -3027,8 +3027,6 @@
RuntimeEnabledFeatures::sharedFeatures().setDownloadAttributeEnabled([preferences downloadAttributeEnabled]);
#endif
- RuntimeEnabledFeatures::sharedFeatures().setCSSGridLayoutEnabled([preferences isCSSGridLayoutEnabled]);
-
RuntimeEnabledFeatures::sharedFeatures().setWebAnimationsEnabled([preferences webAnimationsEnabled]);
#if ENABLE(INTERSECTION_OBSERVER)
Modified: trunk/Tools/ChangeLog (229530 => 229531)
--- trunk/Tools/ChangeLog 2018-03-12 12:56:14 UTC (rev 229530)
+++ trunk/Tools/ChangeLog 2018-03-12 13:48:01 UTC (rev 229531)
@@ -1,3 +1,17 @@
+2018-03-12 Javier Fernandez <jfernan...@igalia.com>
+
+ Remove GridLayout runtime flag
+ https://bugs.webkit.org/show_bug.cgi?id=183484
+
+ Reviewed by Myles C. Maxfield.
+
+ The Grid Layout feature has been enabled by default for almost a
+ year, so I think it's time to remove the runtime flag and the
+ codepath run when the feature is disabled.
+
+ * DumpRenderTree/mac/DumpRenderTree.mm:
+ (enableExperimentalFeatures):
+
2018-03-12 Antoine Quint <grao...@apple.com>
[Web Animations] Implement CSS Animations and CSS Transitions as Web Animations
Modified: trunk/Tools/DumpRenderTree/mac/DumpRenderTree.mm (229530 => 229531)
--- trunk/Tools/DumpRenderTree/mac/DumpRenderTree.mm 2018-03-12 12:56:14 UTC (rev 229530)
+++ trunk/Tools/DumpRenderTree/mac/DumpRenderTree.mm 2018-03-12 13:48:01 UTC (rev 229531)
@@ -840,7 +840,6 @@
static void enableExperimentalFeatures(WebPreferences* preferences)
{
- [preferences setCSSGridLayoutEnabled:YES];
// FIXME: SpringTimingFunction
[preferences setGamepadsEnabled:YES];
[preferences setLinkPreloadEnabled:YES];
