Title: [229627] trunk/Tools
- Revision
- 229627
- Author
- [email protected]
- Date
- 2018-03-15 10:35:29 -0700 (Thu, 15 Mar 2018)
Log Message
EWS should print the URL in logs on URLError
https://bugs.webkit.org/show_bug.cgi?id=183651
Reviewed by Alexey Proskuryakov.
* Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
(Bugzilla.open_url): Pass the url.
* Scripts/webkitpy/common/net/networktransaction.py:
(NetworkTransaction.run): Accept optional url parameter and print it on URLError.
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (229626 => 229627)
--- trunk/Tools/ChangeLog 2018-03-15 16:58:13 UTC (rev 229626)
+++ trunk/Tools/ChangeLog 2018-03-15 17:35:29 UTC (rev 229627)
@@ -1,3 +1,15 @@
+2018-03-15 Aakash Jain <[email protected]>
+
+ EWS should print the URL in logs on URLError
+ https://bugs.webkit.org/show_bug.cgi?id=183651
+
+ Reviewed by Alexey Proskuryakov.
+
+ * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
+ (Bugzilla.open_url): Pass the url.
+ * Scripts/webkitpy/common/net/networktransaction.py:
+ (NetworkTransaction.run): Accept optional url parameter and print it on URLError.
+
2018-03-15 Zalan Bujtas <[email protected]>
[LayoutReloaded] Introduce Layout namespace
Modified: trunk/Tools/Scripts/webkitpy/common/net/bugzilla/bugzilla.py (229626 => 229627)
--- trunk/Tools/Scripts/webkitpy/common/net/bugzilla/bugzilla.py 2018-03-15 16:58:13 UTC (rev 229626)
+++ trunk/Tools/Scripts/webkitpy/common/net/bugzilla/bugzilla.py 2018-03-15 17:35:29 UTC (rev 229627)
@@ -329,7 +329,7 @@
socket.setdefaulttimeout(value)
def open_url(self, url):
- return NetworkTransaction().run(lambda: self.browser.open(url))
+ return NetworkTransaction().run(lambda: self.browser.open(url), url)
def fetch_user(self, user_id):
self.authenticate()
Modified: trunk/Tools/Scripts/webkitpy/common/net/networktransaction.py (229626 => 229627)
--- trunk/Tools/Scripts/webkitpy/common/net/networktransaction.py 2018-03-15 16:58:13 UTC (rev 229626)
+++ trunk/Tools/Scripts/webkitpy/common/net/networktransaction.py 2018-03-15 17:35:29 UTC (rev 229627)
@@ -45,7 +45,7 @@
self._timeout_seconds = timeout_seconds
self._convert_404_to_None = convert_404_to_None
- def run(self, request):
+ def run(self, request, url=""
self._total_sleep = 0
self._backoff_seconds = self._initial_backoff_seconds
while True:
@@ -59,8 +59,7 @@
self._sleep()
except urllib2.URLError as e:
self._check_for_timeout()
- # FIXME: Log the URL which resulted in URLError.
- _log.warn("Received URLError: {}. Retrying in {} seconds...".format(e.reason, self._backoff_seconds))
+ _log.warn('Received URLError: "{}" while loading {}. Retrying in {} seconds...'.format(e.reason, url, self._backoff_seconds))
self._sleep()
def _check_for_timeout(self):
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
