Title: [229669] trunk/Source/bmalloc
- Revision
- 229669
- Author
- [email protected]
- Date
- 2018-03-16 10:06:03 -0700 (Fri, 16 Mar 2018)
Log Message
Improve error message when Gigacage cannot allocate virtual memory
https://bugs.webkit.org/show_bug.cgi?id=183329
Reviewed by Filip Pizlo.
We've discovered that Deja Dup monitor sets a virtual memory limit, breaking Gigacage. Since
it runs in the background on a fresh out-of-the-box install of Ubuntu, this is not good.
That will have to be fixed by Deja Dup, but there is concern that other applications might
try this, or that users will set a virtual memory limit for the entire desktop session. Of
particular concern is the possibility that users might have copypasted a ulimit line into
a session startup script without understanding it. Let's try to make it slightly easier to
understand what's going wrong.
* bmalloc/Gigacage.cpp:
(Gigacage::ensureGigacage):
Modified Paths
Diff
Modified: trunk/Source/bmalloc/ChangeLog (229668 => 229669)
--- trunk/Source/bmalloc/ChangeLog 2018-03-16 16:35:07 UTC (rev 229668)
+++ trunk/Source/bmalloc/ChangeLog 2018-03-16 17:06:03 UTC (rev 229669)
@@ -1,3 +1,21 @@
+2018-03-16 Michael Catanzaro <[email protected]>
+
+ Improve error message when Gigacage cannot allocate virtual memory
+ https://bugs.webkit.org/show_bug.cgi?id=183329
+
+ Reviewed by Filip Pizlo.
+
+ We've discovered that Deja Dup monitor sets a virtual memory limit, breaking Gigacage. Since
+ it runs in the background on a fresh out-of-the-box install of Ubuntu, this is not good.
+ That will have to be fixed by Deja Dup, but there is concern that other applications might
+ try this, or that users will set a virtual memory limit for the entire desktop session. Of
+ particular concern is the possibility that users might have copypasted a ulimit line into
+ a session startup script without understanding it. Let's try to make it slightly easier to
+ understand what's going wrong.
+
+ * bmalloc/Gigacage.cpp:
+ (Gigacage::ensureGigacage):
+
2018-03-13 Tim Horton <[email protected]>
Add and adopt WK_ALTERNATE_FRAMEWORKS_DIR in WTF and bmalloc
Modified: trunk/Source/bmalloc/bmalloc/Gigacage.cpp (229668 => 229669)
--- trunk/Source/bmalloc/bmalloc/Gigacage.cpp 2018-03-16 16:35:07 UTC (rev 229668)
+++ trunk/Source/bmalloc/bmalloc/Gigacage.cpp 2018-03-16 17:06:03 UTC (rev 229669)
@@ -151,6 +151,7 @@
if (GIGACAGE_ALLOCATION_CAN_FAIL)
return;
fprintf(stderr, "FATAL: Could not allocate gigacage memory with maxAlignment = %lu, totalSize = %lu.\n", maxAlignment, totalSize);
+ fprintf(stderr, "(Make sure you have not set a virtual memory limit.)\n");
BCRASH();
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
