Title: [229810] trunk/Source/_javascript_Core
- Revision
- 229810
- Author
- [email protected]
- Date
- 2018-03-21 10:38:32 -0700 (Wed, 21 Mar 2018)
Log Message
btjs should print the bytecode offset in the stack trace for JS frames
https://bugs.webkit.org/show_bug.cgi?id=183856
Reviewed by Filip Pizlo.
* interpreter/CallFrame.cpp:
(JSC::CallFrame::bytecodeOffset):
(JSC::CallFrame::dump):
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (229809 => 229810)
--- trunk/Source/_javascript_Core/ChangeLog 2018-03-21 17:33:08 UTC (rev 229809)
+++ trunk/Source/_javascript_Core/ChangeLog 2018-03-21 17:38:32 UTC (rev 229810)
@@ -1,3 +1,14 @@
+2018-03-21 Keith Miller <[email protected]>
+
+ btjs should print the bytecode offset in the stack trace for JS frames
+ https://bugs.webkit.org/show_bug.cgi?id=183856
+
+ Reviewed by Filip Pizlo.
+
+ * interpreter/CallFrame.cpp:
+ (JSC::CallFrame::bytecodeOffset):
+ (JSC::CallFrame::dump):
+
2018-03-21 Carlos Garcia Campos <[email protected]>
Unreviewed. Fix GTK and WPE debug build after r229798.
Modified: trunk/Source/_javascript_Core/interpreter/CallFrame.cpp (229809 => 229810)
--- trunk/Source/_javascript_Core/interpreter/CallFrame.cpp 2018-03-21 17:33:08 UTC (rev 229809)
+++ trunk/Source/_javascript_Core/interpreter/CallFrame.cpp 2018-03-21 17:38:32 UTC (rev 229810)
@@ -148,6 +148,7 @@
unsigned CallFrame::bytecodeOffset()
{
+ ASSERT(!callee().isWasm());
if (!codeBlock())
return 0;
#if ENABLE(DFG_JIT)
@@ -329,7 +330,7 @@
void CallFrame::dump(PrintStream& out)
{
if (CodeBlock* codeBlock = this->codeBlock()) {
- out.print(codeBlock->inferredName(), "#", codeBlock->hashAsStringIfPossible(), " [", codeBlock->jitType(), "]");
+ out.print(codeBlock->inferredName(), "#", codeBlock->hashAsStringIfPossible(), " [", codeBlock->jitType(), " bc#", bytecodeOffset(), "]");
out.print("(");
thisValue().dumpForBacktrace(out);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
