Title: [229812] trunk/Source/WebCore
Revision
229812
Author
[email protected]
Date
2018-03-21 10:52:44 -0700 (Wed, 21 Mar 2018)

Log Message

Compile error when not using IOSurface canvas backing store.
https://bugs.webkit.org/show_bug.cgi?id=183855

Reviewed by Brent Fulgham.

The method IOSurface::createFromImageBuffer is only referenced when IOSurface
is used as canvas backing store.

* platform/graphics/cocoa/IOSurface.h:
* platform/graphics/cocoa/IOSurface.mm:

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (229811 => 229812)


--- trunk/Source/WebCore/ChangeLog	2018-03-21 17:48:57 UTC (rev 229811)
+++ trunk/Source/WebCore/ChangeLog	2018-03-21 17:52:44 UTC (rev 229812)
@@ -1,3 +1,16 @@
+2018-03-21  Per Arne Vollan  <[email protected]>
+
+        Compile error when not using IOSurface canvas backing store.
+        https://bugs.webkit.org/show_bug.cgi?id=183855
+
+        Reviewed by Brent Fulgham.
+
+        The method IOSurface::createFromImageBuffer is only referenced when IOSurface
+        is used as canvas backing store.
+
+        * platform/graphics/cocoa/IOSurface.h:
+        * platform/graphics/cocoa/IOSurface.mm:
+
 2018-03-21  Zan Dobersek  <[email protected]>
 
         [CoordGraphics] Track dirty rects that need update in CoordinatedGraphicsLayer

Modified: trunk/Source/WebCore/platform/graphics/cocoa/IOSurface.h (229811 => 229812)


--- trunk/Source/WebCore/platform/graphics/cocoa/IOSurface.h	2018-03-21 17:48:57 UTC (rev 229811)
+++ trunk/Source/WebCore/platform/graphics/cocoa/IOSurface.h	2018-03-21 17:52:44 UTC (rev 229812)
@@ -88,7 +88,9 @@
     static std::unique_ptr<IOSurface> createFromSurface(IOSurfaceRef, CGColorSpaceRef);
     WEBCORE_EXPORT static std::unique_ptr<IOSurface> createFromImage(CGImageRef);
     
+#if USE(IOSURFACE_CANVAS_BACKING_STORE)
     static std::unique_ptr<IOSurface> createFromImageBuffer(std::unique_ptr<ImageBuffer>);
+#endif
 
     WEBCORE_EXPORT static void moveToPool(std::unique_ptr<IOSurface>&&);
 

Modified: trunk/Source/WebCore/platform/graphics/cocoa/IOSurface.mm (229811 => 229812)


--- trunk/Source/WebCore/platform/graphics/cocoa/IOSurface.mm	2018-03-21 17:48:57 UTC (rev 229811)
+++ trunk/Source/WebCore/platform/graphics/cocoa/IOSurface.mm	2018-03-21 17:52:44 UTC (rev 229812)
@@ -107,10 +107,12 @@
     IOSurfacePool::sharedPool().addSurface(WTFMove(surface));
 }
 
+#if USE(IOSURFACE_CANVAS_BACKING_STORE)
 std::unique_ptr<IOSurface> IOSurface::createFromImageBuffer(std::unique_ptr<ImageBuffer> imageBuffer)
 {
     return WTFMove(imageBuffer->m_data.surface);
 }
+#endif
 
 static NSDictionary *optionsForBiplanarSurface(IntSize size, unsigned pixelFormat, size_t firstPlaneBytesPerPixel, size_t secondPlaneBytesPerPixel)
 {
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to