Title: [229992] trunk/Source/WebCore
Revision
229992
Author
ms2...@igalia.com
Date
2018-03-26 23:59:12 -0700 (Mon, 26 Mar 2018)

Log Message

Remove an unnecessary const_cast from BitmapTextureGL::updateContents().
https://bugs.webkit.org/show_bug.cgi?id=184007

Reviewed by Žan Doberšek.

No new tests.

* platform/graphics/texmap/BitmapTextureGL.cpp:
(WebCore::BitmapTextureGL::updateContents):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (229991 => 229992)


--- trunk/Source/WebCore/ChangeLog	2018-03-27 04:07:40 UTC (rev 229991)
+++ trunk/Source/WebCore/ChangeLog	2018-03-27 06:59:12 UTC (rev 229992)
@@ -1,3 +1,15 @@
+2018-03-26  Ms2ger  <ms2...@igalia.com>
+
+        Remove an unnecessary const_cast from BitmapTextureGL::updateContents().
+        https://bugs.webkit.org/show_bug.cgi?id=184007
+
+        Reviewed by Žan Doberšek.
+
+        No new tests.
+
+        * platform/graphics/texmap/BitmapTextureGL.cpp:
+        (WebCore::BitmapTextureGL::updateContents):
+
 2018-03-23  Antoine Quint  <grao...@apple.com>
 
         [Web Animations] Make imported/mozilla/css-animations/test_animation-currenttime.html pass reliably

Modified: trunk/Source/WebCore/platform/graphics/texmap/BitmapTextureGL.cpp (229991 => 229992)


--- trunk/Source/WebCore/platform/graphics/texmap/BitmapTextureGL.cpp	2018-03-27 04:07:40 UTC (rev 229991)
+++ trunk/Source/WebCore/platform/graphics/texmap/BitmapTextureGL.cpp	2018-03-27 06:59:12 UTC (rev 229992)
@@ -97,7 +97,7 @@
     glBindTexture(GL_TEXTURE_2D, m_id);
 
     const unsigned bytesPerPixel = 4;
-    char* data = ""
+    const char* data = "" char*>(srcData);
     Vector<char> temporaryData;
     IntPoint adjustedSourceOffset = sourceOffset;
 
@@ -108,10 +108,10 @@
     // prepare temporaryData if necessary
     if (requireSubImageBuffer) {
         temporaryData.resize(targetRect.width() * targetRect.height() * bytesPerPixel);
-        data = ""
+        char* dst = temporaryData.data();
+        data = ""
         const char* bits = static_cast<const char*>(srcData);
         const char* src = "" + sourceOffset.y() * bytesPerLine + sourceOffset.x() * bytesPerPixel;
-        char* dst = data;
         const int targetBytesPerLine = targetRect.width() * bytesPerPixel;
         for (int y = 0; y < targetRect.height(); ++y) {
             memcpy(dst, src, targetBytesPerLine);
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to