Title: [230029] trunk/Source/WebKit
Revision
230029
Author
[email protected]
Date
2018-03-28 07:39:01 -0700 (Wed, 28 Mar 2018)

Log Message

Revert an unnecessary workaround when zooming focused form controls
https://bugs.webkit.org/show_bug.cgi?id=184067
<rdar://problem/38805254>

Reviewed by Tim Horton.

Reverts an unintended change introduced in r227984.

* UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView _displayFormNodeInputView]):

Modified Paths

Diff

Modified: trunk/Source/WebKit/ChangeLog (230028 => 230029)


--- trunk/Source/WebKit/ChangeLog	2018-03-28 12:30:10 UTC (rev 230028)
+++ trunk/Source/WebKit/ChangeLog	2018-03-28 14:39:01 UTC (rev 230029)
@@ -1,3 +1,16 @@
+2018-03-28  Wenson Hsieh  <[email protected]>
+
+        Revert an unnecessary workaround when zooming focused form controls
+        https://bugs.webkit.org/show_bug.cgi?id=184067
+        <rdar://problem/38805254>
+
+        Reviewed by Tim Horton.
+
+        Reverts an unintended change introduced in r227984.
+
+        * UIProcess/ios/WKContentViewInteraction.mm:
+        (-[WKContentView _displayFormNodeInputView]):
+
 2018-03-28  Miguel Gomez  <[email protected]>
 
         [GTK][WPE] Remove UpdateAtlas

Modified: trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm (230028 => 230029)


--- trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm	2018-03-28 12:30:10 UTC (rev 230028)
+++ trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm	2018-03-28 14:39:01 UTC (rev 230029)
@@ -1261,7 +1261,7 @@
         fontSize:_assistedNodeInformation.nodeFontSize
         minimumScale:_assistedNodeInformation.minimumScaleFactor
         maximumScale:_assistedNodeInformation.maximumScaleFactorIgnoringAlwaysScalable
-        allowScaling:_assistedNodeInformation.allowsUserScalingIgnoringAlwaysScalable && [[UIDevice currentDevice] userInterfaceIdiom] == UIUserInterfaceIdiomPhone
+        allowScaling:_assistedNodeInformation.allowsUserScalingIgnoringAlwaysScalable && !currentUserInterfaceIdiomIsPad()
         forceScroll:[self requiresAccessoryView]];
 
     _didAccessoryTabInitiateFocus = NO;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to