Title: [230060] trunk/Tools
- Revision
- 230060
- Author
- [email protected]
- Date
- 2018-03-28 16:46:29 -0700 (Wed, 28 Mar 2018)
Log Message
Unreviewed, disable new window.open() API tests introduced in r230051 on iOS.
I will investigate if this is testable on iOS.
* TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (230059 => 230060)
--- trunk/Tools/ChangeLog 2018-03-28 23:16:50 UTC (rev 230059)
+++ trunk/Tools/ChangeLog 2018-03-28 23:46:29 UTC (rev 230060)
@@ -1,5 +1,13 @@
2018-03-28 Chris Dumez <[email protected]>
+ Unreviewed, disable new window.open() API tests introduced in r230051 on iOS.
+
+ I will investigate if this is testable on iOS.
+
+ * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
+
+2018-03-28 Chris Dumez <[email protected]>
+
Do process swap when opening a cross-origin URL via window.open(url, '_blank', 'noopener')
https://bugs.webkit.org/show_bug.cgi?id=183962
<rdar://problem/38817833>
Modified: trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm (230059 => 230060)
--- trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm 2018-03-28 23:16:50 UTC (rev 230059)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm 2018-03-28 23:46:29 UTC (rev 230060)
@@ -314,6 +314,8 @@
EXPECT_FALSE(pid1 == pid3);
}
+#if PLATFORM(MAC)
+
TEST(ProcessSwap, CrossOriginWindowOpenNoOpener)
{
auto processPoolConfiguration = adoptNS([[_WKProcessPoolConfiguration alloc] init]);
@@ -397,7 +399,7 @@
EXPECT_EQ(pid1, pid2);
}
-TEST(ProcessSwap, SamOriginWindowOpenNoOpener)
+TEST(ProcessSwap, SameOriginWindowOpenNoOpener)
{
auto processPoolConfiguration = adoptNS([[_WKProcessPoolConfiguration alloc] init]);
processPoolConfiguration.get().processSwapsOnNavigation = YES;
@@ -436,4 +438,6 @@
EXPECT_EQ(pid1, pid2);
}
+#endif // PLATFORM(MAC)
+
#endif // WK_API_ENABLED
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
