Title: [230116] trunk/Source/WTF
- Revision
- 230116
- Author
- [email protected]
- Date
- 2018-03-30 13:46:58 -0700 (Fri, 30 Mar 2018)
Log Message
WorkQueueWin: don't move rvalues
https://bugs.webkit.org/show_bug.cgi?id=184190
<rdar://problem/39049850>
Reviewed by Mark Lam.
As part of #184167 optional is now more frequently an rvalue
reference, and moving its .value() is not a thing that should be
done anymore.
* wtf/win/WorkQueueWin.cpp:
(WTF::WorkQueue::unregisterAndCloseHandle):
Modified Paths
Diff
Modified: trunk/Source/WTF/ChangeLog (230115 => 230116)
--- trunk/Source/WTF/ChangeLog 2018-03-30 20:31:00 UTC (rev 230115)
+++ trunk/Source/WTF/ChangeLog 2018-03-30 20:46:58 UTC (rev 230116)
@@ -1,5 +1,20 @@
2018-03-30 JF Bastien <[email protected]>
+ WorkQueueWin: don't move rvalues
+ https://bugs.webkit.org/show_bug.cgi?id=184190
+ <rdar://problem/39049850>
+
+ Reviewed by Mark Lam.
+
+ As part of #184167 optional is now more frequently an rvalue
+ reference, and moving its .value() is not a thing that should be
+ done anymore.
+
+ * wtf/win/WorkQueueWin.cpp:
+ (WTF::WorkQueue::unregisterAndCloseHandle):
+
+2018-03-30 JF Bastien <[email protected]>
+
Remove CXX_REFERENCE_QUALIFIED_FUNCTIONS and optional's equivalent
https://bugs.webkit.org/show_bug.cgi?id=184167
<rdar://problem/39023130>
Modified: trunk/Source/WTF/wtf/win/WorkQueueWin.cpp (230115 => 230116)
--- trunk/Source/WTF/wtf/win/WorkQueueWin.cpp 2018-03-30 20:31:00 UTC (rev 230115)
+++ trunk/Source/WTF/wtf/win/WorkQueueWin.cpp 2018-03-30 20:46:58 UTC (rev 230116)
@@ -1,5 +1,5 @@
/*
- * Copyright (C) 2010, 2015 Apple Inc. All rights reserved.
+ * Copyright (C) 2010-2018 Apple Inc. All rights reserved.
* Copyright (C) 2017 Sony Interactive Entertainment Inc.
*
* Redistribution and use in source and binary forms, with or without
@@ -64,7 +64,7 @@
auto locker = holdLock(m_itemsMapLock);
ASSERT_ARG(handle, m_itemsMap.contains(handle));
- unregisterWaitAndDestroyItemSoon(WTFMove(m_itemsMap.take(handle).value()));
+ unregisterWaitAndDestroyItemSoon(m_itemsMap.take(handle).value());
}
DWORD WorkQueue::workThreadCallback(void* context)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
