Title: [230180] tags/Safari-606.1.7.4/Source/WebCore
Revision
230180
Author
[email protected]
Date
2018-04-02 14:05:53 -0700 (Mon, 02 Apr 2018)

Log Message

Cherry-pick r229430. rdar://problem/38210306

    Ensure system appearance is default for legacy webkit
    https://bugs.webkit.org/show_bug.cgi?id=183473
    <rdar://problem/38210306>

    Reviewed by Tim Horton.

    Need to set the appearance on the window for legacy webkit due to differences in drawing.

    Not currently testable, will add tests in a later patch.

    * platform/mac/ThemeMac.mm:
    (WebCore::paintButton):

    git-svn-id: https://svn.webkit.org/repository/webkit/trunk@229430 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

Diff

Modified: tags/Safari-606.1.7.4/Source/WebCore/ChangeLog (230179 => 230180)


--- tags/Safari-606.1.7.4/Source/WebCore/ChangeLog	2018-04-02 21:05:51 UTC (rev 230179)
+++ tags/Safari-606.1.7.4/Source/WebCore/ChangeLog	2018-04-02 21:05:53 UTC (rev 230180)
@@ -1,5 +1,41 @@
 2018-04-02  Jason Marcell  <[email protected]>
 
+        Cherry-pick r229430. rdar://problem/38210306
+
+    Ensure system appearance is default for legacy webkit
+    https://bugs.webkit.org/show_bug.cgi?id=183473
+    <rdar://problem/38210306>
+    
+    Reviewed by Tim Horton.
+    
+    Need to set the appearance on the window for legacy webkit due to differences in drawing.
+    
+    Not currently testable, will add tests in a later patch.
+    
+    * platform/mac/ThemeMac.mm:
+    (WebCore::paintButton):
+    
+    
+    
+    git-svn-id: https://svn.webkit.org/repository/webkit/trunk@229430 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+    2018-03-08  Megan Gardner  <[email protected]>
+
+            Ensure system appearance is default for legacy webkit
+            https://bugs.webkit.org/show_bug.cgi?id=183473
+            <rdar://problem/38210306>
+
+            Reviewed by Tim Horton.
+
+            Need to set the appearance on the window for legacy webkit due to differences in drawing.
+
+            Not currently testable, will add tests in a later patch.
+
+            * platform/mac/ThemeMac.mm:
+            (WebCore::paintButton):
+
+2018-04-02  Jason Marcell  <[email protected]>
+
         Cherry-pick r229336. rdar://problem/36975571
 
     Ensure system appearance is default for web content

Modified: tags/Safari-606.1.7.4/Source/WebCore/platform/mac/ThemeMac.mm (230179 => 230180)


--- tags/Safari-606.1.7.4/Source/WebCore/platform/mac/ThemeMac.mm	2018-04-02 21:05:51 UTC (rev 230179)
+++ tags/Safari-606.1.7.4/Source/WebCore/platform/mac/ThemeMac.mm	2018-04-02 21:05:53 UTC (rev 230180)
@@ -565,6 +565,8 @@
     
     NSView *view = ThemeMac::ensuredView(scrollView, controlStates);
     NSWindow *window = [view window];
+    LocalDefaultSystemAppearance localAppearence;
+    [window setAppearance:[NSAppearance currentAppearance]];
     NSButtonCell *previousDefaultButtonCell = [window defaultButtonCell];
 
     bool useImageBuffer = pageScaleFactor != 1.0f || zoomFactor != 1.0f;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to