Title: [230229] trunk/Source/WebCore
Revision
230229
Author
ross.kirsl...@sony.com
Date
2018-04-03 17:56:07 -0700 (Tue, 03 Apr 2018)

Log Message

Add missing WEBCORE_EXPORTs (for Windows shared library build)
https://bugs.webkit.org/show_bug.cgi?id=184279

Reviewed by Alex Christensen.

* dom/Element.h:
* dom/Node.h:
* editing/FrameSelection.h:
* html/DOMURL.h:
* html/HTMLFormElement.h:
* html/canvas/CanvasRenderingContext.h:
* platform/graphics/GraphicsContext.h:
* platform/graphics/PlatformDisplay.h:
* platform/graphics/cairo/CairoOperations.h:
* platform/graphics/cairo/GraphicsContextImplCairo.h:
* platform/graphics/texmap/TextureMapperLayer.h:
* platform/network/HTTPHeaderMap.h:
* platform/network/ResourceRequestBase.h:
* platform/network/ResourceResponseBase.h:
* platform/network/curl/AuthenticationChallenge.h:
* platform/network/curl/CurlFormDataStream.h:
* platform/network/curl/CurlRequest.h:
* platform/network/curl/CurlSSLHandle.h:
* platform/network/curl/ResourceError.h:
* platform/network/curl/ResourceResponse.h:

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (230228 => 230229)


--- trunk/Source/WebCore/ChangeLog	2018-04-04 00:46:50 UTC (rev 230228)
+++ trunk/Source/WebCore/ChangeLog	2018-04-04 00:56:07 UTC (rev 230229)
@@ -1,3 +1,31 @@
+2018-04-03  Ross Kirsling  <ross.kirsl...@sony.com>
+
+        Add missing WEBCORE_EXPORTs (for Windows shared library build)
+        https://bugs.webkit.org/show_bug.cgi?id=184279
+
+        Reviewed by Alex Christensen.
+
+        * dom/Element.h:
+        * dom/Node.h:
+        * editing/FrameSelection.h:
+        * html/DOMURL.h:
+        * html/HTMLFormElement.h:
+        * html/canvas/CanvasRenderingContext.h:
+        * platform/graphics/GraphicsContext.h:
+        * platform/graphics/PlatformDisplay.h:
+        * platform/graphics/cairo/CairoOperations.h:
+        * platform/graphics/cairo/GraphicsContextImplCairo.h:
+        * platform/graphics/texmap/TextureMapperLayer.h:
+        * platform/network/HTTPHeaderMap.h:
+        * platform/network/ResourceRequestBase.h:
+        * platform/network/ResourceResponseBase.h:
+        * platform/network/curl/AuthenticationChallenge.h:
+        * platform/network/curl/CurlFormDataStream.h:
+        * platform/network/curl/CurlRequest.h:
+        * platform/network/curl/CurlSSLHandle.h:
+        * platform/network/curl/ResourceError.h:
+        * platform/network/curl/ResourceResponse.h:
+
 2018-04-03  Youenn Fablet  <you...@apple.com>
 
         RealtimeOutgoingVideoSourceMac should pass a ObjCFrameBuffer buffer

Modified: trunk/Source/WebCore/dom/Element.h (230228 => 230229)


--- trunk/Source/WebCore/dom/Element.h	2018-04-04 00:46:50 UTC (rev 230228)
+++ trunk/Source/WebCore/dom/Element.h	2018-04-04 00:56:07 UTC (rev 230229)
@@ -360,7 +360,7 @@
     void setStyleIsAffectedByPreviousSibling() { setFlag(StyleIsAffectedByPreviousSibling); }
     void setChildIndex(unsigned);
 
-    AtomicString computeInheritedLanguage() const;
+    WEBCORE_EXPORT AtomicString computeInheritedLanguage() const;
     Locale& locale() const;
 
     virtual void accessKeyAction(bool /*sendToAnyEvent*/) { }

Modified: trunk/Source/WebCore/dom/Node.h (230228 => 230229)


--- trunk/Source/WebCore/dom/Node.h	2018-04-04 00:46:50 UTC (rev 230228)
+++ trunk/Source/WebCore/dom/Node.h	2018-04-04 00:56:07 UTC (rev 230229)
@@ -509,7 +509,7 @@
 
     bool dispatchBeforeLoadEvent(const String& sourceURL);
 
-    void dispatchInputEvent();
+    WEBCORE_EXPORT void dispatchInputEvent();
 
     // Perform the default action for an event.
     virtual void defaultEventHandler(Event&);

Modified: trunk/Source/WebCore/editing/FrameSelection.h (230228 => 230229)


--- trunk/Source/WebCore/editing/FrameSelection.h	2018-04-04 00:46:50 UTC (rev 230228)
+++ trunk/Source/WebCore/editing/FrameSelection.h	2018-04-04 00:56:07 UTC (rev 230229)
@@ -168,8 +168,8 @@
     void setStart(const VisiblePosition &, EUserTriggered = NotUserTriggered);
     void setEnd(const VisiblePosition &, EUserTriggered = NotUserTriggered);
     
-    void setBase(const VisiblePosition&, EUserTriggered = NotUserTriggered);
-    void setBase(const Position&, EAffinity, EUserTriggered = NotUserTriggered);
+    WEBCORE_EXPORT void setBase(const VisiblePosition&, EUserTriggered = NotUserTriggered);
+    WEBCORE_EXPORT void setBase(const Position&, EAffinity, EUserTriggered = NotUserTriggered);
     void setExtent(const VisiblePosition&, EUserTriggered = NotUserTriggered);
     void setExtent(const Position&, EAffinity, EUserTriggered = NotUserTriggered);
 
@@ -323,7 +323,7 @@
     void updateAppearanceAfterLayoutOrStyleChange();
     void appearanceUpdateTimerFired();
 
-    void setCaretVisibility(CaretVisibility);
+    WEBCORE_EXPORT void setCaretVisibility(CaretVisibility);
     bool recomputeCaretRect();
     void invalidateCaretRect();
 

Modified: trunk/Source/WebCore/html/DOMURL.h (230228 => 230229)


--- trunk/Source/WebCore/html/DOMURL.h	2018-04-04 00:46:50 UTC (rev 230228)
+++ trunk/Source/WebCore/html/DOMURL.h	2018-04-04 00:56:07 UTC (rev 230229)
@@ -37,7 +37,7 @@
 class URLRegistrable;
 class URLSearchParams;
 
-class DOMURL : public RefCounted<DOMURL>, public URLUtils<DOMURL> {
+class WEBCORE_EXPORT DOMURL : public RefCounted<DOMURL>, public URLUtils<DOMURL> {
 public:
     static ExceptionOr<Ref<DOMURL>> create(const String& url, const String& base);
     static ExceptionOr<Ref<DOMURL>> create(const String& url, const DOMURL& base);

Modified: trunk/Source/WebCore/html/HTMLFormElement.h (230228 => 230229)


--- trunk/Source/WebCore/html/HTMLFormElement.h	2018-04-04 00:46:50 UTC (rev 230228)
+++ trunk/Source/WebCore/html/HTMLFormElement.h	2018-04-04 00:56:07 UTC (rev 230229)
@@ -96,8 +96,8 @@
     String acceptCharset() const { return m_attributes.acceptCharset(); }
     void setAcceptCharset(const String&);
 
-    String action() const;
-    void setAction(const String&);
+    WEBCORE_EXPORT String action() const;
+    WEBCORE_EXPORT void setAction(const String&);
 
     WEBCORE_EXPORT String method() const;
     WEBCORE_EXPORT void setMethod(const String&);

Modified: trunk/Source/WebCore/html/canvas/CanvasRenderingContext.h (230228 => 230229)


--- trunk/Source/WebCore/html/canvas/CanvasRenderingContext.h	2018-04-04 00:46:50 UTC (rev 230228)
+++ trunk/Source/WebCore/html/canvas/CanvasRenderingContext.h	2018-04-04 00:56:07 UTC (rev 230229)
@@ -47,7 +47,7 @@
     virtual ~CanvasRenderingContext() = default;
 
     void ref();
-    void deref();
+    WEBCORE_EXPORT void deref();
 
     CanvasBase& canvasBase() const { return m_canvas; }
 

Modified: trunk/Source/WebCore/platform/graphics/GraphicsContext.h (230228 => 230229)


--- trunk/Source/WebCore/platform/graphics/GraphicsContext.h	2018-04-04 00:46:50 UTC (rev 230228)
+++ trunk/Source/WebCore/platform/graphics/GraphicsContext.h	2018-04-04 00:56:07 UTC (rev 230229)
@@ -265,7 +265,7 @@
     };
     GraphicsContext(NonPaintingReasons);
 
-    bool hasPlatformContext() const;
+    WEBCORE_EXPORT bool hasPlatformContext() const;
     WEBCORE_EXPORT PlatformGraphicsContext* platformContext() const;
 
     bool paintingDisabled() const { return !m_data && !m_impl; }

Modified: trunk/Source/WebCore/platform/graphics/PlatformDisplay.h (230228 => 230229)


--- trunk/Source/WebCore/platform/graphics/PlatformDisplay.h	2018-04-04 00:46:50 UTC (rev 230228)
+++ trunk/Source/WebCore/platform/graphics/PlatformDisplay.h	2018-04-04 00:56:07 UTC (rev 230229)
@@ -40,7 +40,7 @@
 class PlatformDisplay {
     WTF_MAKE_NONCOPYABLE(PlatformDisplay); WTF_MAKE_FAST_ALLOCATED;
 public:
-    static PlatformDisplay& sharedDisplay();
+    WEBCORE_EXPORT static PlatformDisplay& sharedDisplay();
     WEBCORE_EXPORT static PlatformDisplay& sharedDisplayForCompositing();
     virtual ~PlatformDisplay();
 
@@ -62,7 +62,7 @@
     virtual Type type() const = 0;
 
 #if USE(EGL) || USE(GLX)
-    GLContext* sharingGLContext();
+    WEBCORE_EXPORT GLContext* sharingGLContext();
 #endif
 
 #if USE(EGL)

Modified: trunk/Source/WebCore/platform/graphics/cairo/CairoOperations.h (230228 => 230229)


--- trunk/Source/WebCore/platform/graphics/cairo/CairoOperations.h	2018-04-04 00:46:50 UTC (rev 230228)
+++ trunk/Source/WebCore/platform/graphics/cairo/CairoOperations.h	2018-04-04 00:56:07 UTC (rev 230229)
@@ -140,7 +140,7 @@
 
 void drawNativeImage(PlatformContextCairo&, cairo_surface_t*, const FloatRect&, const FloatRect&, CompositeOperator, BlendMode, ImageOrientation, InterpolationQuality, float, const ShadowState&);
 void drawPattern(PlatformContextCairo&, cairo_surface_t*, const IntSize&, const FloatRect&, const FloatRect&, const AffineTransform&, const FloatPoint&, CompositeOperator, BlendMode);
-void drawSurface(PlatformContextCairo&, cairo_surface_t*, const FloatRect&, const FloatRect&, InterpolationQuality, float, const ShadowState&);
+WEBCORE_EXPORT void drawSurface(PlatformContextCairo&, cairo_surface_t*, const FloatRect&, const FloatRect&, InterpolationQuality, float, const ShadowState&);
 
 void drawRect(PlatformContextCairo&, const FloatRect&, float, const Color&, StrokeStyle, const Color&);
 void drawLine(PlatformContextCairo&, const FloatPoint&, const FloatPoint&, StrokeStyle, const Color&, float, bool);

Modified: trunk/Source/WebCore/platform/graphics/cairo/GraphicsContextImplCairo.h (230228 => 230229)


--- trunk/Source/WebCore/platform/graphics/cairo/GraphicsContextImplCairo.h	2018-04-04 00:46:50 UTC (rev 230228)
+++ trunk/Source/WebCore/platform/graphics/cairo/GraphicsContextImplCairo.h	2018-04-04 00:56:07 UTC (rev 230229)
@@ -38,8 +38,8 @@
 
 class GraphicsContextImplCairo final : public GraphicsContextImpl {
 public:
-    static GraphicsContext::GraphicsContextImplFactory createFactory(PlatformContextCairo&);
-    static GraphicsContext::GraphicsContextImplFactory createFactory(cairo_t*);
+    WEBCORE_EXPORT static GraphicsContext::GraphicsContextImplFactory createFactory(PlatformContextCairo&);
+    WEBCORE_EXPORT static GraphicsContext::GraphicsContextImplFactory createFactory(cairo_t*);
 
     GraphicsContextImplCairo(GraphicsContext&, PlatformContextCairo&);
     GraphicsContextImplCairo(GraphicsContext&, cairo_t*);

Modified: trunk/Source/WebCore/platform/graphics/texmap/TextureMapperLayer.h (230228 => 230229)


--- trunk/Source/WebCore/platform/graphics/texmap/TextureMapperLayer.h	2018-04-04 00:46:50 UTC (rev 230228)
+++ trunk/Source/WebCore/platform/graphics/texmap/TextureMapperLayer.h	2018-04-04 00:56:07 UTC (rev 230229)
@@ -34,11 +34,11 @@
 class TextureMapperPaintOptions;
 class TextureMapperPlatformLayer;
 
-class TextureMapperLayer {
+class WEBCORE_EXPORT TextureMapperLayer {
     WTF_MAKE_NONCOPYABLE(TextureMapperLayer);
     WTF_MAKE_FAST_ALLOCATED;
 public:
-    WEBCORE_EXPORT TextureMapperLayer();
+    TextureMapperLayer();
     virtual ~TextureMapperLayer();
 
     void setID(uint32_t id) { m_id = id; }

Modified: trunk/Source/WebCore/platform/network/HTTPHeaderMap.h (230228 => 230229)


--- trunk/Source/WebCore/platform/network/HTTPHeaderMap.h	2018-04-04 00:46:50 UTC (rev 230228)
+++ trunk/Source/WebCore/platform/network/HTTPHeaderMap.h	2018-04-04 00:56:07 UTC (rev 230229)
@@ -114,7 +114,7 @@
     WEBCORE_EXPORT HTTPHeaderMap();
 
     // Gets a copy of the data suitable for passing to another thread.
-    HTTPHeaderMap isolatedCopy() const;
+    WEBCORE_EXPORT HTTPHeaderMap isolatedCopy() const;
 
     bool isEmpty() const { return m_commonHeaders.isEmpty() && m_uncommonHeaders.isEmpty(); }
     int size() const { return m_commonHeaders.size() + m_uncommonHeaders.size(); }

Modified: trunk/Source/WebCore/platform/network/ResourceRequestBase.h (230228 => 230229)


--- trunk/Source/WebCore/platform/network/ResourceRequestBase.h	2018-04-04 00:46:50 UTC (rev 230228)
+++ trunk/Source/WebCore/platform/network/ResourceRequestBase.h	2018-04-04 00:56:07 UTC (rev 230229)
@@ -88,9 +88,9 @@
     WEBCORE_EXPORT String httpHeaderField(HTTPHeaderName) const;
     WEBCORE_EXPORT void setHTTPHeaderField(const String& name, const String& value);
     WEBCORE_EXPORT void setHTTPHeaderField(HTTPHeaderName, const String& value);
-    void addHTTPHeaderField(HTTPHeaderName, const String& value);
-    void addHTTPHeaderField(const String& name, const String& value);
-    void addHTTPHeaderFieldIfNotPresent(HTTPHeaderName, const String&);
+    WEBCORE_EXPORT void addHTTPHeaderField(HTTPHeaderName, const String& value);
+    WEBCORE_EXPORT void addHTTPHeaderField(const String& name, const String& value);
+    WEBCORE_EXPORT void addHTTPHeaderFieldIfNotPresent(HTTPHeaderName, const String&);
 
     bool hasHTTPHeaderField(HTTPHeaderName) const;
 

Modified: trunk/Source/WebCore/platform/network/ResourceResponseBase.h (230228 => 230229)


--- trunk/Source/WebCore/platform/network/ResourceResponseBase.h	2018-04-04 00:46:50 UTC (rev 230228)
+++ trunk/Source/WebCore/platform/network/ResourceResponseBase.h	2018-04-04 00:56:07 UTC (rev 230229)
@@ -109,8 +109,8 @@
     WEBCORE_EXPORT void setHTTPHeaderField(const String& name, const String& value);
     WEBCORE_EXPORT void setHTTPHeaderField(HTTPHeaderName, const String& value);
 
-    void addHTTPHeaderField(HTTPHeaderName, const String& value);
-    void addHTTPHeaderField(const String& name, const String& value);
+    WEBCORE_EXPORT void addHTTPHeaderField(HTTPHeaderName, const String& value);
+    WEBCORE_EXPORT void addHTTPHeaderField(const String& name, const String& value);
 
     // Instead of passing a string literal to any of these functions, just use a HTTPHeaderName instead.
     template<size_t length> String httpHeaderField(const char (&)[length]) const = delete;

Modified: trunk/Source/WebCore/platform/network/curl/AuthenticationChallenge.h (230228 => 230229)


--- trunk/Source/WebCore/platform/network/curl/AuthenticationChallenge.h	2018-04-04 00:46:50 UTC (rev 230228)
+++ trunk/Source/WebCore/platform/network/curl/AuthenticationChallenge.h	2018-04-04 00:56:07 UTC (rev 230229)
@@ -33,7 +33,7 @@
 
 class CurlResponse;
 
-class AuthenticationChallenge final : public AuthenticationChallengeBase {
+class WEBCORE_EXPORT AuthenticationChallenge final : public AuthenticationChallengeBase {
 public:
     AuthenticationChallenge()
     {

Modified: trunk/Source/WebCore/platform/network/curl/CurlFormDataStream.h (230228 => 230229)


--- trunk/Source/WebCore/platform/network/curl/CurlFormDataStream.h	2018-04-04 00:46:50 UTC (rev 230228)
+++ trunk/Source/WebCore/platform/network/curl/CurlFormDataStream.h	2018-04-04 00:56:07 UTC (rev 230229)
@@ -35,7 +35,7 @@
 class CurlFormDataStream {
 public:
     CurlFormDataStream(const FormData*);
-    ~CurlFormDataStream();
+    WEBCORE_EXPORT ~CurlFormDataStream();
 
     void clean();
 

Modified: trunk/Source/WebCore/platform/network/curl/CurlRequest.h (230228 => 230229)


--- trunk/Source/WebCore/platform/network/curl/CurlRequest.h	2018-04-04 00:46:50 UTC (rev 230228)
+++ trunk/Source/WebCore/platform/network/curl/CurlRequest.h	2018-04-04 00:56:07 UTC (rev 230229)
@@ -64,12 +64,12 @@
     virtual ~CurlRequest() = default;
 
     void invalidateClient() { m_client = nullptr;  }
-    void setUserPass(const String&, const String&);
+    WEBCORE_EXPORT void setUserPass(const String&, const String&);
 
     void start(bool isSyncRequest = false);
     void cancel();
-    void suspend();
-    void resume();
+    WEBCORE_EXPORT void suspend();
+    WEBCORE_EXPORT void resume();
 
     const ResourceRequest& resourceRequest() const { return m_request; }
     bool isSyncRequest() const { return m_isSyncRequest; }
@@ -79,7 +79,7 @@
 
 
     // Processing for DidReceiveResponse
-    void completeDidReceiveResponse();
+    WEBCORE_EXPORT void completeDidReceiveResponse();
 
     // Download
     void enableDownloadToFile();

Modified: trunk/Source/WebCore/platform/network/curl/CurlSSLHandle.h (230228 => 230229)


--- trunk/Source/WebCore/platform/network/curl/CurlSSLHandle.h	2018-04-04 00:46:50 UTC (rev 230228)
+++ trunk/Source/WebCore/platform/network/curl/CurlSSLHandle.h	2018-04-04 00:56:07 UTC (rev 230229)
@@ -45,7 +45,7 @@
     bool shouldIgnoreSSLErrors() const { return m_ignoreSSLErrors; }
     const char* getCACertPath() const { return m_caCertPath.data(); }
 
-    void setHostAllowsAnyHTTPSCertificate(const String&);
+    WEBCORE_EXPORT void setHostAllowsAnyHTTPSCertificate(const String&);
     bool isAllowedHTTPSCertificateHost(const String&);
     bool canIgnoredHTTPSCertificate(const String&, const ListHashSet<String>&);
 

Modified: trunk/Source/WebCore/platform/network/curl/ResourceError.h (230228 => 230229)


--- trunk/Source/WebCore/platform/network/curl/ResourceError.h	2018-04-04 00:46:50 UTC (rev 230228)
+++ trunk/Source/WebCore/platform/network/curl/ResourceError.h	2018-04-04 00:56:07 UTC (rev 230229)
@@ -44,7 +44,7 @@
     {
     }
 
-    static ResourceError httpError(int errorCode, const URL& failingURL, Type = Type::General);
+    WEBCORE_EXPORT static ResourceError httpError(int errorCode, const URL& failingURL, Type = Type::General);
     static ResourceError sslError(int errorCode, unsigned sslErrors, const URL& failingURL);
 
     unsigned sslErrors() const { return m_sslErrors; }

Modified: trunk/Source/WebCore/platform/network/curl/ResourceResponse.h (230228 => 230229)


--- trunk/Source/WebCore/platform/network/curl/ResourceResponse.h	2018-04-04 00:46:50 UTC (rev 230228)
+++ trunk/Source/WebCore/platform/network/curl/ResourceResponse.h	2018-04-04 00:56:07 UTC (rev 230229)
@@ -34,7 +34,7 @@
 
 class CurlResponse;
 
-class ResourceResponse : public ResourceResponseBase {
+class WEBCORE_EXPORT ResourceResponse : public ResourceResponseBase {
 public:
     ResourceResponse()
         : ResourceResponseBase()
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to