Title: [230235] branches/safari-605-branch/Source/_javascript_Core
- Revision
- 230235
- Author
- [email protected]
- Date
- 2018-04-03 20:27:23 -0700 (Tue, 03 Apr 2018)
Log Message
Cherry-pick r229962. rdar://problem/39122091
r228149 accidentally removed code that resets m_emptyCursor at the end of a GC
https://bugs.webkit.org/show_bug.cgi?id=183995
Reviewed by Filip Pizlo.
The removal of this line of code was unintended and happened during some
refactoring Fil was doing. The consequence of removing this line of code
is that the m_emptyCursor became a monotonically increasing integer, leading
the cursor to usually being out of bounds of the block range (depending on
what the program is doing). This made the functionality of finding an empty
block to steal almost always fail.
* heap/BlockDirectory.cpp:
(JSC::BlockDirectory::prepareForAllocation):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@229962 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Modified Paths
Diff
Modified: branches/safari-605-branch/Source/_javascript_Core/ChangeLog (230234 => 230235)
--- branches/safari-605-branch/Source/_javascript_Core/ChangeLog 2018-04-04 03:27:21 UTC (rev 230234)
+++ branches/safari-605-branch/Source/_javascript_Core/ChangeLog 2018-04-04 03:27:23 UTC (rev 230235)
@@ -1,5 +1,44 @@
2018-04-03 Jason Marcell <[email protected]>
+ Cherry-pick r229962. rdar://problem/39122091
+
+ r228149 accidentally removed code that resets m_emptyCursor at the end of a GC
+ https://bugs.webkit.org/show_bug.cgi?id=183995
+
+ Reviewed by Filip Pizlo.
+
+ The removal of this line of code was unintended and happened during some
+ refactoring Fil was doing. The consequence of removing this line of code
+ is that the m_emptyCursor became a monotonically increasing integer, leading
+ the cursor to usually being out of bounds of the block range (depending on
+ what the program is doing). This made the functionality of finding an empty
+ block to steal almost always fail.
+
+ * heap/BlockDirectory.cpp:
+ (JSC::BlockDirectory::prepareForAllocation):
+
+
+ git-svn-id: https://svn.webkit.org/repository/webkit/trunk@229962 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+ 2018-03-25 Saam Barati <[email protected]>
+
+ r228149 accidentally removed code that resets m_emptyCursor at the end of a GC
+ https://bugs.webkit.org/show_bug.cgi?id=183995
+
+ Reviewed by Filip Pizlo.
+
+ The removal of this line of code was unintended and happened during some
+ refactoring Fil was doing. The consequence of removing this line of code
+ is that the m_emptyCursor became a monotonically increasing integer, leading
+ the cursor to usually being out of bounds of the block range (depending on
+ what the program is doing). This made the functionality of finding an empty
+ block to steal almost always fail.
+
+ * heap/BlockDirectory.cpp:
+ (JSC::BlockDirectory::prepareForAllocation):
+
+2018-04-03 Jason Marcell <[email protected]>
+
Cherry-pick r229850. rdar://problem/39155286
Race Condition in arrayProtoFuncReverse() causes wrong results or crash
Modified: branches/safari-605-branch/Source/_javascript_Core/heap/BlockDirectory.cpp (230234 => 230235)
--- branches/safari-605-branch/Source/_javascript_Core/heap/BlockDirectory.cpp 2018-04-04 03:27:21 UTC (rev 230234)
+++ branches/safari-605-branch/Source/_javascript_Core/heap/BlockDirectory.cpp 2018-04-04 03:27:23 UTC (rev 230235)
@@ -191,6 +191,7 @@
});
m_unsweptCursor = 0;
+ m_emptyCursor = 0;
m_eden.clearAll();
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes