Title: [230249] branches/safari-605-branch/Source/WebCore
Revision
230249
Author
[email protected]
Date
2018-04-03 23:32:31 -0700 (Tue, 03 Apr 2018)

Log Message

Cherry-pick r230063. rdar://problem/39155049

    The SVGAnimatedProperty wrappers have to be detached from the referenced values before the SVGAnimatedType is deleted
    https://bugs.webkit.org/show_bug.cgi?id=183972

    Reviewed by Daniel Bates.

    If the SVGAnimatedType is a list type, e.g. SVGLengthListValues, the wrappers
    of the animated properties have to be detached from the items in the list
    before it's deleted.

    * svg/SVGAnimateElementBase.cpp:
    (WebCore::SVGAnimateElementBase::clearAnimatedType):

    git-svn-id: https://svn.webkit.org/repository/webkit/trunk@230063 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

Diff

Modified: branches/safari-605-branch/Source/WebCore/ChangeLog (230248 => 230249)


--- branches/safari-605-branch/Source/WebCore/ChangeLog	2018-04-04 06:11:15 UTC (rev 230248)
+++ branches/safari-605-branch/Source/WebCore/ChangeLog	2018-04-04 06:32:31 UTC (rev 230249)
@@ -1,5 +1,38 @@
 2018-04-03  Jason Marcell  <[email protected]>
 
+        Cherry-pick r230063. rdar://problem/39155049
+
+    The SVGAnimatedProperty wrappers have to be detached from the referenced values before the SVGAnimatedType is deleted
+    https://bugs.webkit.org/show_bug.cgi?id=183972
+    
+    Reviewed by Daniel Bates.
+    
+    If the SVGAnimatedType is a list type, e.g. SVGLengthListValues, the wrappers
+    of the animated properties have to be detached from the items in the list
+    before it's deleted.
+    
+    * svg/SVGAnimateElementBase.cpp:
+    (WebCore::SVGAnimateElementBase::clearAnimatedType):
+    
+    
+    git-svn-id: https://svn.webkit.org/repository/webkit/trunk@230063 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+    2018-03-28  Said Abou-Hallawa  <[email protected]>
+
+            The SVGAnimatedProperty wrappers have to be detached from the referenced values before the SVGAnimatedType is deleted
+            https://bugs.webkit.org/show_bug.cgi?id=183972
+
+            Reviewed by Daniel Bates.
+
+            If the SVGAnimatedType is a list type, e.g. SVGLengthListValues, the wrappers
+            of the animated properties have to be detached from the items in the list
+            before it's deleted.
+
+            * svg/SVGAnimateElementBase.cpp:
+            (WebCore::SVGAnimateElementBase::clearAnimatedType):
+
+2018-04-03  Jason Marcell  <[email protected]>
+
         Cherry-pick r230006. rdar://problem/38154623
 
     CSS mask images should be retrieved using potentially CORS-enabled fetch

Modified: branches/safari-605-branch/Source/WebCore/svg/SVGAnimateElementBase.cpp (230248 => 230249)


--- branches/safari-605-branch/Source/WebCore/svg/SVGAnimateElementBase.cpp	2018-04-04 06:11:15 UTC (rev 230248)
+++ branches/safari-605-branch/Source/WebCore/svg/SVGAnimateElementBase.cpp	2018-04-04 06:32:31 UTC (rev 230249)
@@ -300,6 +300,11 @@
     if (!m_animatedType)
         return;
 
+    // If the SVGAnimatedType is a list type, e.g. SVGLengthListValues, the wrappers of the
+    // animated properties have to be detached from the items in the list before it's deleted.
+    if (!m_animatedProperties.isEmpty())
+        m_animator->animValWillChange(m_animatedProperties);
+
     if (!targetElement) {
         m_animatedType = nullptr;
         return;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to