Title: [230305] trunk/Source/WebCore
Revision
230305
Author
cdu...@apple.com
Date
2018-04-05 10:32:08 -0700 (Thu, 05 Apr 2018)

Log Message

Unreviewed, rolling out r230042.

It is no longer needed now that it is safe to construct a
SecurityOrigin from an on-main thread

Reverted changeset:

"WebSocket::didReceiveMessage() may construct a SecurityOrigin
object on a non-main thread"
https://bugs.webkit.org/show_bug.cgi?id=184068
https://trac.webkit.org/changeset/230042

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (230304 => 230305)


--- trunk/Source/WebCore/ChangeLog	2018-04-05 17:22:32 UTC (rev 230304)
+++ trunk/Source/WebCore/ChangeLog	2018-04-05 17:32:08 UTC (rev 230305)
@@ -1,3 +1,17 @@
+2018-04-05  Chris Dumez  <cdu...@apple.com>
+
+        Unreviewed, rolling out r230042.
+
+        It is no longer needed now that it is safe to construct a
+        SecurityOrigin from an on-main thread
+
+        Reverted changeset:
+
+        "WebSocket::didReceiveMessage() may construct a SecurityOrigin
+        object on a non-main thread"
+        https://bugs.webkit.org/show_bug.cgi?id=184068
+        https://trac.webkit.org/changeset/230042
+
 2018-04-05  Yusuke Suzuki  <utatane....@gmail.com>
 
         [WTF] Remove StaticLock

Modified: trunk/Source/WebCore/Modules/websockets/WebSocket.cpp (230304 => 230305)


--- trunk/Source/WebCore/Modules/websockets/WebSocket.cpp	2018-04-05 17:22:32 UTC (rev 230304)
+++ trunk/Source/WebCore/Modules/websockets/WebSocket.cpp	2018-04-05 17:32:08 UTC (rev 230305)
@@ -572,7 +572,7 @@
     if (m_state != OPEN)
         return;
     ASSERT(scriptExecutionContext());
-    dispatchEvent(MessageEvent::create(msg, SecurityOriginData::fromURL(m_url).toString()));
+    dispatchEvent(MessageEvent::create(msg, SecurityOrigin::create(m_url)->toString()));
 }
 
 void WebSocket::didReceiveBinaryData(Vector<uint8_t>&& binaryData)
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to