Title: [230492] trunk/Source/ThirdParty/libwebrtc
Revision
230492
Author
you...@apple.com
Date
2018-04-10 14:13:14 -0700 (Tue, 10 Apr 2018)

Log Message

webrtc/datachannel/basic-tcp.html will crash with an invalid crash
https://bugs.webkit.org/show_bug.cgi?id=178285
<rdar://problem/34985374>

Reviewed by Eric Carlson.

Disable SIGPIPE for WebRTC sockets on Mac as well.

* Source/webrtc/rtc_base/physicalsocketserver.cc:
* WebKit/0001-Disable-SIGPIPE-for-WebRTC-sockets.patch: Added.

Modified Paths

Added Paths

Diff

Modified: trunk/Source/ThirdParty/libwebrtc/ChangeLog (230491 => 230492)


--- trunk/Source/ThirdParty/libwebrtc/ChangeLog	2018-04-10 20:58:57 UTC (rev 230491)
+++ trunk/Source/ThirdParty/libwebrtc/ChangeLog	2018-04-10 21:13:14 UTC (rev 230492)
@@ -1,3 +1,16 @@
+2018-04-10  Youenn Fablet  <you...@apple.com>
+
+        webrtc/datachannel/basic-tcp.html will crash with an invalid crash
+        https://bugs.webkit.org/show_bug.cgi?id=178285
+        <rdar://problem/34985374>
+
+        Reviewed by Eric Carlson.
+
+        Disable SIGPIPE for WebRTC sockets on Mac as well.
+
+        * Source/webrtc/rtc_base/physicalsocketserver.cc:
+        * WebKit/0001-Disable-SIGPIPE-for-WebRTC-sockets.patch: Added.
+
 2018-04-09  Youenn Fablet  <you...@apple.com>
 
         Use special software encoder mode in case there is no VCP not hardware encoder

Modified: trunk/Source/ThirdParty/libwebrtc/Source/webrtc/rtc_base/physicalsocketserver.cc (230491 => 230492)


--- trunk/Source/ThirdParty/libwebrtc/Source/webrtc/rtc_base/physicalsocketserver.cc	2018-04-10 20:58:57 UTC (rev 230491)
+++ trunk/Source/ThirdParty/libwebrtc/Source/webrtc/rtc_base/physicalsocketserver.cc	2018-04-10 21:13:14 UTC (rev 230492)
@@ -632,7 +632,7 @@
 #elif defined(WEBRTC_POSIX)
   fcntl(s_, F_SETFL, fcntl(s_, F_GETFL, 0) | O_NONBLOCK);
 #endif
-#if defined(WEBRTC_IOS)
+#if defined(WEBRTC_IOS) || (defined(WEBRTC_MAC) && defined(WEBRTC_WEBKIT_BUILD))
   // iOS may kill sockets when the app is moved to the background
   // (specifically, if the app doesn't use the "voip" UIBackgroundMode). When
   // we attempt to write to such a socket, SIGPIPE will be raised, which by

Added: trunk/Source/ThirdParty/libwebrtc/WebKit/0001-Disable-SIGPIPE-for-WebRTC-sockets.patch (0 => 230492)


--- trunk/Source/ThirdParty/libwebrtc/WebKit/0001-Disable-SIGPIPE-for-WebRTC-sockets.patch	                        (rev 0)
+++ trunk/Source/ThirdParty/libwebrtc/WebKit/0001-Disable-SIGPIPE-for-WebRTC-sockets.patch	2018-04-10 21:13:14 UTC (rev 230492)
@@ -0,0 +1,25 @@
+From ca7c3a4683bbafaaf8a7bbe9fcf7b99cd0a55441 Mon Sep 17 00:00:00 2001
+From: Youenn Fablet <you...@apple.com>
+Date: Mon, 9 Apr 2018 13:27:57 -0700
+Subject: [PATCH] Disable SIGPIPE for WebRTC sockets
+
+---
+ .../ThirdParty/libwebrtc/Source/webrtc/rtc_base/physicalsocketserver.cc | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/Source/ThirdParty/libwebrtc/Source/webrtc/rtc_base/physicalsocketserver.cc b/Source/ThirdParty/libwebrtc/Source/webrtc/rtc_base/physicalsocketserver.cc
+index 0d5fc525242..bba921b6692 100644
+--- a/Source/ThirdParty/libwebrtc/Source/webrtc/rtc_base/physicalsocketserver.cc
++++ b/Source/ThirdParty/libwebrtc/Source/webrtc/rtc_base/physicalsocketserver.cc
+@@ -632,7 +632,7 @@ bool SocketDispatcher::Initialize() {
+ #elif defined(WEBRTC_POSIX)
+   fcntl(s_, F_SETFL, fcntl(s_, F_GETFL, 0) | O_NONBLOCK);
+ #endif
+-#if defined(WEBRTC_IOS)
++#if defined(WEBRTC_IOS) || (defined(WEBRTC_MAC) && defined(WEBRTC_WEBKIT_BUILD))
+   // iOS may kill sockets when the app is moved to the background
+   // (specifically, if the app doesn't use the "voip" UIBackgroundMode). When
+   // we attempt to write to such a socket, SIGPIPE will be raised, which by
+-- 
+2.15.1 (Apple Git-101)
+
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to