Title: [230512] trunk/Source
Revision
230512
Author
bfulg...@apple.com
Date
2018-04-10 19:49:10 -0700 (Tue, 10 Apr 2018)

Log Message

Unreviewed follow-up to r230468.

Switch some RELEASE_ASSERTs in hot codepaths to normal DEBUG asserts.

Source/WebCore:

* page/mac/EventHandlerMac.mm:
(WebCore::lastEventIsMouseUp):
(WebCore::EventHandler::sendFakeEventsAfterWidgetTracking):
* platform/mac/EventLoopMac.mm:
(WebCore::EventLoop::cycle):

Source/WebKit:

* UIProcess/mac/PageClientImplMac.mm:
(WebKit::PageClientImpl::isViewWindowActive):
(WebKit::PageClientImpl::setCursor):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (230511 => 230512)


--- trunk/Source/WebCore/ChangeLog	2018-04-11 02:46:09 UTC (rev 230511)
+++ trunk/Source/WebCore/ChangeLog	2018-04-11 02:49:10 UTC (rev 230512)
@@ -1,3 +1,15 @@
+2018-04-10  Brent Fulgham  <bfulg...@apple.com>
+
+        Unreviewed follow-up to r230468.
+
+        Switch some RELEASE_ASSERTs in hot codepaths to normal DEBUG asserts.
+
+        * page/mac/EventHandlerMac.mm:
+        (WebCore::lastEventIsMouseUp):
+        (WebCore::EventHandler::sendFakeEventsAfterWidgetTracking):
+        * platform/mac/EventLoopMac.mm:
+        (WebCore::EventLoop::cycle):
+
 2018-04-10  Wenson Hsieh  <wenson_hs...@apple.com>
 
         Unreviewed, fix the iOS build

Modified: trunk/Source/WebCore/page/mac/EventHandlerMac.mm (230511 => 230512)


--- trunk/Source/WebCore/page/mac/EventHandlerMac.mm	2018-04-11 02:46:09 UTC (rev 230511)
+++ trunk/Source/WebCore/page/mac/EventHandlerMac.mm	2018-04-11 02:49:10 UTC (rev 230512)
@@ -201,7 +201,7 @@
     // It's not clear in what cases this is helpful now -- it's possible it can be removed. 
 
     ASSERT([NSApp isRunning]);
-    RELEASE_ASSERT(hasProcessPrivilege(ProcessPrivilege::CanCommunicateWithWindowServer));
+    ASSERT(hasProcessPrivilege(ProcessPrivilege::CanCommunicateWithWindowServer));
 
     BEGIN_BLOCK_OBJC_EXCEPTIONS;
     NSEvent *currentEventAfterHandlingMouseDown = [NSApp currentEvent];
@@ -572,7 +572,7 @@
     if (!view)
         return;
 
-    RELEASE_ASSERT(hasProcessPrivilege(ProcessPrivilege::CanCommunicateWithWindowServer));
+    ASSERT(hasProcessPrivilege(ProcessPrivilege::CanCommunicateWithWindowServer));
 
     BEGIN_BLOCK_OBJC_EXCEPTIONS;
 

Modified: trunk/Source/WebCore/platform/mac/EventLoopMac.mm (230511 => 230512)


--- trunk/Source/WebCore/platform/mac/EventLoopMac.mm	2018-04-11 02:46:09 UTC (rev 230511)
+++ trunk/Source/WebCore/platform/mac/EventLoopMac.mm	2018-04-11 02:49:10 UTC (rev 230512)
@@ -39,7 +39,7 @@
         [[NSRunLoop currentRunLoop] runUntilDate:[NSDate dateWithTimeIntervalSinceNow:0.05]];
         return;
     }
-    RELEASE_ASSERT(hasProcessPrivilege(ProcessPrivilege::CanCommunicateWithWindowServer));
+    ASSERT(hasProcessPrivilege(ProcessPrivilege::CanCommunicateWithWindowServer));
 #endif
     [NSApp setWindowsNeedUpdate:YES];
     if (NSEvent *event = [NSApp nextEventMatchingMask:NSEventMaskAny untilDate:[NSDate dateWithTimeIntervalSinceNow:0.05] inMode:NSDefaultRunLoopMode dequeue:YES])

Modified: trunk/Source/WebKit/ChangeLog (230511 => 230512)


--- trunk/Source/WebKit/ChangeLog	2018-04-11 02:46:09 UTC (rev 230511)
+++ trunk/Source/WebKit/ChangeLog	2018-04-11 02:49:10 UTC (rev 230512)
@@ -1,3 +1,13 @@
+2018-04-10  Brent Fulgham  <bfulg...@apple.com>
+
+        Unreviewed follow-up to r230468.
+
+        Switch some RELEASE_ASSERTs in hot codepaths to normal DEBUG asserts.
+
+        * UIProcess/mac/PageClientImplMac.mm:
+        (WebKit::PageClientImpl::isViewWindowActive):
+        (WebKit::PageClientImpl::setCursor):
+
 2018-04-10  Fujii Hironori  <hironori.fu...@sony.com>
 
         [Win] Add UserAgentWin.cpp

Modified: trunk/Source/WebKit/UIProcess/mac/PageClientImplMac.mm (230511 => 230512)


--- trunk/Source/WebKit/UIProcess/mac/PageClientImplMac.mm	2018-04-11 02:46:09 UTC (rev 230511)
+++ trunk/Source/WebKit/UIProcess/mac/PageClientImplMac.mm	2018-04-11 02:49:10 UTC (rev 230512)
@@ -161,7 +161,7 @@
 
 bool PageClientImpl::isViewWindowActive()
 {
-    RELEASE_ASSERT(hasProcessPrivilege(ProcessPrivilege::CanCommunicateWithWindowServer));
+    ASSERT(hasProcessPrivilege(ProcessPrivilege::CanCommunicateWithWindowServer));
     NSWindow *activeViewWindow = activeWindow();
     return activeViewWindow.isKeyWindow || [NSApp keyWindow] == activeViewWindow;
 }
@@ -292,7 +292,7 @@
 
 void PageClientImpl::setCursor(const WebCore::Cursor& cursor)
 {
-    RELEASE_ASSERT(hasProcessPrivilege(ProcessPrivilege::CanCommunicateWithWindowServer));
+    ASSERT(hasProcessPrivilege(ProcessPrivilege::CanCommunicateWithWindowServer));
     // FIXME: Would be nice to share this code with WebKit1's WebChromeClient.
 
     // The Web process may have asked to change the cursor when the view was in an active window, but
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to