Title: [230542] trunk/Source/WebCore
Revision
230542
Author
bfulg...@apple.com
Date
2018-04-11 12:52:56 -0700 (Wed, 11 Apr 2018)

Log Message

GraphicsLayerCA::createPlatformCALayer always disables extended color in its backing store
https://bugs.webkit.org/show_bug.cgi?id=184367
<rdar://problem/39249074>

Reviewed by Simon Fraser.

'createPlatformCALayer' always passes a nil widget, which early returns from 'screenSupportsExtendedColor'
with false. Instead, we should just pass the widget (nil or not) to the screen properties methods,
which will use the primary screen if no screen is specified. I.e., we shouldn't do an early return
here if the passed widget is nil.

* platform/mac/PlatformScreenMac.mm:
(WebCore::screenSupportsExtendedColor):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (230541 => 230542)


--- trunk/Source/WebCore/ChangeLog	2018-04-11 19:05:08 UTC (rev 230541)
+++ trunk/Source/WebCore/ChangeLog	2018-04-11 19:52:56 UTC (rev 230542)
@@ -1,3 +1,19 @@
+2018-04-11  Brent Fulgham  <bfulg...@apple.com>
+
+        GraphicsLayerCA::createPlatformCALayer always disables extended color in its backing store
+        https://bugs.webkit.org/show_bug.cgi?id=184367
+        <rdar://problem/39249074>
+
+        Reviewed by Simon Fraser.
+
+        'createPlatformCALayer' always passes a nil widget, which early returns from 'screenSupportsExtendedColor'
+        with false. Instead, we should just pass the widget (nil or not) to the screen properties methods,
+        which will use the primary screen if no screen is specified. I.e., we shouldn't do an early return
+        here if the passed widget is nil.
+
+        * platform/mac/PlatformScreenMac.mm:
+        (WebCore::screenSupportsExtendedColor):
+
 2018-04-11  Youenn Fablet  <you...@apple.com>
 
         Pass FetchOptions and SecurityOrigin as load parameters from WebProcess to NetworkProcess

Modified: trunk/Source/WebCore/platform/mac/PlatformScreenMac.mm (230541 => 230542)


--- trunk/Source/WebCore/platform/mac/PlatformScreenMac.mm	2018-04-11 19:05:08 UTC (rev 230541)
+++ trunk/Source/WebCore/platform/mac/PlatformScreenMac.mm	2018-04-11 19:52:56 UTC (rev 230542)
@@ -266,9 +266,6 @@
 
 bool screenSupportsExtendedColor(Widget* widget)
 {
-    if (!widget)
-        return false;
-
     if (!screenProperties().isEmpty())
         return getScreenProperties(widget).screenSupportsExtendedColor;
 
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to