Title: [230559] trunk
Revision
230559
Author
carlo...@webkit.org
Date
2018-04-12 00:01:57 -0700 (Thu, 12 Apr 2018)

Log Message

[GTK] Switch to use always complex text code path
https://bugs.webkit.org/show_bug.cgi?id=183285

Reviewed by Michael Catanzaro.

Source/WebKit:

Now that we have branched for 2.20, it's a good time to try using complex text path always. We can simply force
it for GTK+ port and see how it works for the whole release cycle and if we don't notice any issues or
performance regressions we release 2.22 with complex text path forced. A debug env variable is added to switch
back to auto without having to recompile. After 2.22 is released we can make a final decision and remove the env
variable.

* UIProcess/gtk/WebProcessPoolGtk.cpp:
(WebKit::WebProcessPool::platformInitializeWebProcess): Force complex text code path unless
WEBKIT_FORCE_COMPLEX_TEXT is present and set to 0.

Tools:

Keep the auto mode for the layout tests to avoid having to rebaseline a lot of tests.

* WebKitTestRunner/gtk/main.cpp:
(main): Set WEBKIT_FORCE_COMPLEX_TEXT to 0 unless it's already present in the environment.

Modified Paths

Diff

Modified: trunk/Source/WebKit/ChangeLog (230558 => 230559)


--- trunk/Source/WebKit/ChangeLog	2018-04-12 06:59:35 UTC (rev 230558)
+++ trunk/Source/WebKit/ChangeLog	2018-04-12 07:01:57 UTC (rev 230559)
@@ -1,3 +1,20 @@
+2018-04-12  Carlos Garcia Campos  <cgar...@igalia.com>
+
+        [GTK] Switch to use always complex text code path
+        https://bugs.webkit.org/show_bug.cgi?id=183285
+
+        Reviewed by Michael Catanzaro.
+
+        Now that we have branched for 2.20, it's a good time to try using complex text path always. We can simply force
+        it for GTK+ port and see how it works for the whole release cycle and if we don't notice any issues or
+        performance regressions we release 2.22 with complex text path forced. A debug env variable is added to switch
+        back to auto without having to recompile. After 2.22 is released we can make a final decision and remove the env
+        variable.
+
+        * UIProcess/gtk/WebProcessPoolGtk.cpp:
+        (WebKit::WebProcessPool::platformInitializeWebProcess): Force complex text code path unless
+        WEBKIT_FORCE_COMPLEX_TEXT is present and set to 0.
+
 2018-04-11  Zan Dobersek  <zdober...@igalia.com>
 
         [WPE] Make WebKitWebViewBackend object mandatory for webkit_web_view_new*() constructors

Modified: trunk/Source/WebKit/UIProcess/gtk/WebProcessPoolGtk.cpp (230558 => 230559)


--- trunk/Source/WebKit/UIProcess/gtk/WebProcessPoolGtk.cpp	2018-04-12 06:59:35 UTC (rev 230558)
+++ trunk/Source/WebKit/UIProcess/gtk/WebProcessPoolGtk.cpp	2018-04-12 07:01:57 UTC (rev 230559)
@@ -92,6 +92,11 @@
     parameters.memoryCacheDisabled = m_memoryCacheDisabled || cacheModel() == CacheModelDocumentViewer;
     parameters.proxySettings = m_networkProxySettings;
 
+    parameters.shouldAlwaysUseComplexTextCodePath = true;
+    const char* forceComplexText = getenv("WEBKIT_FORCE_COMPLEX_TEXT");
+    if (forceComplexText && !strcmp(forceComplexText, "0"))
+        parameters.shouldAlwaysUseComplexTextCodePath = m_alwaysUsesComplexTextCodePath;
+
 #if USE(GSTREAMER)
     parameters.gstreamerOptions = WebCore::extractGStreamerOptionsFromCommandLine();
 #endif

Modified: trunk/Tools/ChangeLog (230558 => 230559)


--- trunk/Tools/ChangeLog	2018-04-12 06:59:35 UTC (rev 230558)
+++ trunk/Tools/ChangeLog	2018-04-12 07:01:57 UTC (rev 230559)
@@ -1,3 +1,15 @@
+2018-04-12  Carlos Garcia Campos  <cgar...@igalia.com>
+
+        [GTK] Switch to use always complex text code path
+        https://bugs.webkit.org/show_bug.cgi?id=183285
+
+        Reviewed by Michael Catanzaro.
+
+        Keep the auto mode for the layout tests to avoid having to rebaseline a lot of tests.
+
+        * WebKitTestRunner/gtk/main.cpp:
+        (main): Set WEBKIT_FORCE_COMPLEX_TEXT to 0 unless it's already present in the environment.
+
 2018-04-11  Carlos Garcia Campos  <cgar...@igalia.com>
 
         [GLIB] Handle strings containing null characters

Modified: trunk/Tools/WebKitTestRunner/gtk/main.cpp (230558 => 230559)


--- trunk/Tools/WebKitTestRunner/gtk/main.cpp	2018-04-12 06:59:35 UTC (rev 230558)
+++ trunk/Tools/WebKitTestRunner/gtk/main.cpp	2018-04-12 07:01:57 UTC (rev 230559)
@@ -32,6 +32,8 @@
 
 int main(int argc, char** argv)
 {
+    g_setenv("WEBKIT_FORCE_COMPLEX_TEXT", "0", FALSE);
+
     gtk_init(&argc, &argv);
 
     GRefPtr<GPtrArray> languages = adoptGRef(g_ptr_array_new());
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to