Title: [230584] trunk/Source/WebCore
- Revision
- 230584
- Author
- ab...@igalia.com
- Date
- 2018-04-12 11:01:58 -0700 (Thu, 12 Apr 2018)
Log Message
[MSE] Add isValid() assertions on PlatformTimeRanges::add() range ends
https://bugs.webkit.org/show_bug.cgi?id=180253
Right now it's checked that start <= end but it's not checked that
neither of them is undefined.
When this happens, the bug can be hard to track down.
The assertion is not enabled for Mac because there is currently a test
that is hitting it.
Reviewed by Jer Noble.
* platform/graphics/PlatformTimeRanges.cpp:
(WebCore::PlatformTimeRanges::add):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (230583 => 230584)
--- trunk/Source/WebCore/ChangeLog 2018-04-12 17:51:33 UTC (rev 230583)
+++ trunk/Source/WebCore/ChangeLog 2018-04-12 18:01:58 UTC (rev 230584)
@@ -1,3 +1,21 @@
+2018-04-12 Alicia Boya García <ab...@igalia.com>
+
+ [MSE] Add isValid() assertions on PlatformTimeRanges::add() range ends
+ https://bugs.webkit.org/show_bug.cgi?id=180253
+
+ Right now it's checked that start <= end but it's not checked that
+ neither of them is undefined.
+
+ When this happens, the bug can be hard to track down.
+
+ The assertion is not enabled for Mac because there is currently a test
+ that is hitting it.
+
+ Reviewed by Jer Noble.
+
+ * platform/graphics/PlatformTimeRanges.cpp:
+ (WebCore::PlatformTimeRanges::add):
+
2018-04-12 Chris Dumez <cdu...@apple.com>
Process::setIdentifier() / Process::identifier() do not need a lock
Modified: trunk/Source/WebCore/platform/graphics/PlatformTimeRanges.cpp (230583 => 230584)
--- trunk/Source/WebCore/platform/graphics/PlatformTimeRanges.cpp 2018-04-12 17:51:33 UTC (rev 230583)
+++ trunk/Source/WebCore/platform/graphics/PlatformTimeRanges.cpp 2018-04-12 18:01:58 UTC (rev 230584)
@@ -134,7 +134,12 @@
void PlatformTimeRanges::add(const MediaTime& start, const MediaTime& end)
{
+#if !PLATFORM(MAC) // https://bugs.webkit.org/show_bug.cgi?id=180253
+ ASSERT(start.isValid());
+ ASSERT(end.isValid());
+#endif
ASSERT(start <= end);
+
unsigned overlappingArcIndex;
Range addedRange(start, end);
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
