Title: [230623] trunk/Source/bmalloc
- Revision
- 230623
- Author
- sbar...@apple.com
- Date
- 2018-04-12 23:52:36 -0700 (Thu, 12 Apr 2018)
Log Message
Lessen partial scavenge interval on x86-64
https://bugs.webkit.org/show_bug.cgi?id=184577
Rubber-stamped by Filip Pizlo.
I initially made the scavenge interval longer because I had thought the
shorter interval caused a JetStream regression. I was mistaken though.
I was looking at the wrong commit range when analyzing perf data.
This patch shortens the interval, but still keeps x86-64 50% longer than
other architectures. We know that scavenging frequently on Mac is less
important to overall system performance than it is on iOS.
* bmalloc/Scavenger.cpp:
(bmalloc::Scavenger::threadRunLoop):
Modified Paths
Diff
Modified: trunk/Source/bmalloc/ChangeLog (230622 => 230623)
--- trunk/Source/bmalloc/ChangeLog 2018-04-13 05:27:52 UTC (rev 230622)
+++ trunk/Source/bmalloc/ChangeLog 2018-04-13 06:52:36 UTC (rev 230623)
@@ -1,5 +1,23 @@
2018-04-12 Saam Barati <sbar...@apple.com>
+ Lessen partial scavenge interval on x86-64
+ https://bugs.webkit.org/show_bug.cgi?id=184577
+
+ Rubber-stamped by Filip Pizlo.
+
+ I initially made the scavenge interval longer because I had thought the
+ shorter interval caused a JetStream regression. I was mistaken though.
+ I was looking at the wrong commit range when analyzing perf data.
+
+ This patch shortens the interval, but still keeps x86-64 50% longer than
+ other architectures. We know that scavenging frequently on Mac is less
+ important to overall system performance than it is on iOS.
+
+ * bmalloc/Scavenger.cpp:
+ (bmalloc::Scavenger::threadRunLoop):
+
+2018-04-12 Saam Barati <sbar...@apple.com>
+
Raise the partial scavenge interval even more on x86-64
https://bugs.webkit.org/show_bug.cgi?id=184551
Modified: trunk/Source/bmalloc/bmalloc/Scavenger.cpp (230622 => 230623)
--- trunk/Source/bmalloc/bmalloc/Scavenger.cpp 2018-04-13 05:27:52 UTC (rev 230622)
+++ trunk/Source/bmalloc/bmalloc/Scavenger.cpp 2018-04-13 06:52:36 UTC (rev 230623)
@@ -408,7 +408,7 @@
}
#if BCPU(X86_64)
- auto partialScavengeInterval = std::chrono::milliseconds(36000);
+ auto partialScavengeInterval = std::chrono::milliseconds(12000);
#else
auto partialScavengeInterval = std::chrono::milliseconds(8000);
#endif
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
