Title: [230653] trunk/Tools
Revision
230653
Author
clo...@igalia.com
Date
2018-04-13 19:14:02 -0700 (Fri, 13 Apr 2018)

Log Message

[WPE] [webkitpy] The driver requirements should be checked before starting the tests
https://bugs.webkit.org/show_bug.cgi?id=184595

Reviewed by Michael Catanzaro.

Ensure Driver.check_driver() is checked at check_sys_deps() time.

* Scripts/webkitpy/port/wpe.py:
(WPEPort.check_sys_deps):

Modified Paths

Diff

Modified: trunk/Tools/ChangeLog (230652 => 230653)


--- trunk/Tools/ChangeLog	2018-04-14 01:07:24 UTC (rev 230652)
+++ trunk/Tools/ChangeLog	2018-04-14 02:14:02 UTC (rev 230653)
@@ -1,3 +1,15 @@
+2018-04-13  Carlos Alberto Lopez Perez  <clo...@igalia.com>
+
+        [WPE] [webkitpy] The driver requirements should be checked before starting the tests
+        https://bugs.webkit.org/show_bug.cgi?id=184595
+
+        Reviewed by Michael Catanzaro.
+
+        Ensure Driver.check_driver() is checked at check_sys_deps() time.
+
+        * Scripts/webkitpy/port/wpe.py:
+        (WPEPort.check_sys_deps):
+
 2018-04-13  Zalan Bujtas  <za...@apple.com>
 
         Rebaseline LayoutReloaded patch file (collectRenderersWithNeedsLayout).

Modified: trunk/Tools/Scripts/webkitpy/port/wpe.py (230652 => 230653)


--- trunk/Tools/Scripts/webkitpy/port/wpe.py	2018-04-14 01:07:24 UTC (rev 230652)
+++ trunk/Tools/Scripts/webkitpy/port/wpe.py	2018-04-14 02:14:02 UTC (rev 230653)
@@ -77,6 +77,9 @@
         environment['WEBKIT_EXEC_PATH'] = self._build_path('bin')
         return environment
 
+    def check_sys_deps(self, needs_http):
+        return super(WPEPort, self).check_sys_deps(needs_http) and self._driver_class().check_driver(self)
+
     def _generate_all_test_configurations(self):
         configurations = []
         for build_type in self.ALL_BUILD_TYPES:
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to