Title: [230747] trunk/Source/WebKit
- Revision
- 230747
- Author
- [email protected]
- Date
- 2018-04-17 20:07:10 -0700 (Tue, 17 Apr 2018)
Log Message
WebKit::DisplayLink maintains a strong reference to WebPageProxy, creating a reference cycle
https://bugs.webkit.org/show_bug.cgi?id=184718
Reviewed by Tim Horton.
It turns out that the m_webPageProxy back-reference in DisplayLink, which was creating a
reference cycle, wasn't ever read, so we can just remove it.
* UIProcess/mac/DisplayLink.cpp:
(WebKit::DisplayLink::DisplayLink):
* UIProcess/mac/DisplayLink.h:
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (230746 => 230747)
--- trunk/Source/WebKit/ChangeLog 2018-04-18 02:50:25 UTC (rev 230746)
+++ trunk/Source/WebKit/ChangeLog 2018-04-18 03:07:10 UTC (rev 230747)
@@ -1,3 +1,17 @@
+2018-04-17 Conrad Shultz <[email protected]>
+
+ WebKit::DisplayLink maintains a strong reference to WebPageProxy, creating a reference cycle
+ https://bugs.webkit.org/show_bug.cgi?id=184718
+
+ Reviewed by Tim Horton.
+
+ It turns out that the m_webPageProxy back-reference in DisplayLink, which was creating a
+ reference cycle, wasn't ever read, so we can just remove it.
+
+ * UIProcess/mac/DisplayLink.cpp:
+ (WebKit::DisplayLink::DisplayLink):
+ * UIProcess/mac/DisplayLink.h:
+
2018-04-17 Wenson Hsieh <[email protected]>
[Extra zoom mode] Double tap to zoom should account for text legibility in extra zoom mode
Modified: trunk/Source/WebKit/UIProcess/mac/DisplayLink.cpp (230746 => 230747)
--- trunk/Source/WebKit/UIProcess/mac/DisplayLink.cpp 2018-04-18 02:50:25 UTC (rev 230746)
+++ trunk/Source/WebKit/UIProcess/mac/DisplayLink.cpp 2018-04-18 03:07:10 UTC (rev 230747)
@@ -36,7 +36,6 @@
namespace WebKit {
DisplayLink::DisplayLink(WebCore::PlatformDisplayID displayID, WebPageProxy& webPageProxy)
- : m_webPageProxy(webPageProxy)
{
RELEASE_ASSERT(hasProcessPrivilege(ProcessPrivilege::CanCommunicateWithWindowServer));
CVReturn error = CVDisplayLinkCreateWithCGDisplay(displayID, &m_displayLink);
Modified: trunk/Source/WebKit/UIProcess/mac/DisplayLink.h (230746 => 230747)
--- trunk/Source/WebKit/UIProcess/mac/DisplayLink.h 2018-04-18 02:50:25 UTC (rev 230746)
+++ trunk/Source/WebKit/UIProcess/mac/DisplayLink.h 2018-04-18 03:07:10 UTC (rev 230747)
@@ -49,7 +49,6 @@
static CVReturn displayLinkCallback(CVDisplayLinkRef, const CVTimeStamp*, const CVTimeStamp*, CVOptionFlags, CVOptionFlags*, void* data);
CVDisplayLinkRef m_displayLink { nullptr };
- Ref<WebPageProxy> m_webPageProxy;
HashSet<unsigned> m_observers;
};
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
