Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (230855 => 230856)
--- trunk/Source/_javascript_Core/ChangeLog 2018-04-20 21:02:55 UTC (rev 230855)
+++ trunk/Source/_javascript_Core/ChangeLog 2018-04-20 21:10:56 UTC (rev 230856)
@@ -1,3 +1,21 @@
+2018-04-20 Daniel Bates <daba...@apple.com>
+
+ Remove code for compilers that did not support NSDMI for aggregates
+ https://bugs.webkit.org/show_bug.cgi?id=184599
+
+ Reviewed by Per Arne Vollan.
+
+ Remove workaround for earlier Visual Studio versions that did not support non-static data
+ member initializers (NSDMI) for aggregates. We have since updated all the build.webkit.org
+ and EWS bots to a newer version that supports this feature.
+
+ * domjit/DOMJITEffect.h:
+ (JSC::DOMJIT::Effect::Effect): Deleted.
+ * runtime/HasOwnPropertyCache.h:
+ (JSC::HasOwnPropertyCache::Entry::Entry): Deleted.
+ * wasm/WasmFormat.h:
+ (JSC::Wasm::WasmToWasmImportableFunction::WasmToWasmImportableFunction): Deleted.
+
2018-04-20 Mark Lam <mark....@apple.com>
Build fix for internal builds after r230826.
Modified: trunk/Source/_javascript_Core/domjit/DOMJITEffect.h (230855 => 230856)
--- trunk/Source/_javascript_Core/domjit/DOMJITEffect.h 2018-04-20 21:02:55 UTC (rev 230855)
+++ trunk/Source/_javascript_Core/domjit/DOMJITEffect.h 2018-04-20 21:10:56 UTC (rev 230856)
@@ -30,20 +30,6 @@
namespace JSC { namespace DOMJIT {
struct Effect {
-#if !COMPILER_SUPPORTS(NSDMI_FOR_AGGREGATES)
- constexpr Effect() = default;
- constexpr Effect(HeapRange reads, HeapRange writes)
- : reads { reads }
- , writes { writes }
- {
- }
- constexpr Effect(HeapRange reads, HeapRange writes, HeapRange def)
- : reads { reads }
- , writes { writes }
- , def { def }
- {
- }
-#endif
constexpr static Effect forWrite(HeapRange writeRange)
{
Modified: trunk/Source/_javascript_Core/runtime/HasOwnPropertyCache.h (230855 => 230856)
--- trunk/Source/_javascript_Core/runtime/HasOwnPropertyCache.h 2018-04-20 21:02:55 UTC (rev 230855)
+++ trunk/Source/_javascript_Core/runtime/HasOwnPropertyCache.h 2018-04-20 21:10:56 UTC (rev 230856)
@@ -42,18 +42,6 @@
static ptrdiff_t offsetOfImpl() { return OBJECT_OFFSETOF(Entry, impl); }
static ptrdiff_t offsetOfResult() { return OBJECT_OFFSETOF(Entry, result); }
-#if !COMPILER_SUPPORTS(NSDMI_FOR_AGGREGATES)
- Entry() = default;
- Entry(RefPtr<UniquedStringImpl>&& impl, StructureID structureID, bool result)
- : impl { WTFMove(impl) }
- , structureID { structureID }
- , result { result }
- {
- }
-
- Entry& operator=(Entry&& other) = default;
-#endif
-
RefPtr<UniquedStringImpl> impl;
StructureID structureID { 0 };
bool result { false };
Modified: trunk/Source/_javascript_Core/wasm/WasmFormat.h (230855 => 230856)
--- trunk/Source/_javascript_Core/wasm/WasmFormat.h 2018-04-20 21:02:55 UTC (rev 230855)
+++ trunk/Source/_javascript_Core/wasm/WasmFormat.h 2018-04-20 21:10:56 UTC (rev 230856)
@@ -275,15 +275,6 @@
// meant as fast lookup tables for these opcodes and do not own code.
struct WasmToWasmImportableFunction {
using LoadLocation = MacroAssemblerCodePtr<WasmEntryPtrTag>*;
-#if !COMPILER_SUPPORTS(NSDMI_FOR_AGGREGATES)
- WasmToWasmImportableFunction() = default;
- WasmToWasmImportableFunction(SignatureIndex signatureIndex, LoadLocation entrypointLoadLocation)
- : signatureIndex { signatureIndex }
- , entrypointLoadLocation { entrypointLoadLocation }
- {
- }
-#endif
-
static ptrdiff_t offsetOfEntrypointLoadLocation() { return OBJECT_OFFSETOF(WasmToWasmImportableFunction, entrypointLoadLocation); }
// FIXME: Pack signature index and code pointer into one 64-bit value. See <https://bugs.webkit.org/show_bug.cgi?id=165511>.
Modified: trunk/Source/WTF/ChangeLog (230855 => 230856)
--- trunk/Source/WTF/ChangeLog 2018-04-20 21:02:55 UTC (rev 230855)
+++ trunk/Source/WTF/ChangeLog 2018-04-20 21:10:56 UTC (rev 230856)
@@ -1,3 +1,16 @@
+2018-04-20 Daniel Bates <daba...@apple.com>
+
+ Remove code for compilers that did not support NSDMI for aggregates
+ https://bugs.webkit.org/show_bug.cgi?id=184599
+
+ Reviewed by Per Arne Vollan.
+
+ Remove workaround for earlier Visual Studio versions that did not support non-static data
+ member initializers (NSDMI) for aggregates. We have since updated all the build.webkit.org
+ and EWS bots to a newer version that supports this feature.
+
+ * wtf/Compiler.h:
+
2018-04-19 David Kilzer <ddkil...@apple.com>
Enable Objective-C weak references
Modified: trunk/Source/WTF/wtf/Compiler.h (230855 => 230856)
--- trunk/Source/WTF/wtf/Compiler.h 2018-04-20 21:02:55 UTC (rev 230855)
+++ trunk/Source/WTF/wtf/Compiler.h 2018-04-20 21:10:56 UTC (rev 230856)
@@ -145,12 +145,8 @@
#define WTF_COMPILER_SUPPORTS_EABI 1
#endif
-/* Non-static data member initializer (NSDMI) for aggregates */
+/* ASAN_ENABLED and SUPPRESS_ASAN */
-#if defined(__cpp_aggregate_nsdmi) && __cpp_aggregate_nsdmi >= 201304
-#define WTF_COMPILER_SUPPORTS_NSDMI_FOR_AGGREGATES 1
-#endif
-
#define ASAN_ENABLED COMPILER_HAS_CLANG_FEATURE(address_sanitizer)
#if ASAN_ENABLED
Modified: trunk/Source/WebCore/ChangeLog (230855 => 230856)
--- trunk/Source/WebCore/ChangeLog 2018-04-20 21:02:55 UTC (rev 230855)
+++ trunk/Source/WebCore/ChangeLog 2018-04-20 21:10:56 UTC (rev 230856)
@@ -1,3 +1,40 @@
+2018-04-20 Daniel Bates <daba...@apple.com>
+
+ Remove code for compilers that did not support NSDMI for aggregates
+ https://bugs.webkit.org/show_bug.cgi?id=184599
+
+ Reviewed by Per Arne Vollan.
+
+ Remove workaround for earlier Visual Studio versions that did not support non-static data
+ member initializers (NSDMI) for aggregates. We have since updated all the build.webkit.org
+ and EWS bots to a newer version that supports this feature.
+
+ * Modules/cache/CacheQueryOptions.h:
+ (WebCore::CacheQueryOptions::CacheQueryOptions): Deleted.
+ * dom/Node.h:
+ (WebCore::Node::InsertionType::InsertionType): Deleted.
+ (WebCore::Node::RemovalType::RemovalType): Deleted.
+ * html/canvas/CanvasStyle.h:
+ (WebCore::CanvasStyle::CMYKAColor::CMYKAColor): Deleted.
+ * page/EventHandler.h:
+ (WebCore::EventHandler::DragTargetResponse::DragTargetResponse): Deleted.
+ * page/animation/CSSAnimationController.h:
+ (WebCore::AnimationUpdate::AnimationUpdate): Deleted.
+ * platform/graphics/FontSelectionAlgorithm.h:
+ (WebCore::FontSelectionRequest::tied const):
+ (WebCore::FontSelectionRequest::FontSelectionRequest): Deleted.
+ (WebCore::FontSelectionCapabilities::FontSelectionCapabilities): Deleted.
+ * platform/mediastream/IceCandidate.h:
+ (WebCore::IceCandidate::IceCandidate): Deleted.
+ * platform/text/StringWithDirection.h:
+ (WebCore::StringWithDirection::StringWithDirection): Deleted.
+ * rendering/MarkedText.h:
+ (WebCore::MarkedText::MarkedText): Deleted.
+ * style/StyleUpdate.h:
+ (WebCore::Style::ElementUpdate::ElementUpdate): Deleted.
+ (WebCore::Style::ElementUpdates::ElementUpdates): Deleted.
+ (WebCore::Style::TextUpdate::TextUpdate): Deleted.
+
2018-04-20 Youenn Fablet <you...@apple.com>
WebPage sometimes incorrectly rules out PDF as a mime type that can be showed
Modified: trunk/Source/WebCore/Modules/cache/CacheQueryOptions.h (230855 => 230856)
--- trunk/Source/WebCore/Modules/cache/CacheQueryOptions.h 2018-04-20 21:02:55 UTC (rev 230855)
+++ trunk/Source/WebCore/Modules/cache/CacheQueryOptions.h 2018-04-20 21:10:56 UTC (rev 230856)
@@ -30,16 +30,6 @@
namespace WebCore {
struct CacheQueryOptions {
-#if !COMPILER_SUPPORTS(NSDMI_FOR_AGGREGATES)
- CacheQueryOptions() = default;
- CacheQueryOptions(bool ignoreSearch, bool ignoreMethod, bool ignoreVary, String&& cacheName)
- : ignoreSearch { ignoreSearch }
- , ignoreMethod { ignoreMethod }
- , ignoreVary { ignoreVary }
- , cacheName { WTFMove(cacheName) }
- {
- }
-#endif
CacheQueryOptions isolatedCopy() const { return { ignoreSearch, ignoreMethod, ignoreVary, cacheName.isolatedCopy() }; }
bool ignoreSearch { false };
Modified: trunk/Source/WebCore/dom/Node.h (230855 => 230856)
--- trunk/Source/WebCore/dom/Node.h 2018-04-20 21:02:55 UTC (rev 230855)
+++ trunk/Source/WebCore/dom/Node.h 2018-04-20 21:10:56 UTC (rev 230856)
@@ -440,12 +440,6 @@
};
struct InsertionType {
-#if !COMPILER_SUPPORTS(NSDMI_FOR_AGGREGATES)
- InsertionType(bool connectedToDocument, bool treeScopeChanged)
- : connectedToDocument(connectedToDocument)
- , treeScopeChanged(treeScopeChanged)
- { }
-#endif
bool connectedToDocument { false };
bool treeScopeChanged { false };
};
@@ -455,12 +449,6 @@
virtual void didFinishInsertingNode() { }
struct RemovalType {
-#if !COMPILER_SUPPORTS(NSDMI_FOR_AGGREGATES)
- RemovalType(bool disconnectedFromDocument, bool treeScopeChanged)
- : disconnectedFromDocument(disconnectedFromDocument)
- , treeScopeChanged(treeScopeChanged)
- { }
-#endif
bool disconnectedFromDocument { false };
bool treeScopeChanged { false };
};
Modified: trunk/Source/WebCore/html/canvas/CanvasStyle.h (230855 => 230856)
--- trunk/Source/WebCore/html/canvas/CanvasStyle.h 2018-04-20 21:02:55 UTC (rev 230855)
+++ trunk/Source/WebCore/html/canvas/CanvasStyle.h 2018-04-20 21:10:56 UTC (rev 230856)
@@ -70,14 +70,6 @@
struct Invalid { };
struct CMYKAColor {
-#if !COMPILER_SUPPORTS(NSDMI_FOR_AGGREGATES)
- CMYKAColor() = default;
- CMYKAColor(Color color, float cyan, float magenta, float yellow, float black, float alpha)
- : color(color), c(cyan), m(magenta), y(yellow), k(black), a(alpha)
- {
- }
-#endif
-
Color color;
float c { 0 };
float m { 0 };
Modified: trunk/Source/WebCore/page/EventHandler.h (230855 => 230856)
--- trunk/Source/WebCore/page/EventHandler.h 2018-04-20 21:02:55 UTC (rev 230855)
+++ trunk/Source/WebCore/page/EventHandler.h 2018-04-20 21:10:56 UTC (rev 230856)
@@ -158,14 +158,6 @@
#if ENABLE(DRAG_SUPPORT)
struct DragTargetResponse {
-#if !COMPILER_SUPPORTS(NSDMI_FOR_AGGREGATES)
- DragTargetResponse() = default;
- DragTargetResponse(bool accept, std::optional<DragOperation> operation)
- : accept(accept)
- , operation(operation)
- {
- }
-#endif
bool accept { false };
std::optional<DragOperation> operation;
};
Modified: trunk/Source/WebCore/page/animation/CSSAnimationController.h (230855 => 230856)
--- trunk/Source/WebCore/page/animation/CSSAnimationController.h 2018-04-20 21:02:55 UTC (rev 230855)
+++ trunk/Source/WebCore/page/animation/CSSAnimationController.h 2018-04-20 21:10:56 UTC (rev 230856)
@@ -43,13 +43,6 @@
class RenderElement;
struct AnimationUpdate {
-#if !COMPILER_SUPPORTS(NSDMI_FOR_AGGREGATES)
- AnimationUpdate() = default;
- AnimationUpdate(std::unique_ptr<RenderStyle> style, bool stateChanged)
- : style(WTFMove(style))
- , stateChanged(stateChanged)
- { }
-#endif
std::unique_ptr<RenderStyle> style;
bool stateChanged { false };
};
Modified: trunk/Source/WebCore/platform/graphics/FontSelectionAlgorithm.h (230855 => 230856)
--- trunk/Source/WebCore/platform/graphics/FontSelectionAlgorithm.h 2018-04-20 21:02:55 UTC (rev 230855)
+++ trunk/Source/WebCore/platform/graphics/FontSelectionAlgorithm.h 2018-04-20 21:10:56 UTC (rev 230856)
@@ -337,17 +337,6 @@
{
return WTF::tie(weight, width, slope);
}
-
-#if !COMPILER_SUPPORTS(NSDMI_FOR_AGGREGATES)
- FontSelectionRequest() = default;
-
- constexpr FontSelectionRequest(Value weight, Value width, Value slope)
- : weight(weight)
- , width(width)
- , slope(slope)
- {
- }
-#endif
};
constexpr bool operator==(const FontSelectionRequest& a, const FontSelectionRequest& b)
@@ -385,17 +374,6 @@
Range weight { normalWeightValue() };
Range width { normalStretchValue() };
Range slope { normalItalicValue() };
-
-#if !COMPILER_SUPPORTS(NSDMI_FOR_AGGREGATES)
- FontSelectionCapabilities() = default;
-
- constexpr FontSelectionCapabilities(Range weight, Range width, Range slope)
- : weight(weight)
- , width(width)
- , slope(slope)
- {
- }
-#endif
};
constexpr bool operator==(const FontSelectionCapabilities& a, const FontSelectionCapabilities& b)
Modified: trunk/Source/WebCore/platform/mediastream/IceCandidate.h (230855 => 230856)
--- trunk/Source/WebCore/platform/mediastream/IceCandidate.h 2018-04-20 21:02:55 UTC (rev 230855)
+++ trunk/Source/WebCore/platform/mediastream/IceCandidate.h 2018-04-20 21:10:56 UTC (rev 230856)
@@ -37,23 +37,6 @@
namespace WebCore {
struct IceCandidate {
-#if !COMPILER_SUPPORTS(NSDMI_FOR_AGGREGATES)
- IceCandidate() = default;
- IceCandidate(String&& type, String&& foundation, unsigned componentId, String&& transport, unsigned long priority, String&& address, unsigned port, String&& tcpType, String&& relatedAddress, unsigned relatedPort)
- : type { WTFMove(type) }
- , foundation { WTFMove(foundation) }
- , componentId { componentId }
- , transport { WTFMove(transport) }
- , priority { priority }
- , address { WTFMove(address) }
- , port { port }
- , tcpType { WTFMove(tcpType) }
- , relatedAddress { WTFMove(relatedAddress) }
- , relatedPort { relatedPort }
- {
- }
-#endif
-
String type;
String foundation;
unsigned componentId { 0 };
Modified: trunk/Source/WebCore/platform/text/StringWithDirection.h (230855 => 230856)
--- trunk/Source/WebCore/platform/text/StringWithDirection.h 2018-04-20 21:02:55 UTC (rev 230855)
+++ trunk/Source/WebCore/platform/text/StringWithDirection.h 2018-04-20 21:10:56 UTC (rev 230856)
@@ -46,14 +46,6 @@
// to the string.
struct StringWithDirection {
-#if !COMPILER_SUPPORTS(NSDMI_FOR_AGGREGATES)
- StringWithDirection() = default;
- StringWithDirection(String string, TextDirection direction)
- : string { WTFMove(string) }
- , direction { direction }
- {
- }
-#endif
String string;
TextDirection direction { LTR };
};
Modified: trunk/Source/WebCore/rendering/MarkedText.h (230855 => 230856)
--- trunk/Source/WebCore/rendering/MarkedText.h 2018-04-20 21:02:55 UTC (rev 230855)
+++ trunk/Source/WebCore/rendering/MarkedText.h 2018-04-20 21:10:56 UTC (rev 230856)
@@ -47,16 +47,6 @@
Selection,
DraggedContent,
};
-#if !COMPILER_SUPPORTS(NSDMI_FOR_AGGREGATES)
- MarkedText() = default;
- MarkedText(unsigned startOffset, unsigned endOffset, Type type, const RenderedDocumentMarker* marker = nullptr)
- : startOffset { startOffset }
- , endOffset { endOffset }
- , type { type }
- , marker { marker }
- {
- }
-#endif
unsigned startOffset;
unsigned endOffset;
Type type;
Modified: trunk/Source/WebCore/style/StyleUpdate.h (230855 => 230856)
--- trunk/Source/WebCore/style/StyleUpdate.h 2018-04-20 21:02:55 UTC (rev 230855)
+++ trunk/Source/WebCore/style/StyleUpdate.h 2018-04-20 21:10:56 UTC (rev 230856)
@@ -43,15 +43,6 @@
namespace Style {
struct ElementUpdate {
-#if !COMPILER_SUPPORTS(NSDMI_FOR_AGGREGATES)
- ElementUpdate() = default;
- ElementUpdate(std::unique_ptr<RenderStyle> style, Change change, bool recompositeLayer)
- : style { WTFMove(style) }
- , change { change }
- , recompositeLayer { recompositeLayer }
- {
- }
-#endif
std::unique_ptr<RenderStyle> style;
Change change { NoChange };
bool recompositeLayer { false };
@@ -60,16 +51,6 @@
enum class DescendantsToResolve { None, ChildrenWithExplicitInherit, Children, All };
struct ElementUpdates {
-#if !COMPILER_SUPPORTS(NSDMI_FOR_AGGREGATES)
- ElementUpdates() = default;
- ElementUpdates(ElementUpdate update, DescendantsToResolve descendantsToResolve, std::optional<ElementUpdate> beforePseudoElementUpdate, std::optional<ElementUpdate> afterPseudoElementUpdate)
- : update { WTFMove(update) }
- , descendantsToResolve(descendantsToResolve)
- , beforePseudoElementUpdate { WTFMove(beforePseudoElementUpdate) }
- , afterPseudoElementUpdate { WTFMove(afterPseudoElementUpdate) }
- {
- }
-#endif
ElementUpdate update;
DescendantsToResolve descendantsToResolve { DescendantsToResolve::None };
std::optional<ElementUpdate> beforePseudoElementUpdate;
@@ -77,16 +58,6 @@
};
struct TextUpdate {
-#if !COMPILER_SUPPORTS(NSDMI_FOR_AGGREGATES)
- TextUpdate() = default;
- TextUpdate(unsigned offset, unsigned length, std::optional<std::unique_ptr<RenderStyle>> inheritedDisplayContentsStyle)
- : offset { offset }
- , length { length }
- , inheritedDisplayContentsStyle { WTFMove(inheritedDisplayContentsStyle) }
- {
- }
-#endif
-
unsigned offset { 0 };
unsigned length { std::numeric_limits<unsigned>::max() };
std::optional<std::unique_ptr<RenderStyle>> inheritedDisplayContentsStyle;
Modified: trunk/Source/bmalloc/ChangeLog (230855 => 230856)
--- trunk/Source/bmalloc/ChangeLog 2018-04-20 21:02:55 UTC (rev 230855)
+++ trunk/Source/bmalloc/ChangeLog 2018-04-20 21:10:56 UTC (rev 230856)
@@ -1,3 +1,19 @@
+2018-04-20 Daniel Bates <daba...@apple.com>
+
+ Remove code for compilers that did not support NSDMI for aggregates
+ https://bugs.webkit.org/show_bug.cgi?id=184599
+
+ Reviewed by Per Arne Vollan.
+
+ Remove workaround for earlier Visual Studio versions that did not support non-static data
+ member initializers (NSDMI) for aggregates. We have since updated all the build.webkit.org
+ and EWS bots to a newer version that supports this feature.
+
+ * bmalloc/BPlatform.h:
+ * bmalloc/List.h:
+ (bmalloc::ListNode::ListNode): Deleted.
+ (bmalloc::List::iterator::iterator): Deleted.
+
2018-04-19 David Kilzer <ddkil...@apple.com>
Enable Objective-C weak references
Modified: trunk/Source/bmalloc/bmalloc/BPlatform.h (230855 => 230856)
--- trunk/Source/bmalloc/bmalloc/BPlatform.h 2018-04-20 21:02:55 UTC (rev 230855)
+++ trunk/Source/bmalloc/bmalloc/BPlatform.h 2018-04-20 21:10:56 UTC (rev 230856)
@@ -81,11 +81,6 @@
/* BCOMPILER_SUPPORTS() - check for a compiler feature */
#define BCOMPILER_SUPPORTS(FEATURE) (defined BCOMPILER_SUPPORTS_##FEATURE && BCOMPILER_SUPPORTS_##FEATURE)
-/* BCOMPILER_SUPPORTS(NSDMI_FOR_AGGREGATES) - compiler supports non-static data member initializers for aggregates */
-#if defined(__cpp_aggregate_nsdmi) && __cpp_aggregate_nsdmi >= 201304
-#define BCOMPILER_SUPPORTS_NSDMI_FOR_AGGREGATES 1
-#endif
-
/* ==== Platform adaptation macros: these describe properties of the target environment. ==== */
/* BCPU() - the target CPU architecture */
Modified: trunk/Source/bmalloc/bmalloc/List.h (230855 => 230856)
--- trunk/Source/bmalloc/bmalloc/List.h 2018-04-20 21:02:55 UTC (rev 230855)
+++ trunk/Source/bmalloc/bmalloc/List.h 2018-04-20 21:10:56 UTC (rev 230856)
@@ -30,15 +30,6 @@
template<typename T>
struct ListNode {
-#if !BCOMPILER_SUPPORTS(NSDMI_FOR_AGGREGATES)
- ListNode() = default;
- ListNode(ListNode<T>* prev, ListNode<T>* next)
- : prev { prev }
- , next { next }
- {
- }
-#endif
-
ListNode<T>* prev { nullptr };
ListNode<T>* next { nullptr };
};
@@ -48,14 +39,6 @@
static_assert(std::is_trivially_destructible<T>::value, "List must have a trivial destructor.");
struct iterator {
-#if !BCOMPILER_SUPPORTS(NSDMI_FOR_AGGREGATES)
- iterator() = default;
- iterator(ListNode<T>* node)
- : m_node(node)
- {
- }
-#endif
-
T* operator*() { return static_cast<T*>(m_node); }
T* operator->() { return static_cast<T*>(m_node); }
