Title: [230910] trunk/Source/WebCore
- Revision
- 230910
- Author
- [email protected]
- Date
- 2018-04-23 06:39:53 -0700 (Mon, 23 Apr 2018)
Log Message
[GStreamer] Start implementing Audio/VideoTrackPrivateGSTreamer::kind method
https://bugs.webkit.org/show_bug.cgi?id=184650
Patch by Thibault Saunier <[email protected]> on 2018-04-23
Reviewed by Philippe Normand.
In the playbin3 case we can assume that if the GstStream is selected by default,
it is the Main track of that kind.
No new tests are added as:
* It relies on playbin3 case which support might be compiled out
* we already have a few test that are currently disabled in the mediastream
testsuite. This patch is part of the work to enable them.
* platform/graphics/gstreamer/AudioTrackPrivateGStreamer.cpp:
(WebCore::AudioTrackPrivateGStreamer::kind const):
* platform/graphics/gstreamer/AudioTrackPrivateGStreamer.h:
* platform/graphics/gstreamer/VideoTrackPrivateGStreamer.cpp:
(WebCore::VideoTrackPrivateGStreamer::kind const):
* platform/graphics/gstreamer/VideoTrackPrivateGStreamer.h:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (230909 => 230910)
--- trunk/Source/WebCore/ChangeLog 2018-04-23 11:19:01 UTC (rev 230909)
+++ trunk/Source/WebCore/ChangeLog 2018-04-23 13:39:53 UTC (rev 230910)
@@ -1,3 +1,25 @@
+2018-04-23 Thibault Saunier <[email protected]>
+
+ [GStreamer] Start implementing Audio/VideoTrackPrivateGSTreamer::kind method
+ https://bugs.webkit.org/show_bug.cgi?id=184650
+
+ Reviewed by Philippe Normand.
+
+ In the playbin3 case we can assume that if the GstStream is selected by default,
+ it is the Main track of that kind.
+
+ No new tests are added as:
+ * It relies on playbin3 case which support might be compiled out
+ * we already have a few test that are currently disabled in the mediastream
+ testsuite. This patch is part of the work to enable them.
+
+ * platform/graphics/gstreamer/AudioTrackPrivateGStreamer.cpp:
+ (WebCore::AudioTrackPrivateGStreamer::kind const):
+ * platform/graphics/gstreamer/AudioTrackPrivateGStreamer.h:
+ * platform/graphics/gstreamer/VideoTrackPrivateGStreamer.cpp:
+ (WebCore::VideoTrackPrivateGStreamer::kind const):
+ * platform/graphics/gstreamer/VideoTrackPrivateGStreamer.h:
+
2018-04-23 Alicia Boya García <[email protected]>
[MSE] Add allSamplesInTrackEnqueued event
Modified: trunk/Source/WebCore/platform/graphics/gstreamer/AudioTrackPrivateGStreamer.cpp (230909 => 230910)
--- trunk/Source/WebCore/platform/graphics/gstreamer/AudioTrackPrivateGStreamer.cpp 2018-04-23 11:19:01 UTC (rev 230909)
+++ trunk/Source/WebCore/platform/graphics/gstreamer/AudioTrackPrivateGStreamer.cpp 2018-04-23 13:39:53 UTC (rev 230910)
@@ -52,6 +52,14 @@
setActive(gst_stream_get_stream_flags(stream.get()) & GST_STREAM_FLAG_SELECT);
notifyTrackOfActiveChanged();
}
+
+AudioTrackPrivate::Kind AudioTrackPrivateGStreamer::kind() const
+{
+ if (m_stream.get() && gst_stream_get_stream_flags(m_stream.get()) & GST_STREAM_FLAG_SELECT)
+ return AudioTrackPrivate::Kind::Main;
+
+ return AudioTrackPrivate::kind();
+}
#endif
void AudioTrackPrivateGStreamer::disconnect()
Modified: trunk/Source/WebCore/platform/graphics/gstreamer/AudioTrackPrivateGStreamer.h (230909 => 230910)
--- trunk/Source/WebCore/platform/graphics/gstreamer/AudioTrackPrivateGStreamer.h 2018-04-23 11:19:01 UTC (rev 230909)
+++ trunk/Source/WebCore/platform/graphics/gstreamer/AudioTrackPrivateGStreamer.h 2018-04-23 13:39:53 UTC (rev 230910)
@@ -48,6 +48,8 @@
{
return adoptRef(*new AudioTrackPrivateGStreamer(player, index, stream));
}
+
+ Kind kind() const final;
#endif
void disconnect() override;
Modified: trunk/Source/WebCore/platform/graphics/gstreamer/VideoTrackPrivateGStreamer.cpp (230909 => 230910)
--- trunk/Source/WebCore/platform/graphics/gstreamer/VideoTrackPrivateGStreamer.cpp 2018-04-23 11:19:01 UTC (rev 230909)
+++ trunk/Source/WebCore/platform/graphics/gstreamer/VideoTrackPrivateGStreamer.cpp 2018-04-23 13:39:53 UTC (rev 230910)
@@ -52,6 +52,14 @@
setActive(gst_stream_get_stream_flags(stream.get()) & GST_STREAM_FLAG_SELECT);
notifyTrackOfActiveChanged();
}
+
+VideoTrackPrivate::Kind VideoTrackPrivateGStreamer::kind() const
+{
+ if (m_stream.get() && gst_stream_get_stream_flags(m_stream.get()) & GST_STREAM_FLAG_SELECT)
+ return VideoTrackPrivate::Kind::Main;
+
+ return VideoTrackPrivate::kind();
+}
#endif
void VideoTrackPrivateGStreamer::disconnect()
Modified: trunk/Source/WebCore/platform/graphics/gstreamer/VideoTrackPrivateGStreamer.h (230909 => 230910)
--- trunk/Source/WebCore/platform/graphics/gstreamer/VideoTrackPrivateGStreamer.h 2018-04-23 11:19:01 UTC (rev 230909)
+++ trunk/Source/WebCore/platform/graphics/gstreamer/VideoTrackPrivateGStreamer.h 2018-04-23 13:39:53 UTC (rev 230910)
@@ -48,6 +48,7 @@
{
return adoptRef(*new VideoTrackPrivateGStreamer(player, index, stream));
}
+ Kind kind() const final;
#endif
void disconnect() override;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
