Title: [230926] trunk/Tools
- Revision
- 230926
- Author
- [email protected]
- Date
- 2018-04-23 14:43:12 -0700 (Mon, 23 Apr 2018)
Log Message
[WKTR] Move navigation policy decision from the injected bundle to the UIProcess
https://bugs.webkit.org/show_bug.cgi?id=184801
Reviewed by Geoffrey Garen.
Move navigation policy decision from the injected bundle to the UIProcess in WebKitTestRunner.
This is a more common configuration and therefore should be the default testing configuration.
* WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::decidePolicyForNavigationAction):
Always respond with 'PassThrough' in the InjectedBundle so the UIProcess
is now asked for the policy decision.
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (230925 => 230926)
--- trunk/Tools/ChangeLog 2018-04-23 21:41:42 UTC (rev 230925)
+++ trunk/Tools/ChangeLog 2018-04-23 21:43:12 UTC (rev 230926)
@@ -1,3 +1,18 @@
+2018-04-23 Chris Dumez <[email protected]>
+
+ [WKTR] Move navigation policy decision from the injected bundle to the UIProcess
+ https://bugs.webkit.org/show_bug.cgi?id=184801
+
+ Reviewed by Geoffrey Garen.
+
+ Move navigation policy decision from the injected bundle to the UIProcess in WebKitTestRunner.
+ This is a more common configuration and therefore should be the default testing configuration.
+
+ * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
+ (WTR::InjectedBundlePage::decidePolicyForNavigationAction):
+ Always respond with 'PassThrough' in the InjectedBundle so the UIProcess
+ is now asked for the policy decision.
+
2018-04-23 Pablo Saavedra <[email protected]>
[GTK][WPE] Add Debug bots (build and tests) for WPE
Modified: trunk/Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp (230925 => 230926)
--- trunk/Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp 2018-04-23 21:41:42 UTC (rev 230925)
+++ trunk/Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp 2018-04-23 21:43:12 UTC (rev 230926)
@@ -1338,11 +1338,8 @@
injectedBundle.outputText(stringBuilder.toString());
}
- if (!injectedBundle.testRunner()->isPolicyDelegateEnabled()) {
- WKRetainPtr<WKStringRef> downloadAttributeRef(AdoptWK, WKBundleNavigationActionCopyDownloadAttribute(navigationAction));
- String downloadAttribute = toWTFString(downloadAttributeRef);
- return downloadAttribute.isNull() ? WKBundlePagePolicyActionUse : WKBundlePagePolicyActionPassThrough;
- }
+ if (!injectedBundle.testRunner()->isPolicyDelegateEnabled())
+ return WKBundlePagePolicyActionPassThrough;
WKRetainPtr<WKURLRef> url = ""
WKRetainPtr<WKStringRef> urlScheme = adoptWK(WKURLCopyScheme(url.get()));
@@ -1368,13 +1365,8 @@
stringBuilder.append('\n');
injectedBundle.outputText(stringBuilder.toString());
- if (injectedBundle.testRunner()->shouldDecideNavigationPolicyAfterDelay())
- return WKBundlePagePolicyActionPassThrough;
-
injectedBundle.testRunner()->notifyDone();
- if (injectedBundle.testRunner()->isPolicyDelegatePermissive())
- return WKBundlePagePolicyActionUse;
return WKBundlePagePolicyActionPassThrough;
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
